jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From loganmzz <...@git.apache.org>
Subject [GitHub] jmeter pull request #386: Adds parameter supports for RMI keystore creation ...
Date Wed, 23 May 2018 12:48:48 GMT
GitHub user loganmzz opened a pull request:

    https://github.com/apache/jmeter/pull/386

    Adds parameter supports for RMI keystore creation scripts

    Helps to integrate script into non-interactive process.
    
    ## Description
    <!--- Provide a general summary of your changes in the Title above -->
    Pass script parameters to keytool command
    
    <!--- Describe your changes in detail here -->
    N/A
    
    ## Motivation and Context
    <!--- Why is this change required? What problem does it solve? -->
    It helps caller to customize key creation and also enable to integrate script into non-interactive
process.
    <!--- If it fixes an open issue, please link to the issue here. -->
    
    ## How Has This Been Tested?
    <!--- Please describe in detail how you tested your changes. -->
    `${JMETER_HOME}/bin/create-rmi-keystore.sh -dname 'o=Foobar' -keypass 'f0o84R!'`
    
    `%JMETER_HOME%\bin\create-rmi-keystore.bat -dname 'o=Foobar' -keypass 'f0o84R!'`
    
    <!--- Include details of your testing environment, tests ran to see how -->
    * Linux: Debian 8 (Docker) + Open JDK 8u111
    * Windows:  7 Pro + Oracle JDK 8u152
    
    <!--- your change affects other areas of the code, etc. -->
    N/A
    
    ## Screenshots (if appropriate):
    N/A
    
    ## Types of changes
    <!--- What types of changes does your code introduce? Delete as appropriate -->
    - Bug fix (non-breaking change which fixes an issue)
    
    ## Checklist:
    <!--- Go over all the following points, and put an `x` in all the boxes that apply.
-->
    <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help!
-->
    - [x] My code follows the [code style][style-guide] of this project.
    - [ ] I have updated the documentation accordingly.
    
    [style-guide]: https://wiki.apache.org/jmeter/CodeStyleGuidelines


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/loganmzz/jmeter feature/rmi-create-script-support-parameters

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/jmeter/pull/386.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #386
    
----
commit 7a5e1ef1f3c4a5135b19d6b7f36408f7ea9faf05
Author: Logan Mauzaize (T524467) <t524467@...>
Date:   2018-05-23T12:26:31Z

    Adds parameter supports for RMI keystore creation scripts
    
    Helps to integrate script into non-interactive process.

----


---

Mime
View raw message