jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From FSchumacher <...@git.apache.org>
Subject [GitHub] jmeter pull request #389: Open different RemoteObjects on different ports.
Date Sat, 16 Jun 2018 14:32:52 GMT
GitHub user FSchumacher opened a pull request:

    https://github.com/apache/jmeter/pull/389

    Open different RemoteObjects on different ports.

    ## Description
    <!--- Provide a general summary of your changes in the Title above -->
    <!--- Describe your changes in detail here -->
    When using RMI over SSL with fixed `client.rmi.localport` JMeter currently throws an exception
as it has problems to bind RemoteObjects to the same port more than once.
    This change will use offsets for the different RemoteObjects, so that it will be possible
again to use a fixed port for those RMI objects.
    There is another bug in JMeter, that prevents a complete fix: Some of the remote listeners
will get initialized twice in GUI mode. That will lead to some similar problems.
    
    ## Motivation and Context
    <!--- Why is this change required? What problem does it solve? -->
    <!--- If it fixes an open issue, please link to the issue here. -->
    This bug was reported on the [users mailing list](https://lists.apache.org/thread.html/2de9386fb0f0c073eb9602837338c60981f1d22ded85661424ffa83e@%3Cuser.jmeter.apache.org%3E)
 and on [SO as "unable to start jmeter 4.0 client with ssl rmi"](https://stackoverflow.com/questions/50752126/unable-to-start-jmeter-4-0-client-with-ssl-rmi).
    
    ## How Has This Been Tested?
    <!--- Please describe in detail how you tested your changes. -->
    <!--- Include details of your testing environment, tests ran to see how -->
    <!--- your change affects other areas of the code, etc. -->
    Ran the tests and started a simple distributed setup with RMI over SSL.
    
    ## Screenshots (if appropriate):
    
    ## Types of changes
    <!--- What types of changes does your code introduce? Delete as appropriate -->
    - Bug fix (non-breaking change which fixes an issue)
    
    ## Checklist:
    <!--- Go over all the following points, and put an `x` in all the boxes that apply.
-->
    <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help!
-->
    - [x] My code follows the [code style][style-guide] of this project.
    - [x] I have updated the documentation accordingly.
    
    [style-guide]: https://wiki.apache.org/jmeter/CodeStyleGuidelines


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/FSchumacher/jmeter fix-rmi-localports

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/jmeter/pull/389.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #389
    
----
commit 6825ad4f1632681ce221daa1d468694294081b05
Author: Felix Schumacher <felix.schumacher@...>
Date:   2018-06-16T14:11:33Z

    Open different RemoteObjects on different ports.

----


---

Mime
View raw message