jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From artem-fedorov <...@git.apache.org>
Subject [GitHub] jmeter pull request #429: Fix 62887. Customized SampleLabel is ignored and o...
Date Mon, 12 Nov 2018 11:21:43 GMT
Github user artem-fedorov commented on a diff in the pull request:

    https://github.com/apache/jmeter/pull/429#discussion_r232621287
  
    --- Diff: bin/testfiles/TEST_HTTP_HttpClient4.xml ---
    @@ -144,7 +144,7 @@
       <httpSample s="true" lb="HR-FollowRedirect-18" rc="302" dt="text"/>
       <httpSample s="true" lb="HR-FollowRedirect-19" rc="302" dt="text"/>
       <httpSample s="true" lb="HR-FollowRedirect-20" rc="302" dt="text"/>
    -  <httpSample s="false" lb="HR-FollowRedirect-21" rc="Non HTTP response code: java.io.IOException"
dt="text"/>
    --- End diff --
    
    Because first 20 subSamples were added [here](https://github.com/apache/jmeter/blob/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java#L1593)
and the last SampleResult was [generated](https://github.com/apache/jmeter/blob/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java#L983)
from previous SubResult (that was renamed) and added [here](https://github.com/apache/jmeter/blob/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java#L1603).


---

Mime
View raw message