jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Felix Schumacher <felix.schumac...@internetallee.de>
Subject Re: svn commit: r1845700 - in /jmeter/trunk: src/core/org/apache/jmeter/threads/JMeterContext.java xdocs/changes.xml xdocs/usermanual/functions.xml
Date Sun, 04 Nov 2018 08:23:25 GMT


Am 3. November 2018 23:47:03 MEZ schrieb pmouawad@apache.org:
>Author: pmouawad
>Date: Sat Nov  3 22:47:02 2018
>New Revision: 1845700
>
>URL: http://svn.apache.org/viewvc?rev=1845700&view=rev
>Log:
>Bug 62752 - Add to Documentation: ctx.getThreadNum() 0-based and
>${__threadNum} 1-based
>Bugzilla Id: 62752
>
>Modified:
>    jmeter/trunk/src/core/org/apache/jmeter/threads/JMeterContext.java
>    jmeter/trunk/xdocs/changes.xml
>    jmeter/trunk/xdocs/usermanual/functions.xml
>
>Modified:
>jmeter/trunk/src/core/org/apache/jmeter/threads/JMeterContext.java
>URL:
>http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/threads/JMeterContext.java?rev=1845700&r1=1845699&r2=1845700&view=diff
>==============================================================================
>--- jmeter/trunk/src/core/org/apache/jmeter/threads/JMeterContext.java
>(original)
>+++ jmeter/trunk/src/core/org/apache/jmeter/threads/JMeterContext.java
>Sat Nov  3 22:47:02 2018
>@@ -143,7 +143,7 @@ public class JMeterContext {
>     }
> 
>     /**
>-     * Returns the threadNum.
>+     * Returns the threadNum which starts at 0
>      *
>      * @return int

I think for such a simple javadoc, it is enough to fill in the @return value with the description
and remove the first description. 

That would be
  @returns the threadNum starting from one

(numbers up to twelve are written as words ;) 


>      */
>
>Modified: jmeter/trunk/xdocs/changes.xml
>URL:
>http://svn.apache.org/viewvc/jmeter/trunk/xdocs/changes.xml?rev=1845700&r1=1845699&r2=1845700&view=diff
>==============================================================================
>--- jmeter/trunk/xdocs/changes.xml [utf-8] (original)
>+++ jmeter/trunk/xdocs/changes.xml [utf-8] Sat Nov  3 22:47:02 2018
>@@ -116,6 +116,7 @@ Summary
><li><bug>62826</bug>When changing LAF, make JMeter restart if user
>clicks yes to popup</li>
><li><bug>62744</bug>Upgrade jquery to version 3.3.1, jquery-ui to
>1.12.1, bootstrap to 3.3.7</li>
><li><bug>62257</bug><pr>401</pr>Expand/Collapse short key
><keysym>-</keysym> (minus sign) on numpad doesn't work. Contributed by
>Ori Marko (orimarko at gmail.com)</li>
>+   <li><bug>62752</bug>Add to Documentation:
><code>ctx.getThreadNum()</code> is 0-based while
><code>${__threadNum}</code> is 1-based</li>

Again I would prefer the numbers to be written out as zero-based and one-based. 

> </ul>
> 
> <ch_section>Non-functional changes</ch_section>
>
>Modified: jmeter/trunk/xdocs/usermanual/functions.xml
>URL:
>http://svn.apache.org/viewvc/jmeter/trunk/xdocs/usermanual/functions.xml?rev=1845700&r1=1845699&r2=1845700&view=diff
>==============================================================================
>--- jmeter/trunk/xdocs/usermanual/functions.xml (original)
>+++ jmeter/trunk/xdocs/usermanual/functions.xml Sat Nov  3 22:47:02
>2018
>@@ -378,6 +378,10 @@ If you want to have a count that increme
><description><p>The thread number function simply returns the number of
>the thread currently
>being executed.  These numbers are independent of ThreadGroup, meaning
>thread #1 in one threadgroup
>is indistinguishable from thread #1 in another threadgroup, from the
>point of view of this function.</p>
>+<note>The function returns a number between 1 and the max number of
>running threads. Note that if you're using 
>+JSR223 code with <a href="" >JMeterContext</a> object (ctx variable),
>the below code returns a number between 0 and (max number of running
>threads - 1)

Is the empty target in the link on purpose? 

Regards, 
 Felix 

>+<source>ctx.getThreadNum()</source>
>+</note>
> 
> <p>There are no arguments for this function.</p>
> <p>Usage Example:

Mime
View raw message