jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: Build failed in Jenkins: JMeter Ubuntu #929
Date Tue, 05 Nov 2019 10:44:33 GMT
On Tue, 5 Nov 2019 at 06:46, Vladimir Sitnikov
<sitnikov.vladimir@gmail.com> wrote:
>
> sebb>So is there a way to fix this so the line number *is* shown?
>
> For instance: avoid extending test methods and use delegation instead of
> inheritance.

Well yes, but that seems unnecessarily restrictive, and is only needed
if the test harness remains faulty.

> sebb>Such an error is likely to occur again elsewhere
>
> Why do you think so?
> There are no more than 5 such cases (I would say 1-2, but 5 is very
> conservative) in JMeter sources,
> so it is very unlikely similar cases would occur elsewhere.

It may still occur.

> It is far easier to just fix the assertion messages (if they ever occur)
> rather than discuss "oh, that is likely to occur".

But again, this should not be necessary.

> sebb>Unique messages are one way to achieve that if the test harness fails
> sebb>to provide that information, as in this case
>
> sebb>If the same message can appear in two places
>
> sebb>Yes, but that is missing my point.
> sebb>If the same message can appear in two places in the same test method then
> sebb>the test is **broken**.

> Remember that line numbers change over time (e.g. when tests are edited),
> and it is not the first thing to rely on.

I have always found it the most useful item of info; with editors one
can go direct to the right place.

Anyway, if the source is updated before the failure is investigated,
the tests are under source control so the original lines can be found
.

> In other words, assert messages should be good enough even without line
> number/stacktrace.

i.e. as I wrote originally, they need to be unique within a test case.

Unless inheritance is disallowed, they need to be unique within a method name.

I think the test harness is broken in this regard, and ought to be fixed.

> Vladimir

Mime
View raw message