jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Philippe Mouawad <philippe.moua...@gmail.com>
Subject Re: Hardcoded setEnableAutoCommitOnReturn=false
Date Tue, 17 Dec 2019 22:01:03 GMT
My proposal was in case we don't add ability to configure it.

So ok by me with Vladimir's proposal although it should be documented that
settings are kind of related.

On Tue, Dec 17, 2019 at 10:45 PM Dmitry Sherstobitov <sdn.xaoc@gmail.com>
wrote:

> Philippe,
>
> I don't think this will be the correct solution. It's still hardcoded in
> this case and strictly depends on autoCommit which is not obvious.
>
> I agree with Vladimir - this should be configurable.
>
> On Wed, Dec 18, 2019 at 12:07 AM Vladimir Sitnikov <
> sitnikov.vladimir@gmail.com> wrote:
>
> > Philippe>dataSource.setEnableAutoCommitOnReturn(isAutocommit());
> >
> > What do you think of adding a checkbox like "rollback on returning
> > connections to the pool"?
> >
> > Dmitry>I've created issue. Currently I can't find solution for that
> without
> > Dmitry>changing source code :(
> >
> > I guess it would make sense to make it configurable.
> >
> > Vladimir
> >
>
>
> --
> ------------------
> Best regards,
> Dmitry Sherstobitov
>


-- 
Cordialement.
Philippe Mouawad.

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message