jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <>
Subject [GitHub] [jmeter] vlsi commented on a change in pull request #603: Bug 64558 - Improve performances and throughput of Sample Results by lifting contention on writing SampleResults in CSV/XML
Date Wed, 01 Jul 2020 08:23:12 GMT

vlsi commented on a change in pull request #603:

File path: src/core/src/main/java/org/apache/jmeter/samplers/
@@ -0,0 +1,27 @@
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to you under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.jmeter.samplers;
+import org.apache.jmeter.threads.JMeterThread;
+ * Marker interface that informs {@link SampleListener} must be executed within {@link JMeterThread}
+ * @since 5.4
+ */
+public interface JMeterThreadBoundSampleListener extends SampleListener {

Review comment:
       Frankly speaking, I do not like `marker` interfaces. They provide very little way to
configure the behavior, and they can't be "unimplemented". In other words, I can't create
a subclass and adjust the marker.
   Could we stop using marker interfaces and use something else instead?

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:

View raw message