jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [jmeter] pmouawad commented on a change in pull request #603: Bug 64558 - Improve performances and throughput of Sample Results by lifting contention on writing SampleResults in CSV/XML
Date Fri, 03 Jul 2020 12:50:18 GMT

pmouawad commented on a change in pull request #603:
URL: https://github.com/apache/jmeter/pull/603#discussion_r449566892



##########
File path: src/core/src/main/java/org/apache/jmeter/reporters/ResultCollector.java
##########
@@ -338,6 +353,22 @@ public void testStarted(String host) {
         if(summariser != null) {
             summariser.testStarted(host);
         }
+        errorOnlyCached = isErrorLogging();
+        successOnlyCached = isSuccessOnlyLogging();
+        fileNameCached = getFilename();
+    }
+
+    private void saveSampleEvent(SampleEvent event, SampleSaveConfiguration saveConfig) {
+        try {
+            event.getResult().setSaveConfig(saveConfig);
+            if (saveConfig.saveAsXml()) {
+                SaveService.saveSampleResult(event, out);
+            } else { // !saveAsXml
+                CSVSaveService.saveSampleResult(event, out);
+            }
+        } catch (Exception err) {
+            log.error("Error trying to record a sample", err); // should throw exception
back to caller

Review comment:
       This was already there ASIS so we didn't touch it




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message