jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [jmeter] vlsi commented on a change in pull request #603: Bug 64558 - Improve performances and throughput of Sample Results by lifting contention on writing SampleResults in CSV/XML
Date Fri, 03 Jul 2020 13:15:00 GMT

vlsi commented on a change in pull request #603:
URL: https://github.com/apache/jmeter/pull/603#discussion_r449577736



##########
File path: src/core/src/main/java/org/apache/jmeter/samplers/JMeterThreadBoundSampleListener.java
##########
@@ -0,0 +1,27 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to you under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.jmeter.samplers;
+
+import org.apache.jmeter.threads.JMeterThread;
+
+/**
+ * Marker interface that informs {@link SampleListener} must be executed within {@link JMeterThread}
+ * @since 5.4
+ */
+public interface JMeterThreadBoundSampleListener extends SampleListener {

Review comment:
       >Don't you think that in the future those interface could end up with some methods
?
   
   If you add a method to an interface, you break backward compatibility as all the clients
need to implement the method.
   
   I guess the next big thing is to reduce memory consumption caused by thread plan cloning
for each thread.
   Adding new interfaces with methods makes it harder.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message