jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [jmeter] vlsi commented on a change in pull request #603: Bug 64558 - Improve performances and throughput of Sample Results by lifting contention on writing SampleResults in CSV/XML
Date Fri, 03 Jul 2020 13:29:37 GMT

vlsi commented on a change in pull request #603:
URL: https://github.com/apache/jmeter/pull/603#discussion_r449584385



##########
File path: src/components/src/main/java/org/apache/jmeter/visualizers/JSR223Listener.java
##########
@@ -38,7 +38,7 @@
  */
 @TestElementMetadata(labelResource = "displayName")
 public class JSR223Listener extends JSR223TestElement
-    implements Cloneable, SampleListener, TestBean, Visualizer {
+    implements Cloneable, JMeterThreadBoundSampleListener, TestBean, Visualizer {

Review comment:
       >No as I consider that if it does not implement the new interfaces, it should work
as currently , so be executed in JMeterThread.
   
   Do you consider the new interface to be a part of the public API?
   If that is the case, the users might implement that interface right after the version is
released, then you can't add methods there anymore.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message