jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [jmeter] pmouawad commented on a change in pull request #603: Bug 64558 - Improve performances and throughput of Sample Results by lifting contention on writing SampleResults in CSV/XML
Date Fri, 03 Jul 2020 13:40:34 GMT

pmouawad commented on a change in pull request #603:
URL: https://github.com/apache/jmeter/pull/603#discussion_r449589244



##########
File path: src/components/src/main/java/org/apache/jmeter/visualizers/JSR223Listener.java
##########
@@ -38,7 +38,7 @@
  */
 @TestElementMetadata(labelResource = "displayName")
 public class JSR223Listener extends JSR223TestElement
-    implements Cloneable, SampleListener, TestBean, Visualizer {
+    implements Cloneable, JMeterThreadBoundSampleListener, TestBean, Visualizer {

Review comment:
       As I said , for now I don't clearly see one.
   But for example, for JMeterThreadBoundSampleListener, would it be more clear to provide
a method like this one:
   void sampleOccurred(SampleEvent e, JMeterContext context);
   
   to indicating to implementer that he has access to JMeter thread context

##########
File path: src/components/src/main/java/org/apache/jmeter/visualizers/JSR223Listener.java
##########
@@ -38,7 +38,7 @@
  */
 @TestElementMetadata(labelResource = "displayName")
 public class JSR223Listener extends JSR223TestElement
-    implements Cloneable, SampleListener, TestBean, Visualizer {
+    implements Cloneable, JMeterThreadBoundSampleListener, TestBean, Visualizer {

Review comment:
       As I said , for now I don't clearly see one.
   But for example, for JMeterThreadBoundSampleListener, would it be more clear to provide
a method like this one:
   void sampleOccurred(SampleEvent e, JMeterContext context);
   
   to indicate  to implementer that he has access to JMeter thread context




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message