jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [jmeter] vlsi commented on a change in pull request #603: Bug 64558 - Improve performances and throughput of Sample Results by lifting contention on writing SampleResults in CSV/XML
Date Fri, 03 Jul 2020 14:06:13 GMT

vlsi commented on a change in pull request #603:
URL: https://github.com/apache/jmeter/pull/603#discussion_r449600799



##########
File path: src/components/src/main/java/org/apache/jmeter/visualizers/JSR223Listener.java
##########
@@ -38,7 +38,7 @@
  */
 @TestElementMetadata(labelResource = "displayName")
 public class JSR223Listener extends JSR223TestElement
-    implements Cloneable, SampleListener, TestBean, Visualizer {
+    implements Cloneable, JMeterThreadBoundSampleListener, TestBean, Visualizer {

Review comment:
       Marker interfaces are from Java 1.4 era. They have no place in 2020.
   
   I do not mean interfaces must not be used, however, I want to hear a strong justification
that something needs to be a marker interface.
   
   Modern tools (e.g. Gradle, JUnit5, Micronaut, Spring Framework, Spring Boot) never (?)
use marker interfaces.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message