jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [jmeter] vlsi commented on pull request #603: Bug 64558 - Improve performances and throughput of Sample Results by lifting contention on writing SampleResults in CSV/XML
Date Wed, 08 Jul 2020 20:29:45 GMT

vlsi commented on pull request #603:
URL: https://github.com/apache/jmeter/pull/603#issuecomment-655739766


   Please avoid naming like `JMeterThreadBoundSampleListener`.
   
   1) The annotation is in `org.jmeter....` package, so there's no need to duplicate `jmeter`
   2) Why do you have `SampleListener` there? Is the annotation only for listeners?
   3) Why do you have two annotations instead of a single annotation with an enum property?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message