jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [jmeter] weisJ commented on a change in pull request #617: Bug 64711 - Use theme from darklaf extensions for RSyntaxTextArea.
Date Wed, 09 Sep 2020 09:56:09 GMT

weisJ commented on a change in pull request #617:
URL: https://github.com/apache/jmeter/pull/617#discussion_r485488906



##########
File path: src/core/src/main/java/org/apache/jmeter/gui/util/JSyntaxTextArea.java
##########
@@ -44,20 +49,27 @@
 public class JSyntaxTextArea extends RSyntaxTextArea {
 
     private static final long serialVersionUID = 211L;
-    private static final Logger log              = LoggerFactory.getLogger(JSyntaxTextArea.class);
+    private static final Logger log = LoggerFactory.getLogger(JSyntaxTextArea.class);
 
+    private static final Theme DARKLAF_THEME = new DarklafRSyntaxTheme();

Review comment:
       No the static theme isn't necessary. I just tried to be as close to the previous implementation
as possible.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message