jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [jmeter] vlsi commented on pull request #615: Add: ElasticSearch backend listener
Date Thu, 17 Sep 2020 21:29:25 GMT

vlsi commented on pull request #615:
URL: https://github.com/apache/jmeter/pull/615#issuecomment-694509648


   Just in case, here's dependency impact.
   +5MiB is not that very expensive, however, it would be great if there was a brief explanation
of why the dependency is needed and why existing classes are not enough.
   
   For instance, we already have `jackson-*`, so do we really need `gson`?
   Do we need `guava`?
   Do we need AWS clients?
   
   ```
       55421535 => 60544843 bytes (+5123308 bytes)
       98 => 108 files (+10)
     
     + 1013903 aws-java-sdk-core-1.11.851.jar
     +  272295 aws-java-sdk-secretsmanager-1.11.851.jar
     +   12691 aws-signing-request-interceptor-0.0.22.jar
     +   64552 elasticsearch-rest-client-7.9.0.jar
     +  240255 gson-2.8.6.jar
     + 2256213 guava-18.0.jar
     +  565410 ion-java-1.0.2.jar
     +   48468 jackson-dataformat-cbor-2.6.7.jar
     +   27590 jmespath-java-1.11.851.jar
     +  621931 joda-time-2.8.1.jar
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message