jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [jmeter] vdaburon opened a new pull request #628: Add a boolean property to choose if we want to propagate the state of…
Date Sun, 27 Sep 2020 11:26:23 GMT

vdaburon opened a new pull request #628:
URL: https://github.com/apache/jmeter/pull/628


   … the current element to the children of the tree
   
   ## Description
   Add a new jmeter property to choose if you want to propagate the state of the current element
to the children of the tree OR NOT (gray for disable for all chidren in the tree).
   
   
   ## Motivation and Context
   The pull request https://github.com/apache/jmeter/pull/558  (Use gray icons for disabled
elements in the tree) could be usefull in many cases.
   
   But a script is not a simple tree from Thread Group but a graph when you use a Module Controler.
   
   ![arbo_chidren_enabled](https://user-images.githubusercontent.com/1881617/94363172-b7a9a000-00c0-11eb-8b74-567bbbd2e55b.png)
   
   In the Thread Group 1, somes samplers are enabled (001 and 015) and somes are disabled
(006, 008 and 014), you could see with the gray color or not.
   The Thread Group 2 with module controler use a module controler that go to the Thread Group
1 > Recording Controller.
   
   When i disable the "Thread Group 1" all the children samplers look disabled (gray), i can't
see witch samplers are "really" enabled or disabled.
   
   The Module Controler from Thead Group2 with module controler will call samplers children
of Recording Controller but **now i can't see witch samplers will be really call** because
all samplers look disabled.
   
   ![arbo_chidren_desabled](https://user-images.githubusercontent.com/1881617/94363191-ddcf4000-00c0-11eb-83d1-f60db79510cc.png)
   
   I add a jmeter.property to choose if you want to propagate the state of the current element
to the children of the tree or you do NOT want to propagate the state to children.
   
   ## How Has This Been Tested?
   Add log to see if new jmeter property jmeter.gui.propagates_parent_state_to_children=true
if this property is correcly read from jmeter.properties file
   
   Test with defaut value jmeter property jmeter.gui.propagates_parent_state_to_children=true
   
   Test with jmeter.gui.propagates_parent_state_to_children=false
   
   Create a new script with a tree and enabled ou disabled a element in the tree and see if
children are also change color gray or not
   
   ## Screenshots:
   jmeter.gui.propagates_parent_state_to_children=false
   
   ![arbo_children_no_propagate](https://user-images.githubusercontent.com/1881617/94363545-34d61480-00c3-11eb-897c-3fc7cfc9ca52.png)
   
   
   jmeter.gui.propagates_parent_state_to_children=true (defaut value)
   
   ![arbo_children_with_propagate](https://user-images.githubusercontent.com/1881617/94363644-d65d6600-00c3-11eb-8efa-6475b2510f77.png)
   
   
   ## Types of changes
   - New feature (non-breaking change which adds functionality)
   
   
   ## Checklist:
   - [x ] My code follows the [code style][style-guide] of this project.
   - [ ] I have updated the documentation accordingly.
   
   [style-guide]: https://wiki.apache.org/jmeter/CodeStyleGuidelines
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message