jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [jmeter] FSchumacher opened a new pull request #633: Make allowed version of freemarker explicit
Date Tue, 03 Nov 2020 15:23:48 GMT

FSchumacher opened a new pull request #633:
URL: https://github.com/apache/jmeter/pull/633


   ## Description
   
   Make the compatible version of freemarker template engine explicit.
   
   ## Motivation and Context
   
   The [freemarker docs state](https://freemarker.apache.org/docs/pgui_config_incompatible_improvements.html),
that it is not allowed to use `Config#getVersion()`
   directly, to specify the version, that we think we are compatible with.
   
   Therefore, let us specify the current version and update it, as we update
   the dependency or the templates.
   
   ## How Has This Been Tested?
   Ran `./gradlew build` and grepped for `getVersion` in `src/dist-check/jmeter.log` and the
following message is gone
   ```
   $ grep -r Configuration.getVersion src/dist-check/jmeter.log
   2020-11-03 16:20:29,732 ERROR f.configuration: DefaultObjectWrapper.incompatibleImprovements
was set to the object returned by Configuration.getVersion(). That defeats the purpose of
incompatibleImprovements, and makes upgrading FreeMarker a potentially breaking change. Also,
this probably won't be allowed starting from 2.4.0. Instead, set incompatibleImprovements
to the highest concrete version that's known to be compatible with your application.
   ```
   
   ## Screenshots (if appropriate):
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Delete as appropriate -->
   - Bug fix (non-breaking change which fixes an issue)
   
   ## Checklist:
   <!--- Go over all the following points, and put an `x` in all the boxes that apply.
-->
   <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help!
-->
   - [x] My code follows the [code style][style-guide] of this project.
   
   [style-guide]: https://wiki.apache.org/jmeter/CodeStyleGuidelines
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message