jmeter-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [jmeter] mjmadhu edited a comment on pull request #640: Fix to 65041
Date Fri, 12 Feb 2021 11:06:45 GMT

mjmadhu edited a comment on pull request #640:
URL: https://github.com/apache/jmeter/pull/640#issuecomment-778128536


   > Thanks for the PR.
   > In https://lists.apache.org/thread.html/r336aebd7963f0d377291cdd58aa9e74b6427a3e888da00441d78f6aa%40%3Cdev.jmeter.apache.org%3E
Philippe has tried another way of implementing this, which was hindered by a small bug. I
think that bug should be fixed.
   > What do you think?
   
   Hi,
   I think there's a difference in approach. The intent here is also to support timeout values
provided via jmeter properties and hc.parameters files given by the end users. The final HTTP
request made from **HTTPHCAbstractImpl.java** will pick a response timeout from the 3 options
in the following order of precedence (Response timeout in HTTP Sampler/ HTTP Request Defaults
> http.socket.timeout in hc.parameters > httpclient.timeout property in jmeter.properties)
- https://github.com/apache/jmeter/pull/640/files#diff-29609bda5c038501a23cff12e470709027f303766ea1f787c6d69dd71dce8819R199
   
   It's different from https://lists.apache.org/thread.html/r336aebd7963f0d377291cdd58aa9e74b6427a3e888da00441d78f6aa%40%3Cdev.jmeter.apache.org%3E
as:
   1. We're not trying to change/set default timeout value "only" via HTTP sampler. Hence,
we did not hit that bug as default value is still 0 if not provided.
   2. This PR is only for response timeout as of now, not including connect timeout.
   
   If we want to give specific default values for these timeouts, we can still have them in
jmeter.properties with this feature support.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message