johnzon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Romain Manni-Bucau <rmannibu...@gmail.com>
Subject Re: Changes in Numbers Json implemetations
Date Fri, 13 Mar 2015 14:12:04 GMT
Better but what about perf - was my main point?
 Le 13 mars 2015 15:03, "Daniel Cunha" <danielsoro@gmail.com> a écrit :

> Hi Romain,
>
>
> https://github.com/apache/incubator-johnzon/compare/master...danielsoro:numbers?expand=1
> WDYT!?
>
> patch attached.
>
>
> On Thu, Mar 12, 2015 at 6:37 PM, Romain Manni-Bucau
> <rmannibucau@gmail.com> wrote:
> > Hmm seems you do too much conversions in some cases (big decimal for
> > instance)
> >
> > That said i m not sure it brings (readability) more than it destroy
> (perf).
> > Any figures to proove me i am wrong?
> >  Le 12 mars 2015 21:50, "Daniel Cunha" <danielsoro@gmail.com> a écrit :
> >
> >> Hi folks,
> >>
> >>
> >>
> https://github.com/apache/incubator-johnzon/compare/master...danielsoro:numbers?expand=1
> >>
> >> I have this change in johnzon, maybe this patch can be apply.
> >> patch attached.
> >>
> >> --
> >> Best regard,
> >> Daniel Cunha (soro)
> >>
>
>
>
> --
> Best regard,
> Daniel Cunha (soro)
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message