johnzon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Romain Manni-Bucau (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (JOHNZON-48) Complex types in collection with converter
Date Fri, 03 Jul 2015 13:58:04 GMT

    [ https://issues.apache.org/jira/browse/JOHNZON-48?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14613204#comment-14613204
] 

Romain Manni-Bucau commented on JOHNZON-48:
-------------------------------------------

Hi

patch looks good I have however 2 comments before applying it:

- testObjectConverter should assert the result IMO and not only a notnull
- we should cache the converter by type for the collection (the look up needs to be fast so
can be even by object reference since Class ref are unique and the synchronisation cost will
be paid a single time). I dont think we can cache it globally but enhancing our collection
mapping model is super fine

do you want to try to enrich the patch with it? Then I'm more than happy to apply it.

> Complex types in collection with converter
> ------------------------------------------
>
>                 Key: JOHNZON-48
>                 URL: https://issues.apache.org/jira/browse/JOHNZON-48
>             Project: Johnzon
>          Issue Type: Bug
>          Components: Mapper
>    Affects Versions: 0.9-incubating
>            Reporter: Karl Grosse
>            Priority: Critical
>             Fix For: 0.9-incubating
>
>         Attachments: JOHNZON-48.patch
>
>
> Complex objects in a list get serialized as json object without using registered converters.
This leads to malformed json strings which can't be deserialized if there is no default constructor
available (as is the case with enums). 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message