johnzon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dirk Rudolph (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (JOHNZON-153) Support streaming String values using Readable
Date Wed, 17 Jan 2018 19:05:03 GMT

    [ https://issues.apache.org/jira/browse/JOHNZON-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16329225#comment-16329225
] 

Dirk Rudolph edited comment on JOHNZON-153 at 1/17/18 7:05 PM:
---------------------------------------------------------------

As I said, I don't use json bind and even with the  [JsonbSerializer|https://javaee.github.io/javaee-spec/javadocs/javax/json/bind/serializer/JsonbSerializer.html]
I would only be able to again, write a String as value to the generator. 

For my perspective it would be possible to implement JsonString returning a Readable backed
CharSequence for getChars() and working with getChars() instead of getString() in JsonGeneratorImpl.
That would at least not violate the interface documentation. 


was (Author: diru):
As I said, I don't use json bind and even with the  [JsonbSerializer|https://javaee.github.io/javaee-spec/javadocs/javax/json/bind/serializer/JsonbSerializer.html]
I would only be able to again, write a String a value to the generator. 

For my perspective it would be possible to implement JsonString returning a Readable backed
CharSequence for getChars() and working with getChars() instead of getString() in JsonGeneratorImpl.
That would at least not violate the interface documentation. 

> Support streaming String values using Readable
> ----------------------------------------------
>
>                 Key: JOHNZON-153
>                 URL: https://issues.apache.org/jira/browse/JOHNZON-153
>             Project: Johnzon
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Dirk Rudolph
>            Priority: Major
>
> Currently there are 2 ways writing a String value to JsonGenerator:
>  # using {{JsonGenerator#write(java.lang.String, javax.json.JsonValue)}} and {{JsonGenerator#write(javax.json.JsonValue)}}
respectively or
>  # using {{JsonGenerator#write(java.lang.String, java.lang.String)}} and {{JsonGenerator#write(java.lang.String)}}
respectively
> where in the former case {{JsonValue}} has to be a {{JsonString}} otherwise a ClassCastException
will be thrown in [JsonGeneratorImpl#writeJsonValue(java.lang.String, javax.json.JsonValue)|https://github.com/apache/johnzon/blob/master/johnzon-core/src/main/java/org/apache/johnzon/core/JsonGeneratorImpl.java#L203].
> It would be great to change that implementation detail so that a consumer can implement
its own implementation of {{JsonValue}} with {{ValueType#STRING}} but working with {{Reader}}
internally so that not the entire String is kept in memory. 
> The use case behind that I use johonzon to write a solr-json formatted list of update
commands for solr and want to use tika to parse (potentially huge) files into plain text
sending them as individual field in my json object. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message