johnzon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [johnzon] mkarg commented on issue #44: Fix for [JOHNZON-276]: StackOverflowError
Date Wed, 18 Sep 2019 09:53:42 GMT
mkarg commented on issue #44: Fix for [JOHNZON-276]: StackOverflowError
URL: https://github.com/apache/johnzon/pull/44#issuecomment-532612164
 
 
   I don't see why you mention subclassing, as the current `this ==` clearly is unable to
deal with subclassing *already*. So you reject my code for something that the original code
already fails with?
   
   Anyways, as I wrote above I had to _explicitly_ refer to this strategy using `@JsonVisibility`
on a POJO to work around *another* bug of Johnzon:
   ```java
   @JsonVisibility(DefaultPropertyVisibilityStrategy.class)
   public final class C
   {
      @JsonProperty private boolean foo;
   
      public final boolean isFoo() { return foo; }
   }
   ```
   *Without* `@JsonVisibility` the POJO's field `foo` is **never** written on JSON parsing
but stays `false` forever. Making it `public` would work around that, but is not intended.
I *want* to keep it `private` as it shall be immutable by Java code, while JSON-B *still shall*
modify it.
   
   I debugged this, and noticed that Johnzon actually knows that it *wants* to use the getter
method + the field writer as accessors, but actually just doesn't invoke the field writer
when it comes to parsing JSON. Had no time to debug it deeper, that's why I didn't report
*that* first.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message