johnzon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [johnzon] rmannibucau commented on issue #44: Fix for [JOHNZON-276]: StackOverflowError
Date Wed, 18 Sep 2019 12:26:59 GMT
rmannibucau commented on issue #44: Fix for [JOHNZON-276]: StackOverflowError
URL: https://github.com/apache/johnzon/pull/44#issuecomment-532661056
 
 
   @mkarg isAssignableFrom is the same as instanceof, it still ignores the subclassing we
could use later on internally. The fact instanceof is true for subclass is what makes it not
working, it bypass the subclass impl instead of delegating to it, was my point. Can you review
the following test which describe both the inheritance and case you try to achieve which works:
https://github.com/apache/johnzon/blob/master/johnzon-jsonb/src/test/java/org/apache/johnzon/jsonb/DefaultPropertyVisibilityStrategyTest.java#L33
?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message