johnzon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Markus Karg (Jira)" <j...@apache.org>
Subject [jira] [Reopened] (JOHNZON-272) Fails to build Johnzon :: Maven Plugin
Date Tue, 24 Sep 2019 06:50:00 GMT

     [ https://issues.apache.org/jira/browse/JOHNZON-272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Markus Karg reopened JOHNZON-272:
---------------------------------

I need to reopen this issue, as the implemented solution is wrong. While it actually makes
the test pass, it incorrectly changes the expected outcome of the Maven Plugin. In fact, the
actual cause of the bug was not an incorrect expectation, but an incorrect outcome: When running
on Windows, the expected outcome that SampleValue.java has CR LF line ending, but actually
it has LF line ending (just like Linux). This is simply wrong on Windows, because all native
Windows editors will expect the missing CR, so opening SampleValue.java with those (e. g.
NOTEPAD.exe) shows all source code in one single line! The fix instead has to be that the
output respects System.lineSeparator() (see [https://docs.oracle.com/javase/7/docs/api/java/lang/System.html#lineSeparator]).

> Fails to build Johnzon :: Maven Plugin
> --------------------------------------
>
>                 Key: JOHNZON-272
>                 URL: https://issues.apache.org/jira/browse/JOHNZON-272
>             Project: Johnzon
>          Issue Type: Bug
>    Affects Versions: 1.2.0
>         Environment: {{$ mvn -version}}
> {{Apache Maven 3.6.1 }}(d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; 2019-04-04T21:00:29+02:00)
> {{Maven home: C:\Program Files\apache-maven-3.6.1}}
> {{Java version: 1.8.0_181, vendor: Azul Systems, Inc., runtime: C:\Program Files\zulu8.31.0.1-jdk8.0.181-win_x64\jre}}
> {{Default locale: de_DE, platform encoding: Cp1252}}
> {{OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows"}}
>            Reporter: Markus Karg
>            Priority: Blocker
>             Fix For: 1.2.1
>
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> {{$ git clone https://github.com/apache/johnzon.git}}
> {{$ cd johnzon}}
>  
> {{$mvn clean install}}
> {{...}}
> {{[INFO] Running org.apache.johnzon.maven.plugin.ExampleToModelMojoTest}}
> {{[ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.172 s <<<
FAILURE! - in org.apache.johnzon.maven.plugin.ExampleToModelMojoTest}}
> {{[ERROR] generate(org.apache.johnzon.maven.plugin.ExampleToModelMojoTest) Time elapsed:
0.125 s <<< FAILURE!}}
> {{org.junit.ComparisonFailure:}}
> {{expected:</*[}}
> {{ * Licensed to the Apache Software Foundation (ASF) under one}}
> {{...}}
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message