johnzon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Romain Manni-Bucau (Jira)" <j...@apache.org>
Subject [jira] [Commented] (JOHNZON-319) Properties regarding Json reader/generator ignored if no JsonProvider is set
Date Sun, 19 Jul 2020 04:47:00 GMT

    [ https://issues.apache.org/jira/browse/JOHNZON-319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160580#comment-17160580
] 

Romain Manni-Bucau commented on JOHNZON-319:
--------------------------------------------

Hi Markus,

Think there is no setter for that so it does not have to be set but it sounds doable. Case
it must not be done is whzn an instance is peovided (indeed).

In terms of consistency we tend to alias properties in the builder so we can maybe extend
that pattern to avoid error/logs when jsonp is not johnzon (we must not bind any properties
by default if specific).

 

Wdyt?

 

 

> Properties regarding Json reader/generator ignored if no JsonProvider is set
> ----------------------------------------------------------------------------
>
>                 Key: JOHNZON-319
>                 URL: https://issues.apache.org/jira/browse/JOHNZON-319
>             Project: Johnzon
>          Issue Type: Bug
>          Components: JSON-B
>    Affects Versions: 1.2.8
>            Reporter: Markus Jung
>            Priority: Minor
>         Attachments: ignored-property.zip
>
>
> JohnzonBuilder ignores properties which shouid affect the Json reader/generator if no
JsonProvider has been set. I noticed this using the "org.apache.johnzon.max-string-length"
property.
> JohnzonBuilder#build() looks somewhat like this behaviour is intended, but a property
just being ignored feels unintuitive. I'd be sending you a PR for this, but I dont know this
project well enough to decide whether or not always initializing the generator/reader factories
to ensure set properties are being respected is a good idea. Maybe somebody could hint me
in the right direction there?
> I attached an example project that demonstrates this issue, the first call to Jsonb#fromJson(String,
Class) should already be throwing a JsonParsingException.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message