From dev-return-550-apmail-karaf-dev-archive=karaf.apache.org@karaf.apache.org Fri Nov 26 20:30:03 2010
Return-Path: <dev-return-550-apmail-karaf-dev-archive=karaf.apache.org@karaf.apache.org>
Delivered-To: apmail-karaf-dev-archive@minotaur.apache.org
Received: (qmail 28112 invoked from network); 26 Nov 2010 20:30:02 -0000
Received: from unknown (HELO mail.apache.org) (140.211.11.3)
  by 140.211.11.9 with SMTP; 26 Nov 2010 20:30:02 -0000
Received: (qmail 3172 invoked by uid 500); 26 Nov 2010 20:30:02 -0000
Delivered-To: apmail-karaf-dev-archive@karaf.apache.org
Received: (qmail 3148 invoked by uid 500); 26 Nov 2010 20:30:02 -0000
Mailing-List: contact dev-help@karaf.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@karaf.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@karaf.apache.org>
List-Post: <mailto:dev@karaf.apache.org>
List-Id: <dev.karaf.apache.org>
Reply-To: dev@karaf.apache.org
Delivered-To: mailing list dev@karaf.apache.org
Received: (qmail 3140 invoked by uid 99); 26 Nov 2010 20:30:02 -0000
Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 26 Nov 2010 20:30:02 +0000
X-ASF-Spam-Status: No, hits=0.0 required=10.0
	tests=FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS,T_TO_NO_BRKTS_FREEMAIL
X-Spam-Check-By: apache.org
Received-SPF: pass (nike.apache.org: domain of gnodet@gmail.com designates 74.125.82.42 as permitted sender)
Received: from [74.125.82.42] (HELO mail-ww0-f42.google.com) (74.125.82.42)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 26 Nov 2010 20:29:54 +0000
Received: by wwb39 with SMTP id 39so18647wwb.3
        for <dev@karaf.apache.org>; Fri, 26 Nov 2010 12:29:34 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=gamma;
        h=domainkey-signature:mime-version:received:received:in-reply-to
         :references:date:message-id:subject:from:to:content-type
         :content-transfer-encoding;
        bh=b2pk8fy2RxumIceFGpT7U98OgjaB3Xr5DL7itYzdh4c=;
        b=pz5oX3ylibxZsH+gHEK1w1/MuNZlheZOVtU4SpBPF6cFwHXwShFouSKtvS749a5loh
         ed4hrJggUI5m3dLgiosVBtYc7Qcr6vPGYHoCEP4hn2acju77xaiz+gK/HTnFP6HfLTzt
         mRqkv+/jdWcJm0xNq7iqy4ZlB41FiyFs62JoU=
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type:content-transfer-encoding;
        b=WLcvHdPstz3yFmu+eSOHhHne0aci8tdiLH2hEj2N7HDVqGIA4tddgBE6PVF5c9kb6e
         hi5PFYcFGtpfvxu86IX8oI9pfFuObE90+jdQWoCqBknDOL4dmfjCVEk+g/qj8+wggYlT
         +23++Z8kehyPvegJpzPtLJ5NtvMEzXjIsqA+E=
MIME-Version: 1.0
Received: by 10.227.154.7 with SMTP id m7mr2852744wbw.211.1290803374227; Fri,
 26 Nov 2010 12:29:34 -0800 (PST)
Received: by 10.227.132.139 with HTTP; Fri, 26 Nov 2010 12:29:34 -0800 (PST)
In-Reply-To: <20101126202126.071EB238888A@eris.apache.org>
References: <20101126202126.071EB238888A@eris.apache.org>
Date: Fri, 26 Nov 2010 21:29:34 +0100
Message-ID: <AANLkTi=yv_UuWNa4-czHGUbVH0qqVm476eXk4Nc-C-gF@mail.gmail.com>
Subject: Re: svn commit: r1039550 - in /karaf/trunk/features: enterprise/
 enterprise/pom.xml enterprise/src/ enterprise/src/main/ enterprise/src/main/resources/
 enterprise/src/main/resources/features.xml pom.xml
From: Guillaume Nodet <gnodet@gmail.com>
To: dev@karaf.apache.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-Virus-Checked: Checked by ClamAV on apache.org

On Fri, Nov 26, 2010 at 21:21,  <iocanel@apache.org> wrote:
> Author: iocanel
> Date: Fri Nov 26 20:21:25 2010
> New Revision: 1039550
>
> URL: http://svn.apache.org/viewvc?rev=3D1039550&view=3Drev
> Log:
> [KARAF-293] Created a project that hosts the karaf enterprise features
>
> Added:
> =A0 =A0karaf/trunk/features/enterprise/
> =A0 =A0karaf/trunk/features/enterprise/pom.xml
> =A0 =A0karaf/trunk/features/enterprise/src/
> =A0 =A0karaf/trunk/features/enterprise/src/main/
> =A0 =A0karaf/trunk/features/enterprise/src/main/resources/
> =A0 =A0karaf/trunk/features/enterprise/src/main/resources/features.xml
> Modified:
> =A0 =A0karaf/trunk/features/pom.xml
>
> Added: karaf/trunk/features/enterprise/pom.xml
> URL: http://svn.apache.org/viewvc/karaf/trunk/features/enterprise/pom.xml=
?rev=3D1039550&view=3Dauto
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- karaf/trunk/features/enterprise/pom.xml (added)
> +++ karaf/trunk/features/enterprise/pom.xml Fri Nov 26 20:21:25 2010
> @@ -0,0 +1,85 @@
> +<?xml version=3D"1.0" encoding=3D"UTF-8"?>
> +<project xmlns=3D"http://maven.apache.org/POM/4.0.0"
> + =A0 =A0 =A0 =A0 xmlns:xsi=3D"http://www.w3.org/2001/XMLSchema-instance"
> + =A0 =A0 =A0 =A0 xsi:schemaLocation=3D"http://maven.apache.org/POM/4.0.0=
 http://maven.apache.org/xsd/maven-4.0.0.xsd">
> + =A0 =A0<!--
> +
> + =A0 =A0 =A0 =A0Licensed to the Apache Software Foundation (ASF) under o=
ne or more
> + =A0 =A0 =A0 =A0contributor license agreements. =A0See the NOTICE file d=
istributed with
> + =A0 =A0 =A0 =A0this work for additional information regarding copyright=
 ownership.
> + =A0 =A0 =A0 =A0The ASF licenses this file to You under the Apache Licen=
se, Version 2.0
> + =A0 =A0 =A0 =A0(the "License"); you may not use this file except in com=
pliance with
> + =A0 =A0 =A0 =A0the License. =A0You may obtain a copy of the License at
> +
> + =A0 =A0 =A0 =A0 =A0 http://www.apache.org/licenses/LICENSE-2.0
> +
> + =A0 =A0 =A0 =A0Unless required by applicable law or agreed to in writin=
g, software
> + =A0 =A0 =A0 =A0distributed under the License is distributed on an "AS I=
S" BASIS,
> + =A0 =A0 =A0 =A0WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either exp=
ress or implied.
> + =A0 =A0 =A0 =A0See the License for the specific language governing perm=
issions and
> + =A0 =A0 =A0 =A0limitations under the License.
> + =A0 =A0-->
> +
> + =A0 =A0<modelVersion>4.0.0</modelVersion>
> +
> + =A0 =A0<parent>
> + =A0 =A0 =A0 =A0<groupId>org.apache.karaf.features</groupId>
> + =A0 =A0 =A0 =A0<artifactId>features</artifactId>
> + =A0 =A0 =A0 =A0<version>2.1.99-SNAPSHOT</version>
> + =A0 =A0</parent>
> +
> + =A0 =A0<artifactId>enterprise</artifactId>
> + =A0 =A0<name>Apache Karaf :: Features :: Enterprise</name>
> +
> + =A0 =A0<properties>
> + =A0 =A0 =A0 =A0 <features.file>features.xml</features.file>
> + =A0 =A0 =A0 =A0<cglib.version>2.1_3_6</cglib.version>
> + =A0 =A0 =A0 =A0<geronimo.transaction.version>1.1.1</geronimo.transactio=
n.version>
> + =A0 =A0 =A0 =A0<geronimo.persistence.version>1.1</geronimo.persistence.=
version>
> + =A0 =A0</properties>

I think the maintenance would be easier if all versions are defined in
the root pom.  It avoid looking in various poms when someone wants to
update a given version.

> +
> + =A0 =A0<build>
> + =A0 =A0 =A0 =A0<resources>
> + =A0 =A0 =A0 =A0 =A0 =A0<resource>
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0<directory>src/main/resources</directory=
>
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0<filtering>true</filtering>
> + =A0 =A0 =A0 =A0 =A0 =A0</resource>
> + =A0 =A0 =A0 =A0</resources>
> +
> + =A0 =A0 =A0 =A0<plugins>
> + =A0 =A0 =A0 =A0 =A0 =A0<plugin>
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0<groupId>org.apache.maven.plugins</group=
Id>
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0<artifactId>maven-resources-plugin</arti=
factId>
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0<version>2.4.3</version>
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0<executions>
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0<execution>
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0<id>filter</id>
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0<phase>process-resources=
</phase>
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0</execution>
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0</executions>
> + =A0 =A0 =A0 =A0 =A0 =A0</plugin>
> + =A0 =A0 =A0 =A0 =A0 =A0<plugin>
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0<groupId>org.codehaus.mojo</groupId>
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0<artifactId>build-helper-maven-plugin</a=
rtifactId>
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0<executions>
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0<execution>
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0<id>attach-artifacts</id=
>
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0<phase>package</phase>
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0<goals>
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0<goal>attach-art=
ifact</goal>
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0</goals>
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0<configuration>
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0<artifacts>
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0<artifac=
t>
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0=
<file>target/classes/${features.file}</file>
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0=
<type>xml</type>
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0=
<classifier>features</classifier>
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0</artifa=
ct>
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0</artifacts>
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0</configuration>
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0</execution>
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0</executions>
> + =A0 =A0 =A0 =A0 =A0 =A0</plugin>
> + =A0 =A0 =A0 =A0</plugins>
> + =A0 =A0</build>
> +</project>
> \ No newline at end of file
>
> Added: karaf/trunk/features/enterprise/src/main/resources/features.xml
> URL: http://svn.apache.org/viewvc/karaf/trunk/features/enterprise/src/mai=
n/resources/features.xml?rev=3D1039550&view=3Dauto
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- karaf/trunk/features/enterprise/src/main/resources/features.xml (adde=
d)
> +++ karaf/trunk/features/enterprise/src/main/resources/features.xml Fri N=
ov 26 20:21:25 2010
> @@ -0,0 +1,44 @@
> +<?xml version=3D"1.0" encoding=3D"UTF-8"?>
> +
> + =A0 =A0<!--
> +
> + =A0 =A0 =A0 =A0Licensed to the Apache Software Foundation (ASF) under o=
ne or more
> + =A0 =A0 =A0 =A0contributor license agreements. =A0See the NOTICE file d=
istributed with
> + =A0 =A0 =A0 =A0this work for additional information regarding copyright=
 ownership.
> + =A0 =A0 =A0 =A0The ASF licenses this file to You under the Apache Licen=
se, Version 2.0
> + =A0 =A0 =A0 =A0(the "License"); you may not use this file except in com=
pliance with
> + =A0 =A0 =A0 =A0the License. =A0You may obtain a copy of the License at
> +
> + =A0 =A0 =A0 =A0 =A0 http://www.apache.org/licenses/LICENSE-2.0
> +
> + =A0 =A0 =A0 =A0Unless required by applicable law or agreed to in writin=
g, software
> + =A0 =A0 =A0 =A0distributed under the License is distributed on an "AS I=
S" BASIS,
> + =A0 =A0 =A0 =A0WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either exp=
ress or implied.
> + =A0 =A0 =A0 =A0See the License for the specific language governing perm=
issions and
> + =A0 =A0 =A0 =A0limitations under the License.
> + =A0 =A0-->
> +
> +<fetures>
> + =A0 =A0 =A0 =A0<feature name=3D'transaction' description=3D"OSGi Transa=
ction Manager" version=3D'${aries.blueprint.version}'>
> + =A0 =A0 =A0 =A0 =A0 =A0<details>The Aries JTA</details>
> + =A0 =A0 =A0 =A0 =A0 =A0<bundle>mvn:org.apache.geronimo.specs/geronimo-j=
ta_1.1_spec/${geronimo.transaction.version}</bundle>
> + =A0 =A0 =A0 =A0 =A0 =A0<bundle>mvn:org.apache.aries.transaction/org.apa=
che.aries.transaction.blueprint/${aries.blueprint.version}</bundle>
> + =A0 =A0 =A0 =A0 =A0 =A0<bundle>mvn:org.apache.aries.transaction/org.apa=
che.aries.transaction.manager/${aries.blueprint.version}</bundle>
> + =A0 =A0 =A0 =A0</feature>
> +
> + =A0 =A0 =A0 <feature name=3D'persistence' description=3D"OSGi Persisten=
ce Container" version=3D'${aries.blueprint.version}'>
> + =A0 =A0 =A0 =A0 =A0 =A0<bundle>mvn:org.apache.geronimo.specs/geronimo-j=
ta_1.1_spec/${geronimo.transaction.version}</bundle>
> + =A0 =A0 =A0 =A0 =A0 =A0<bundle>mvn:org.apache.geronimo.specs/geronimo-j=
pa_2.0_spec/${geronimo.transaction.version}</bundle>
> + =A0 =A0 =A0 =A0 =A0 =A0<bundle>mvn:org.apache.aries.jpa/org.apache.arie=
s.jpa.blueprint.aries/${aries.blueprint.version}</bundle>
> + =A0 =A0 =A0 =A0 =A0 =A0<bundle>mvn:org.apache.aries.jpa/org.apache.arie=
s.jpa.container/${aries.blueprint.version}</bundle>
> + =A0 =A0 =A0 =A0 =A0 =A0<bundle>mvn:org.apache.aries.jpa/org.apache.arie=
s.jpa.container.context/${aries.blueprint.version}</bundle>
> + =A0 =A0 =A0 =A0 =A0 =A0<bundle>mvn:org.apache.aries/org.apache.aries.ut=
il/${aries.blueprint.version}</bundle>
> + =A0 =A0 =A0 =A0</feature>
> +
> + =A0 =A0 =A0 =A0<feature name=3D'jndi' description=3D"OSGi Service Regis=
try JNDI access" version=3D'${aries.blueprint.version}'>
> + =A0 =A0 =A0 =A0 =A0 =A0<bundle>mvn:org.osgi/org.osgi.enterprise/${osgi.=
version}</bundle>
> + =A0 =A0 =A0 =A0 =A0 =A0<bundle>mvn:org.apache.servicemix.bundles/org.ap=
ache.servicemix.bundles.cglib/${cglib.version}</bundle>
> + =A0 =A0 =A0 =A0 =A0 =A0<bundle>mvn:org.apache.aries.jndi/org.apache.ari=
es.jndi.core/${aries.blueprint.version}</bundle>
> + =A0 =A0 =A0 =A0 =A0 =A0<bundle>mvn:org.apache.aries.jndi/org.apache.ari=
es.jndi.url/${aries.blueprint.version}</bundle>
> + =A0 =A0 =A0 =A0</feature>
> +</fetures>


Apart from the typo on the root element, I think it would be nice if
those features could leverage the obr repository when installed.
I.e. add repository=3D"(obr)" on the feature elements and put a
dependency=3D"true" on bundles which are not part of the core feature
(i.e. they are installed because you need those to provide some third
party package.
Last, installing the org.osgi/org.osgi.enterprise is imho a bad idea
and it's too big and could break modularity.  Aries usually provide a
bundle with the api and also one which contain both the implementation
and the api...

> \ No newline at end of file
>
> Modified: karaf/trunk/features/pom.xml
> URL: http://svn.apache.org/viewvc/karaf/trunk/features/pom.xml?rev=3D1039=
550&r1=3D1039549&r2=3D1039550&view=3Ddiff
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- karaf/trunk/features/pom.xml (original)
> +++ karaf/trunk/features/pom.xml Fri Nov 26 20:21:25 2010
> @@ -37,6 +37,7 @@
> =A0 =A0 =A0 =A0 <module>command</module>
> =A0 =A0 =A0 =A0 <module>management</module>
> =A0 =A0 =A0 =A0 <module>obr</module>
> + =A0 =A0 =A0 =A0<module>enterprise</module>
> =A0 =A0 </modules>
>
> =A0</project>
>
>
>



--=20
Cheers,
Guillaume Nodet
------------------------
Blog: http://gnodet.blogspot.com/
------------------------
Open Source SOA
http://fusesource.com