karaf-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Freeman Fang <freeman.f...@gmail.com>
Subject Re: svn commit: r1139160 - in /karaf/branches/karaf-2.2.x/assemblies: apache-karaf/src/main/descriptors/unix-bin.xml apache-karaf/src/main/descriptors/windows-bin.xml features/standard/src/main/resources/features.xml
Date Fri, 24 Jun 2011 07:06:34 GMT
yep, the idea is that configfile should be able to check if  
"finalname" file exist, if it exist, the don't download it anyway.


Best Regards
Freeman
On 2011-6-24, at 下午2:56, Andreas Pieber wrote:

> In this case it would be even easier for you if Karaf does not ship
> with a default http, but configfile does not auto-download it if it is
> found, isn't it?
>
> Kind regards,
> Andreas
>
> On Fri, Jun 24, 2011 at 8:52 AM, Freeman Fang  
> <freeman.fang@gmail.com> wrote:
>> Hi Andreas,
>>
>> Sounds good to me, I will refactor configfile later on.
>>
>> And some download stream project(Servicemix :-)) install http  
>> feature by
>> default, but it's another story, I can ship jetty.xml with  
>> servicemix etc
>> folder from servicemix side.
>>
>> Best Regards
>> Freeman
>> On 2011-6-24, at 下午2:24, Andreas Pieber wrote:
>>
>>> Hey Freeman,
>>>
>>>> Modified:
>>>> karaf/branches/karaf-2.2.x/assemblies/features/standard/src/main/ 
>>>> resources/features.xml
>>>> URL:
>>>> http://svn.apache.org/viewvc/karaf/branches/karaf-2.2.x/assemblies/features/standard/src/main/resources/features.xml?rev=1139160&r1=1139159&r2=1139160&view=diff
>>>>
>>>> = 
>>>> = 
>>>> = 
>>>> = 
>>>> = 
>>>> = 
>>>> = 
>>>> = 
>>>> = 
>>>> = 
>>>> = 
>>>> ===================================================================
>>>> ---
>>>> karaf/branches/karaf-2.2.x/assemblies/features/standard/src/main/ 
>>>> resources/features.xml
>>>> (original)
>>>> +++
>>>> karaf/branches/karaf-2.2.x/assemblies/features/standard/src/main/ 
>>>> resources/features.xml
>>>> Fri Jun 24 06:06:45 2011
>>>> @@ -122,8 +122,7 @@
>>>>        <bundle>mvn:org.eclipse.jetty/jetty-plus/${jetty.version}</

>>>> bundle>
>>>>    </feature>
>>>>    <feature name="http" version="${project.version}"  
>>>> resolver="(obr)">
>>>> -       <configfile
>>>> finalname="/etc/jetty.xml">mvn:org.apache.karaf/apache-karaf/$ 
>>>> {project.version}/xml/jettyconfig</configfile>
>>>
>>> I'm not sure if this is the way to go. Since we do not ship the http
>>> feature with the kit (but also download it) I'm not really sure if  
>>> we
>>> should ship the jetty.xml. Though, I'm with you that it should not
>>> overwrite an existing one. I would rather propose to change the
>>> configfile logic in karaf to not overwrite existing files?
>>>
>>> WDYT?
>>>
>>> Kind regards,
>>> Andreas
>>>
>>>> -               <config name="org.ops4j.pax.web">
>>>> +        <config name="org.ops4j.pax.web">
>>>>            org.osgi.service.http.port=8181
>>>>            javax.servlet.context.tempdir=${karaf.data}/pax-web-jsp
>>>>            org.ops4j.pax.web.config.file=${karaf.base}/etc/ 
>>>> jetty.xml
>>>>
>>>>
>>>>
>>
>> ---------------------------------------------
>> Freeman Fang
>>
>> FuseSource
>> Email:ffang@fusesource.com
>> Web: fusesource.com
>> Twitter: freemanfang
>> Blog: http://freemanfang.blogspot.com
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>

---------------------------------------------
Freeman Fang

FuseSource
Email:ffang@fusesource.com
Web: fusesource.com
Twitter: freemanfang
Blog: http://freemanfang.blogspot.com










Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message