karaf-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Glen Mazza <glen.ma...@gmail.com>
Subject Hmm. (Re: commit: r1174535)
Date Fri, 23 Sep 2011 12:07:09 GMT
Added: 
karaf/trunk/management/mbeans/http/src/main/java/org/apache/karaf/management/mbeans/http/internal/HttpMBeanImpl.java
> URL: http://svn.apache.org/viewvc/karaf/trunk/management/mbeans/http/src/main/java/org/apache/karaf/management/mbeans/http/internal/HttpMBeanImpl.java?rev=1174535&view=auto
> ==============================================================================
> --- karaf/trunk/management/mbeans/http/src/main/java/org/apache/karaf/management/mbeans/http/internal/HttpMBeanImpl.java
(added)
> +++ karaf/trunk/management/mbeans/http/src/main/java/org/apache/karaf/management/mbeans/http/internal/HttpMBeanImpl.java
Fri Sep 23 06:07:32 2011
> @@ -0,0 +1,101 @@
> +/*
> +	private String getStateString(int type) {
> +        switch(type) {
> +		case WebEvent.DEPLOYING:
> +			return "Deploying  ";
> +		case WebEvent.DEPLOYED:
> +			return "Deployed   ";
> +		case WebEvent.UNDEPLOYING:
> +			return "Undeploying";
> +		case WebEvent.UNDEPLOYED:
> +			return "Undeployed ";
> +		case WebEvent.FAILED:
> +			return "Failed     ";
> +		case WebEvent.WAITING:
> +			return "Waiting    ";
> +		default:
> +			return "Failed     ";
> +		}

JB, are you sure you want to have the same "default" value as you have 
for another case (WebEvent.FAILED)?  Might you want to make it a 
different value ("Unknown", for example, or  "Invalid" or "Error" if the 
"default" case should never be occurring?)

Reason: if someone on the mailing list complains that the state is 
"Failed" and they want to know why, it's harder to trace the code 
because you don't know if the case is WebEvent.FAILED or default 
(something else), because they both give the same text string.  Whereas 
if the values are different you'll know if the WebEvent actually did 
fail, or somewhere else in the code, the type value wasn't being 
properly set and hence the code was improperly falling into the 
"default" category.

Glen

-- 
Glen Mazza
Talend - http://www.talend.com/ai
Blog - http://www.jroller.com/gmazza
Twitter - glenmazza


Mime
View raw message