karaf-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guillaume Nodet <gno...@gmail.com>
Subject Re: Misspelled class (Re: commit: r1175877)
Date Tue, 27 Sep 2011 13:24:49 GMT
Registrar sounds good to me.
However, this is a breaking change, so maybe we want to have the old class
inherit the new one and be deprecated for some time.

2011/9/27 Glen Mazza <glen.mazza@gmail.com>

> Googling is giving examples both of MBeanRegistrar and MBeanRegistration if
> this particular class isn't really fitting the role of an MBeanRegistry.
>  I've seen the term Registrar before, at the university I went to (and
> perhaps most others, I don't know), it referred to the office where you pay
> your tuition, but it has several other/older shades of meaning that might
> make it a good fit here.  If it's a pure util class, maybe MBeanRegisterUtil
> or similar.
>
> Glen
>
>
> On 09/27/2011 03:49 AM, Jean-Baptiste Onofré wrote:
>
>> Hi Lukasz
>>
>> the name should be Register or Registrar, not Registrer (it doesn't exist
>> in English ;)).
>>
>> Regards
>> JB
>>
>> On 09/27/2011 09:46 AM, Łukasz Dywicki wrote:
>>
>>> Hi,
>>> I am not sure about name change. This is utility class which doesn't
>>> contain any 'registry' logic. It simply allows users to register mbeans.
>>> http://www.merriam-webster.**com/dictionary/register<http://www.merriam-webster.com/dictionary/register>
>>>
>>> Regards,
>>> Lukasz
>>>
>>>
>>>  Hi Glen,
>>>>
>>>> you are right, I noticed it too.
>>>>
>>>> I plan to do the change on the trunk (Karaf 3.0) as users may use the
>>>> current "bad" naming.
>>>>
>>>> Regards
>>>> JB
>>>>
>>>> On 09/26/2011 07:40 PM, Glen Mazza wrote:
>>>>
>>>>> On 09/26/2011 10:04 AM, jbonofre@apache.org wrote:
>>>>>
>>>>>> +<!-- Register Dev MBean in the MBean Server -->
>>>>>> +<bean id="mbeanRegistrer"
>>>>>> class="org.apache.karaf.**management.MBeanRegistrer">
>>>>>>
>>>>>
>>>>> JB, the classname should be "MBeanRegistry" (I think). Registrer is not
>>>>> a word in English.
>>>>>
>>>>> http://docs.jboss.org/jbossas/**javadoc/3.2.7/jmx/org/jboss/**
>>>>> mx/server/registry/**MBeanRegistry.html<http://docs.jboss.org/jbossas/javadoc/3.2.7/jmx/org/jboss/mx/server/registry/MBeanRegistry.html>
>>>>>
>>>>>
>>>>> Glen
>>>>>
>>>>>
>>>> --
>>>> Jean-Baptiste Onofré
>>>> jbonofre@apache.org
>>>> http://blog.nanthrax.net
>>>> Talend - http://www.talend.com
>>>>
>>>
>>>
>>>
>>
>
> --
> Glen Mazza
> Talend - http://www.talend.com/ai
> Blog - http://www.jroller.com/gmazza
> Twitter - glenmazza
>
>


-- 
------------------------
Guillaume Nodet
------------------------
Blog: http://gnodet.blogspot.com/
------------------------
Open Source SOA
http://fusesource.com

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message