karaf-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Claus Ibsen <claus.ib...@gmail.com>
Subject Re: [CONF] Apache Karaf > 2010-09-10 Inline jline and jansi into console project
Date Tue, 07 Feb 2012 12:42:03 GMT
On Tue, Feb 7, 2012 at 1:22 PM, Guillaume Nodet <gnodet@gmail.com> wrote:
> Christian,
> I think you misunderstood me.  I don't care either way myself and that
> was actually not this way at first.  I did that because that was a
> request from downstream users.  Projects such as ActiveMQ use the
> shell console jar outside of OSGi and it makes their life easier.
> If we were in a perfect osgi world, each jar would expose its api and
> hide its implementation.  Unfortunately, that's not the way it works,
> and we need to make trade-off  for technical reasons.
> Anyway, one thing which would be more interesting Imho would be to
> split the console from the namespace handler.  One reason is that the
> namespace handler is needed for other commands to be registered, but
> some users have asked that the console is actually started as late as
> possible (using bundle start level).  Given the two are in the same
> bundle, that's not possible right now.

Starting the console later would be a great improvement. Today if you
are a bit to fast,
you can weird errors if you start firing commands and whatnot during startup.

Also its confusing that some bundles may print to the console when
they are ready.
So while you are active in the console, then 5-10 sec later that
bundle prints something,
while you are typing a command :)

> One possible way to solve those two problems would be:
>  1./ split the namespace handler from the console
>  2./ ask the activemq guys what they think about the single jar problem
>  3./ if they really need it, provide a second packaging bundle which
> would include the two splitted bundles + jansi / jline
> Also, if I may suggest, if you have some free time, maybe you could
> check with Jean-Baptiste who is trying to stabilize the trunk for an
> eventual release ...
> On Tue, Feb 7, 2012 at 11:10,  <confluence@apache.org> wrote:
>> 2010-09-10 Inline jline and jansi into console project
>> Page added by Christian Schneider
>> The Karaf console project inlines all classes from jline and jansi to
>> provide a single jar that can be used easily outside Karaf.
>> Pros
>> For standalone usage the console jar can be called using java -jar
>> Cons
>> Inlining other projects breaks the module concept where each module tries to
>> keep as many things private as possible
>> Ties console to one specific version of jline and jansi
>> The standalone jar could also be built individually. So in OSGi the jars
>> could be separate
>> Who supported this decision
>> Guillaume Nodet
>> *
>> h2 Who was against it
>> Christian Schneider
>> *
>> References
>> https://issues.apache.org/jira/browse/KARAF-1102
>> https://issues.apache.org/jira/browse/KARAF-144
>> Change Notification Preferences
>> View Online | Add Comment
> --
> ------------------------
> Guillaume Nodet
> ------------------------
> Blog: http://gnodet.blogspot.com/
> ------------------------
> FuseSource, Integration everywhere
> http://fusesource.com

Claus Ibsen
Email: cibsen@fusesource.com
Web: http://fusesource.com
Twitter: davsclaus, fusenews
Blog: http://davsclaus.blogspot.com/
Author of Camel in Action: http://www.manning.com/ibsen/

View raw message