karaf-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Christian Schneider <ch...@die-schneider.net>
Subject Re: svn commit: r1304399 - in /karaf/trunk/shell/console/src: main/java/org/apache/karaf/shell/console/table/ main/java/org/apache/karaf/shell/console/table2/ test/java/org/apache/karaf/shell/console/tabletest/
Date Mon, 26 Mar 2012 05:24:08 GMT
Hi Andreas,

no problem with that. The reason is that I wanted to show how the tables 
look with outer lines and without and
ask what we would like to keep. After trying both I prefer the current 
version without outer lines.

Any other preferences?
If no other comments are on this thread I will remove the commented code.

I also thought about making it a configurable property but I dont think 
it is worth it.

Christian

Am 26.03.2012 06:07, schrieb Andreas Pieber:
> Hey,
>
> On Fri, Mar 23, 2012 at 15:58,<cschneider@apache.org>  wrote:
>> Author: cschneider
>> Date: Fri Mar 23 14:58:43 2012
>> New Revision: 1304399
>>
>> URL: http://svn.apache.org/viewvc?rev=1304399&view=rev
>> Log:
>> KARAF-1281 Replacing old table impl
>>
>> </ SKIP>
>>
>> ==============================================================================
>> --- karaf/trunk/shell/console/src/main/java/org/apache/karaf/shell/console/table2/Row.java
(original)
>> +++ karaf/trunk/shell/console/src/main/java/org/apache/karaf/shell/console/table/Row.java
Fri Mar 23 14:58:43 2012
>> @@ -13,7 +13,7 @@
>>   *  See the License for the specific language governing permissions and
>>   *  limitations under the License.
>>   */
>> -package org.apache.karaf.shell.console.table2;
>> +package org.apache.karaf.shell.console.table;
>>
>>   import java.util.ArrayList;
>>   import java.util.Arrays;
>> @@ -54,7 +54,7 @@ public class Row {
>>          if (cols.size() != content.size()) {
>>              throw new RuntimeException("Number of columns and number of content
elements do not match");
>>          }
>> -        st.append("| ");
>> +        //st.append("| ");
>>          for (Col col : cols) {
>>              st.append(col.getContent(content.get(c)));
>>              if (c + 1<  cols.size()) {
>> @@ -62,7 +62,7 @@ public class Row {
>>              }
>>              c++;
>>          }
>> -        st.append(" |");
>> +        //st.append(" |");
>>          return st.toString();
>>      }
> Have I ever said that I don't like commented code? :-) Pls remove it
> completely (we have a SCM for the history) or add a comment why it is
> required to keep the code here in commented form...
>
> Kind regards,
> Andreas


-- 

Christian Schneider
http://www.liquid-reality.de

Open Source Architect
Talend Application Integration Division http://www.talend.com


Mime
View raw message