karaf-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andreas Pieber <anpie...@gmail.com>
Subject Re: svn commit: r1304399 - in /karaf/trunk/shell/console/src: main/java/org/apache/karaf/shell/console/table/ main/java/org/apache/karaf/shell/console/table2/ test/java/org/apache/karaf/shell/console/tabletest/
Date Mon, 26 Mar 2012 04:07:00 GMT
Hey,

On Fri, Mar 23, 2012 at 15:58,  <cschneider@apache.org> wrote:
> Author: cschneider
> Date: Fri Mar 23 14:58:43 2012
> New Revision: 1304399
>
> URL: http://svn.apache.org/viewvc?rev=1304399&view=rev
> Log:
> KARAF-1281 Replacing old table impl
>
> </ SKIP>
>
> ==============================================================================
> --- karaf/trunk/shell/console/src/main/java/org/apache/karaf/shell/console/table2/Row.java
(original)
> +++ karaf/trunk/shell/console/src/main/java/org/apache/karaf/shell/console/table/Row.java
Fri Mar 23 14:58:43 2012
> @@ -13,7 +13,7 @@
>  *  See the License for the specific language governing permissions and
>  *  limitations under the License.
>  */
> -package org.apache.karaf.shell.console.table2;
> +package org.apache.karaf.shell.console.table;
>
>  import java.util.ArrayList;
>  import java.util.Arrays;
> @@ -54,7 +54,7 @@ public class Row {
>         if (cols.size() != content.size()) {
>             throw new RuntimeException("Number of columns and number of content
elements do not match");
>         }
> -        st.append("| ");
> +        //st.append("| ");
>         for (Col col : cols) {
>             st.append(col.getContent(content.get(c)));
>             if (c + 1 < cols.size()) {
> @@ -62,7 +62,7 @@ public class Row {
>             }
>             c++;
>         }
> -        st.append(" |");
> +        //st.append(" |");
>         return st.toString();
>     }

Have I ever said that I don't like commented code? :-) Pls remove it
completely (we have a SCM for the history) or add a comment why it is
required to keep the code here in commented form...

Kind regards,
Andreas

Mime
View raw message