karaf-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Fabian Lange <fabian.la...@codecentric.de>
Subject Re: [VOTE] Apache Karaf 4.0.5 release
Date Sun, 03 Apr 2016 13:49:19 GMT
Hi,
i wouldn't veto the release. it is still an improvement for me.
As you can see 4255 was originally opened by me (could not find it
yesterday). I already worked around this problem one way, now i work around
it another way.
I am not sure what the percentage of custom distributions is, especially
ones leaving out stuff involved in conditionals, but I would rather just
document it with the release.

Of course still looking forward to resolving the resolving issue :)

Because of that I vote

+1 (non-binding)

Fabian

On Sun, Apr 3, 2016 at 12:13 PM, Christian Schneider <
chris@die-schneider.net> wrote:

> I think the issue you see is related to
> https://issues.apache.org/jira/browse/KARAF-4255 .
> It seems karaf needs the conditional bundles when doing the resolve. So I
> am in favour of reverting the change and look into the change above for
> next
> release with the goal of making it work completely.
>
> So I propose to roll back the change and create a new release without it
> for 4.0.5. If JB does not have the time I can take care of that.
>
> Christian
>
> 2016-04-02 22:41 GMT+02:00 Fabian Lange <fabian.lange@codecentric.de>:
>
> > Guess thats it:
> >
> >
> https://github.com/apache/karaf/commit/1b7ddc8e1da0f6d70586c7b76f4992a3f0c64f52
> >
> > i would love to keep the new behaviour, as it doesn't bloat my
> > distribution with stuff i do not need, but the runtime should not
> download
> > it then when running.
> >
> > Fabian
> >
> > On Sat, Apr 2, 2016 at 10:33 PM, Fabian Lange <
> fabian.lange@codecentric.de
> > > wrote:
> >
> >> just checked with 4.0.4
> >> In 4.0.4 the (unnecessary) conditional dependency is packaged into
> system
> >> directory of distribution.
> >> So i would qualify this as regression.
> >>
> >> Fabian
> >>
> >>
> >> On Sat, Apr 2, 2016 at 10:24 PM, Fabian Lange <
> >> fabian.lange@codecentric.de> wrote:
> >>
> >>> Yes, not sure if this is a regression.
> >>>
> >>> I have "jaas" but not "aries-blueprint" still this jar is downloaded:
> >>> <conditional>
> >>>   <condition>aries-blueprint</condition>
> >>>   <bundle start-level="30"
> >>>
> start="true">mvn:org.apache.karaf.jaas.blueprint/org.apache.karaf.jaas.blueprint.config/4.0.5</bundle>
> >>>  </conditional>
> >>>
> >>> i have "scr" but neither "management" nor "webconsole, yet these
> >>> download:
> >>>
> >>>         <conditional>
> >>>             <condition>management</condition>
> >>>             <bundle
> >>>
> start-level="30">mvn:org.apache.karaf.scr/org.apache.karaf.scr.management/4.0.5</bundle>
> >>>         </conditional>
> >>>         <conditional>
> >>>             <condition>webconsole</condition>
> >>>             <bundle
> >>>
> start-level="30">mvn:org.apache.felix/org.apache.felix.inventory/1.0.4</bundle>
> >>>             <bundle
> >>>
> start-level="30">mvn:org.apache.felix/org.apache.felix.webconsole.plugins.ds/2.0.2</bundle>
> >>>         </conditional>
> >>>
> >>> if it is not a regression this should not block the release, but it
> >>> should be fixed.
> >>>
> >>> Fabian
> >>>
> >>>
> >>> On Sat, Apr 2, 2016 at 10:19 PM, Fabian Lange <
> >>> fabian.lange@codecentric.de> wrote:
> >>>
> >>>> Ok, this was with
> >>>>           <ignoreDependencyFlag>true</ignoreDependencyFlag>
> >>>>
> >>>> with
> >>>>           <ignoreDependencyFlag>false</ignoreDependencyFlag>
> >>>>
> >>>> it still is missing some stuff which is downloaded at runtime:
> >>>> [image: Inline image 1]
> >>>>
> >>>> These seem to be conditional plugins, however none of the conditions
> is
> >>>> true :(
> >>>> Fabian
> >>>>
> >>>> On Sat, Apr 2, 2016 at 9:57 PM, Fabian Lange <
> >>>> fabian.lange@codecentric.de> wrote:
> >>>>
> >>>>> Hi,
> >>>>> i am currently trying to get my custom distribution running.
> >>>>> Usually a lot of stuff is put into the system folder, however after
> >>>>> the upgrade a lot of dependencies are downloaded at startup, so
my
> >>>>> distribution was lacking them.
> >>>>>
> >>>>> here is a screenshot of the libs downloaded after start, not part
of
> >>>>> my distribution:
> >>>>> [image: Inline image 1]
> >>>>>
> >>>>> I assume some feature definition is not respected correctly?
> >>>>>
> >>>>> Fabian
> >>>>>
> >>>>>
> >>>>> On Fri, Apr 1, 2016 at 3:23 AM, Jean-Baptiste Onofré <
> jb@nanthrax.net>
> >>>>> wrote:
> >>>>>
> >>>>>> Hi all,
> >>>>>>
> >>>>>> I submit Karaf Container 4.0.5 release to your vote.
> >>>>>>
> >>>>>> Release Note:
> >>>>>>
> >>>>>>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311140&version=12334629
> >>>>>>
> >>>>>> Staging Repository:
> >>>>>>
> >>>>>>
> https://repository.apache.org/content/repositories/orgapachekaraf-1059/
> >>>>>>
> >>>>>> Git tag:
> >>>>>> karaf-4.0.5
> >>>>>>
> >>>>>> Please vote to approve this release:
> >>>>>>
> >>>>>> [ ] +1 Approve the release
> >>>>>> [ ] -1 Don't approve the release (please provide specific comments)
> >>>>>>
> >>>>>> This vote will be open for at least 72 hours.
> >>>>>>
> >>>>>> Thanks,
> >>>>>> Regards
> >>>>>> JB
> >>>>>> --
> >>>>>> Jean-Baptiste Onofré
> >>>>>> jbonofre@apache.org
> >>>>>> http://blog.nanthrax.net
> >>>>>> Talend - http://www.talend.com
> >>>>>>
> >>>>>
> >>>>>
> >>>>
> >>>
> >>
> >
>
>
> --
> --
> Christian Schneider
> http://www.liquid-reality.de
> <
> https://owa.talend.com/owa/redir.aspx?C=3aa4083e0c744ae1ba52bd062c5a7e46&URL=http%3a%2f%2fwww.liquid-reality.de
> >
>
> Open Source Architect
> http://www.talend.com
> <
> https://owa.talend.com/owa/redir.aspx?C=3aa4083e0c744ae1ba52bd062c5a7e46&URL=http%3a%2f%2fwww.talend.com
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message