karaf-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guillaume Nodet <gno...@apache.org>
Subject Re: svn commit: r1754090 - in /aries/trunk/proxy/proxy-impl: ./ src/main/java/org/apache/aries/proxy/impl/ src/main/java/org/apache/aries/proxy/impl/common/ src/main/java/org/apache/aries/proxy/impl/gen/ src/main/java/org/apache/aries/proxy/impl/interfaces...
Date Tue, 26 Jul 2016 14:37:30 GMT
It does,  I've been able to use it in karaf with ASM5/jdk8 to create a
blueprint proxy without any problem.
I think that's because the values are static final int and thus inlined in
the switch case construct.

Guillaume

2016-07-26 14:53 GMT+02:00 Daniel Kulp <dkulp@apache.org>:

> Guillaume,
>
> Does this change still allow running with ASM 5?    The OpCodes class in
> 5.0.3 doesn’t have the V1_9 code.   Thus, I’m not sure if this will work
> when this method is hit when using ASM5.
>
> Dan
>
>
> On Jul 26, 2016, at 5:15 AM, gnodet@apache.org wrote:
>
> ---
> aries/trunk/proxy/proxy-impl/src/main/java/org/apache/aries/proxy/impl/ProxyUtils.java
> (original)
> +++
> aries/trunk/proxy/proxy-impl/src/main/java/org/apache/aries/proxy/impl/ProxyUtils.java
> Tue Jul 26 09:15:13 2016
> @@ -39,6 +39,10 @@ public class ProxyUtils
>      //In order to avoid an inconsistent stack error the version of the
> woven byte code needs to match
>      //the level of byte codes in the original class
>      switch(JAVA_CLASS_VERSION) {
> + case Opcodes.V1_9:
> + LOGGER.debug("Weaving to Java 9");
> + weavingJavaVersion = Opcodes.V1_9;
> + break;
>      case Opcodes.V1_8:
>      LOGGER.debug("Weaving to Java 8");
>      weavingJavaVersion = Opcodes.V1_8;
>
>
> --
> Daniel Kulp
> dkulp@apache.org - http://dankulp.com/blog
> Talend Community Coder - http://coders.talend.com
>
>


-- 
------------------------
Guillaume Nodet
------------------------
Red Hat, Open Source Integration

Email: gnodet@redhat.com
Web: http://fusesource.com
Blog: http://gnodet.blogspot.com/

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message