karaf-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From earcam <...@git.apache.org>
Subject [GitHub] karaf pull request #294: Remove the VM option "-server"
Date Thu, 13 Apr 2017 16:40:12 GMT
GitHub user earcam reopened a pull request:

    https://github.com/apache/karaf/pull/294

    Remove the VM option "-server"

    Hi,
    
    If not explicitly defined, the vm option `-server` has been 
    automatically set since Java 5.  The bar for it picking `-server` over 
    `-client` is pretty low by modern standards; 2 CPU and 2GB RAM.
    
    [http://docs.oracle.com/javase/8/docs/technotes/guides/vm/server-class.html](http://docs.oracle.com/javase/8/docs/technotes/guides/vm/server-class.html)
    
    The Oracle ARMv7 HFP does not support `-server`.  So when running on a 
    Raspberry Pi, one must either set JAVA_OPTS or regex replace the 
    relevant lines in launch scripts.
    
    IMO it would be better to remove this _redundant_ flag, as I'd guess 
    there are few systems that would actually require this to be explicitly 
    set.
    
    cheers,
    Caspar

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/earcam/karaf remove-server-vm-option

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/karaf/pull/294.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #294
    
----
commit 39ce96e53991e73bd591422255f5f560aef705b8
Author: earcam <caspar macrae earcam@gmail.com>
Date:   2017-04-13T15:54:14Z

    Remove the VM option "-server"
    
    If not explicitly defined, the vm option `-server` has been 
    automatically set since Java 5.  The bar for it picking `-server` over 
    `-client` is pretty low by modern standards; 2 CPU and 2GB RAM.
    
    http://docs.oracle.com/javase/8/docs/technotes/guides/vm/server-class.html
    
    The Oracle ARMv7 HFP does not support `-server`.  So when running on a 
    Raspberry Pi, one must either set JAVA_OPTS or regex replace the 
    relevant lines in launch scripts.
    
    IMO it would be better to remove this _redundant_ flag, as I'd guess 
    there are few systems that would actually require this to be explicitly 
    set.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message