karaf-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jean-Baptiste Onofré ...@nanthrax.net>
Subject Re: [PROPOSAL] Add spotless to Karaf and subprojects
Date Wed, 07 Nov 2018 06:01:12 GMT
Hi Greg,

Yes it's fully configurable.

In the PR I'm using the default Google format, which use 2 spaces by
default. I can use a different formatter (eclipse, or google with the
same style we have today).

Let me update the PR.

Regards
JB

On 07/11/2018 06:48, Grzegorz Grzybek wrote:
> Hello
> 
> Wait - 2 spaces? -1 for that. Is this configurable?
> I've never seen project using two spaces (maybe in some
> JavaScript/TypeScript ones). I'm generally +1 for this kind of
> checker/formatter, but such huge one-time change breaks "diffability". I
> would like to have this profile available, but with more common
> configuration - like 4 spaces we had before.
> 
> Also:
> 
>     switch (event.type()) {
>       case Event.TYPE_SHELL:
>         {
> 
> ?
> 
> I know:
> 
> 
> 
> image.png
> But let's review the configuration of this plugin please ;) Also, is
> there Eclipse/IDEA configuration/plugin available?
> 
> regards
> Grzegorz Grzybek
> 

-- 
Jean-Baptiste Onofré
jbonofre@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com

Mime
View raw message