karaf-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Grzegorz Grzybek <gr.grzy...@gmail.com>
Subject Re: [PROPOSAL] Add spotless to Karaf and subprojects
Date Fri, 09 Nov 2018 07:07:24 GMT
Hello



czw., 8 lis 2018 o 20:31 Francois Papon <francois.papon@openobject.fr>
napisał(a):

> Hi JB,
>
> The plugins works well (just tested on Vineyard) and I can see that we
> can add the license header in the plugin configuration :
>
>     <licenseHeader>
>        <!-- Specify either content or file, but not both -->
>        <content>/* Licensed under Apache-2.0 */</content>
>        <file>${basedir}/license-header</file>
>      </licenseHeader>
>
> Should we add this ?
>

Nice! Is it as powerful as e.g., com.mycila:license-maven-plugin? This one
can be configured for different kinds of files, with exceptions and special
mappings.

regards
Grzegorz Grzybek


> regards,
>
> François Papon
> fpapon@apache.org
>
> Le 08/11/2018 à 08:54, Jean-Baptiste Onofré a écrit :
> > Hi guys,
> >
> > I updated the PR to use a 4 spaces indent style.
> >
> > Regards
> > JB
> >
> > On 07/11/2018 05:43, Jean-Baptiste Onofré wrote:
> >> Hi team,
> >>
> >> I created a PR (https://github.com/apache/karaf/pull/648) to enable
> >> spotless in Karaf.
> >>
> >> Spotless is code style checker but also formatter.
> >>
> >> The spotless profile I added in the PR check the style and the style can
> >> be automatically fixed using mvn spotless:apply -Pspotless.
> >>
> >> I think it would be great to have this in Karaf and subprojects to have
> >> a consistency in our code style.
> >>
> >> In combination with rat, it gives us a much cleaner code.
> >>
> >> On the other hand, I was planning to add findbugs maven plugin as well.
> >>
> >> Thoughts ?
> >>
> >> Thanks,
> >> Regards
> >> JB
> >>
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message