karaf-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jean-Baptiste Onofré ...@nanthrax.net>
Subject Re: [PROPOSAL] Add spotless to Karaf and subprojects
Date Fri, 09 Nov 2018 04:43:59 GMT
Hi,

yes, I also planned to test XML formatting.

For license header, it's one or another (content or file). I will do
with content, using the complete content we should (with all ASF legal
stuff).

Regards
JB

On 08/11/2018 12:19, Francois Papon wrote:
> Hi JB,
> 
> The plugins works well (just tested on Vineyard) and I can see that we
> can add the license header in the plugin configuration :
> 
>     <licenseHeader>
>        <!-- Specify either content or file, but not both -->
>        <content>/* Licensed under Apache-2.0 */</content>
>        <file>${basedir}/license-header</file>
>      </licenseHeader>
> 
> Should we add this ?
> 
> regards,
> 
> François Papon
> fpapon@apache.org
> 
> Le 08/11/2018 à 08:54, Jean-Baptiste Onofré a écrit :
>> Hi guys,
>>
>> I updated the PR to use a 4 spaces indent style.
>>
>> Regards
>> JB
>>
>> On 07/11/2018 05:43, Jean-Baptiste Onofré wrote:
>>> Hi team,
>>>
>>> I created a PR (https://github.com/apache/karaf/pull/648) to enable
>>> spotless in Karaf.
>>>
>>> Spotless is code style checker but also formatter.
>>>
>>> The spotless profile I added in the PR check the style and the style can
>>> be automatically fixed using mvn spotless:apply -Pspotless.
>>>
>>> I think it would be great to have this in Karaf and subprojects to have
>>> a consistency in our code style.
>>>
>>> In combination with rat, it gives us a much cleaner code.
>>>
>>> On the other hand, I was planning to add findbugs maven plugin as well.
>>>
>>> Thoughts ?
>>>
>>> Thanks,
>>> Regards
>>> JB
>>>
> 
> 

-- 
Jean-Baptiste Onofré
jbonofre@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com

Mime
View raw message