From dev-return-13334-apmail-karaf-dev-archive=karaf.apache.org@karaf.apache.org Wed Jan 9 06:58:22 2019 Return-Path: X-Original-To: apmail-karaf-dev-archive@minotaur.apache.org Delivered-To: apmail-karaf-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3DE6918BAC for ; Wed, 9 Jan 2019 06:58:22 +0000 (UTC) Received: (qmail 19684 invoked by uid 500); 9 Jan 2019 06:58:22 -0000 Delivered-To: apmail-karaf-dev-archive@karaf.apache.org Received: (qmail 19646 invoked by uid 500); 9 Jan 2019 06:58:21 -0000 Mailing-List: contact dev-help@karaf.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@karaf.apache.org Delivered-To: mailing list dev@karaf.apache.org Received: (qmail 19630 invoked by uid 99); 9 Jan 2019 06:58:20 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 09 Jan 2019 06:58:20 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 8C26EC066E for ; Wed, 9 Jan 2019 06:58:20 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.156 X-Spam-Level: ** X-Spam-Status: No, score=2.156 tagged_above=-999 required=6.31 tests=[DKIMWL_WL_MED=-0.143, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=2, KAM_NUMSUBJECT=0.5, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd4-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id Ui7ogU6hYQ_h for ; Wed, 9 Jan 2019 06:58:18 +0000 (UTC) Received: from mail-lj1-f172.google.com (mail-lj1-f172.google.com [209.85.208.172]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 6F35560E01 for ; Wed, 9 Jan 2019 06:58:18 +0000 (UTC) Received: by mail-lj1-f172.google.com with SMTP id v15-v6so5507745ljh.13 for ; Tue, 08 Jan 2019 22:58:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=dRaKddecG1xGJODQIlDiRUrZQE+WjWQVZicFgBN7aAw=; b=Xwg/mvfKmA3RC/AtL4xjMMaYzApGHqLdmj2/ey1TOy2WWmImM+NHSpiBmGKHjnIN25 Z5OS6W+8mqSvvxv4S8WJ7PdqgxSK02mIwdNTfQRQWU3OTzdgyXKL4ODJoqaFF2Tw0DIr b7m3tdh5OmBOqICp6j2gHlhuX+u6kn2S4MLP2D4Vv6GkIL76lRVvconBb6hRx7RC+sw0 TAE9d5jK5fj9E7vlN4GISTzmQI7P6t7/VS7K9ySAhpMjc1FPznyBrDtVLgWuQ8fHX6xI dszEXIKvI4Nzqp+lrXf8wt8fJaQA7afNXvKo0PsYBV2PvLzjO93C6RXrCmuU4+nYEwLJ yfOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=dRaKddecG1xGJODQIlDiRUrZQE+WjWQVZicFgBN7aAw=; b=VqADeqW7tB41VVqhqnJ4/HLV66YoUpO4tX8+GodrJJyOOmxsoP7GZ9aasb1MCl1oEC CWIolvYCupmj7065/0WIDJHb+pfMfpgTu47H+tnyKNlfAQRtIcNTtOMsYMfEcJVhN7ew h39txlISLcScknJb4unaa+s0rBb9VhXAApckyVcbs4bBTmn9OMfFpTGwDU5ceam+xMFS /aoaBaTr2Kgi16zqNL9caOlNrNcDMCmXIX3aeAHMucjMBwBB2kQEYHbCayFWfKFnwnaY MDAQQhL14d2gT8ds13kPQAc0cQqISNb/cstGWUzyRM3SyQCY/V4eEnRVyDIgnn+CLEmo FjrA== X-Gm-Message-State: AJcUukfbUIH/pfl4diP9Vmg2FGwrKRhnc6P5so5dWp/fKumiTY5o5zDZ aMgvNXWUP8dXx/dc8Li0fXM7w6UfDAkkM9af3PPEC7Gt X-Google-Smtp-Source: ALg8bN4uB3I/SdHTRqxhxAdRvTlfA0GwuHtdnxhhHd/6G0oPUIiHJ6qUCMTdWnxsCfm/Zhpum1n1DJ56P1OcBW0wnjA= X-Received: by 2002:a2e:9603:: with SMTP id v3-v6mr2277882ljh.15.1547017096618; Tue, 08 Jan 2019 22:58:16 -0800 (PST) MIME-Version: 1.0 References: <13167857-13e5-8081-9891-4b39d94e055a@gmx.net> In-Reply-To: <13167857-13e5-8081-9891-4b39d94e055a@gmx.net> From: Grzegorz Grzybek Date: Wed, 9 Jan 2019 07:58:03 +0100 Message-ID: Subject: Re: Version alignment report for Karaf 4.2.3-SNAPSHOT - 1/2 To: dev@karaf.apache.org Content-Type: multipart/alternative; boundary="000000000000816705057f00fc9b" --000000000000816705057f00fc9b Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello wt., 8 sty 2019 o 20:08 Benjamin Graf napisa=C5=82(= a): > Hi Grzegorz, > > is there a reason why the plugin goal for generateConsistencyReport does > not filter the features that were chosen in custom distributions? Using > the report that way generates many "false friends" that are actually not > needed to resolve. Maybe it should also interact with more than only > blacklisted features/bundles for example replacements in > org.apache.karaf.features.xml. This way you can iterative tune your > distribution by adding more and more items to replacement list and > checking consistency report. > > What do you think? > There are two reports: apache-karaf-4.2.3-SNAPSHOT-bundle-report-full.xml and apache-karaf-4.2.3-SNAPSHOT-bundle-report.xml. The non full version takes blacklisted and overriden bundles/features/repositories into account. My idea was exactly this! Blacklist, see report, blacklist/override again, see report, ... That's how I tweak my custom distros (Red Hat Fuse). Indeed - there are lot of false positives, but I don't want to treat it as resolution helper, but as consistency helper. To prevent having too many guava libraries or e.g., commons-beanutils 1.9.2 and 1.9.3 included in the distro. Of course feel free to improve the report as you like ;) https://github.com/apache/karaf/blob/master/profile/src/main/java/org/apach= e/karaf/profile/assembly/Builder.java#L1119-L1224 best regards Grzegorz Grzybek > > Regards > > Benjamin > > Am 08.01.2019 um 13:28 schrieb Grzegorz Grzybek: > > Hello > > > > For any custom Karaf distro we can enable generation of "consistency > > report" - check sample here: > > http://people.apache.org/~ggrzybek/bundle-report-full-karaf.xml > (requires > > browser that can do XSLT transformation using ) > > > > it can be configured using: > > > > > > org.apache.karaf.tooling > > karaf-maven-plugin > > > > > > > ${project.build.directory}/assembly > > .... > > > > karaf-maven-plugin:assembly then generates: > > - bundle-report.xslt - stylesheet to transform XMLs > > - bundle-report-full.xml - full report, including blacklisted > > repos/features/bundles > > - bundle-report.xml - a report without blacklisted items > > > > The idea behind this report is to show _duplicates_ - bundles that appe= ar > > with the same groupId and artifactId (maven) but with different version= . > > The report also shows the features the bundles are declared in and > feature > > repositories the features come from. > > > > Entire closure of bundles =E2=86=92 features =E2=86=92 repositories is = taken into > account. > > > > It's most important when creating custom Karaf distribution - we can > check > > if some features declare conflicting bundles - we (usually) don't want = to > > have two versions of servlet-api JAR installed (though it's not a probl= em > > with guava - it's even a must). > > > > When a _duplicate_ is found or even duplicate repositories are referenc= ed > > (directly or transitively) usually there's a need to _blacklist_ > something. > > > > With https://issues.apache.org/jira/browse/KARAF-5376 I've introduced a > way > > (documentation is still being written...) to blacklist > > bundles/features/repositories or override bundles/features/repositories= . > > > > Blacklisting/overriding is done using etc/org.apache.karaf.features.xml > > file. Short summary of the mechanism is here: > > > https://issues.apache.org/jira/browse/KARAF-5376?focusedCommentId=3D16431= 939&page=3Dcom.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel= #comment-16431939 > > > > In next email, I'll show what should/could be aligned in master branch > for > > Karaf 4.2.3-SNAPSHOT. > > > > regards > > Grzegorz Grzybek > > > > --000000000000816705057f00fc9b--