karaf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KARAF-4255) karaf-maven-plugin does include unused feature conditional dependencies in assembly
Date Sun, 10 Jan 2016 12:27:39 GMT

    [ https://issues.apache.org/jira/browse/KARAF-4255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15091008#comment-15091008

ASF GitHub Bot commented on KARAF-4255:

GitHub user CodingFabian opened a pull request:


    [KARAF-4255] Only include conditional dependencies in assembly if condition is met


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/CodingFabian/karaf KARAF-4255

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #128
commit 8ba57764837cce11a660a97dfacde6716fba5998
Author: Fabian Lange <lange.fabian@gmail.com>
Date:   2016-01-10T12:26:26Z

    [KARAF-4255] Only include conditional dependencies in assembly if condition is met


> karaf-maven-plugin does include unused feature conditional dependencies in assembly
> -----------------------------------------------------------------------------------
>                 Key: KARAF-4255
>                 URL: https://issues.apache.org/jira/browse/KARAF-4255
>             Project: Karaf
>          Issue Type: Bug
>    Affects Versions: 4.0.3
>            Reporter: Fabian Lange
> I am using karaf-maven-plugin to make a custom assembly.
> I do include SCR, but I do not include webconsole.
> When I look into the system folder of my generated assembly, I can see:
> {code}
> target/assembly/system/org/apache/felix/org.apache.felix.webconsole.plugins.ds/2.0.2/org.apache.felix.webconsole.plugins.ds-2.0.2.jar
> {code}
> this correlates to the maven output:
> {code}
> [INFO] Feature scr is defined as a boot feature
> [INFO] == Installing artifact mvn:org.apache.karaf.scr/org.apache.karaf.scr.command/4.0.3
> [INFO] == Installing artifact mvn:org.apache.felix/org.apache.felix.scr/2.0.2
> [INFO] == Installing artifact mvn:org.apache.felix/org.apache.felix.scr.compat/1.0.2
> [INFO] == Installing artifact mvn:org.apache.felix/org.apache.felix.webconsole.plugins.ds/2.0.2
> [INFO] == Installing artifact mvn:org.apache.felix/org.apache.felix.metatype/1.1.2
> [INFO] == Installing artifact mvn:org.apache.karaf.scr/org.apache.karaf.scr.management/4.0.3
> {code}
> however looking at: https://github.com/apache/karaf/blob/master/assemblies/features/standard/src/main/feature/feature.xml#L524
> you can see that this is an conditional dependency only.
> This is caused by the fact that assembly does not check if the conditional had been met:
> https://github.com/apache/karaf/blob/master/profile/src/main/java/org/apache/karaf/profile/assembly/Builder.java#L822
> I believe we need a check for the conditionals wether the condition is actually met.

This message was sent by Atlassian JIRA

View raw message