karaf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tom Quarendon (JIRA)" <j...@apache.org>
Subject [jira] [Created] (KARAF-5440) No override facility for properties in system.properties
Date Mon, 23 Oct 2017 07:31:00 GMT
Tom Quarendon created KARAF-5440:

             Summary: No override facility for properties in system.properties
                 Key: KARAF-5440
                 URL: https://issues.apache.org/jira/browse/KARAF-5440
             Project: Karaf
          Issue Type: Bug
          Components: karaf-core
            Reporter: Tom Quarendon
            Priority: Minor

There are two properties files in karaf that give global properties of various kinds, system.properties
and config.properties.

The "config.properties" file has a facility to override properties within it by putting values
in the "custom.properties" file. We use this to tweak certain values in out custom distribution.
There's no such facility though for the "system.properties" file.

At the moment we therefore hold a copy of the whole system.properties file with a couple of
modifications and include that in our distribution. This is fragile though. For example, recently
one of the properties was changes by a commit to karaf and it took me a while to work out
why things suddenly started behaving differently (this isn't a criticism, I'm just pointing
out the fragility, in case it wasn't clear).

It looks like there wouldn't be any particular reason why this couldn't be done by org.apache.karaf.util.config.PropertiesLoader.
I'm happy to provide a pull request for consideration. I would have suggested having an ${optionals}
line in the system.properties file that would load a file called, say, custom.system.properties.
I would have just replaced the code to load the properties in loadSystemProperties with a
call to loadPropertiesFile.

This message was sent by Atlassian JIRA

View raw message