knox-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From m...@apache.org
Subject knox git commit: KNOX-1117 - HostMap Provider configuration comment in topologies included with Knox has typos (Phil Zampino via Sandeep More)
Date Fri, 01 Dec 2017 16:53:09 GMT
Repository: knox
Updated Branches:
  refs/heads/v0.14.0 28aa8f8c8 -> f2c17d917


KNOX-1117 - HostMap Provider configuration comment in topologies included with Knox has typos
(Phil Zampino via Sandeep More)


Project: http://git-wip-us.apache.org/repos/asf/knox/repo
Commit: http://git-wip-us.apache.org/repos/asf/knox/commit/f2c17d91
Tree: http://git-wip-us.apache.org/repos/asf/knox/tree/f2c17d91
Diff: http://git-wip-us.apache.org/repos/asf/knox/diff/f2c17d91

Branch: refs/heads/v0.14.0
Commit: f2c17d91754ff2de181dd701bf36455f188dd125
Parents: 28aa8f8
Author: Sandeep More <more@apache.org>
Authored: Fri Dec 1 11:53:04 2017 -0500
Committer: Sandeep More <more@apache.org>
Committed: Fri Dec 1 11:53:04 2017 -0500

----------------------------------------------------------------------
 gateway-release/home/conf/topologies/admin.xml  | 21 ++++----------------
 .../home/conf/topologies/knoxsso.xml            |  5 ++++-
 .../home/conf/topologies/manager.xml            | 21 ++++----------------
 .../home/conf/topologies/sandbox.xml            | 21 ++++----------------
 4 files changed, 16 insertions(+), 52 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/knox/blob/f2c17d91/gateway-release/home/conf/topologies/admin.xml
----------------------------------------------------------------------
diff --git a/gateway-release/home/conf/topologies/admin.xml b/gateway-release/home/conf/topologies/admin.xml
index 2f3d9a9..8a0231e 100644
--- a/gateway-release/home/conf/topologies/admin.xml
+++ b/gateway-release/home/conf/topologies/admin.xml
@@ -78,27 +78,14 @@
             <enabled>true</enabled>
         </provider>
 
-        <!--
-        Defines rules for mapping host names internal to a Hadoop cluster to externally accessible
host names.
-        For example, a hadoop service running in AWS may return a response that includes
URLs containing the
-        some AWS internal host name.  If the client needs to make a subsequent request to
the host identified
-        in those URLs they need to be mapped to external host names that the client Knox
can use to connect.
-
-        If the external hostname and internal host names are same turn of this provider by
setting the value of
-        enabled parameter as false.
-
-        The name parameter specifies the external host names in a comma separated list.
-        The value parameter specifies corresponding internal host names in a comma separated
list.
-
-        Note that when you are using Sandbox, the external hostname needs to be localhost,
as seen in out
-        of box sandbox.xml.  This is because Sandbox uses port mapping to allow clients to
connect to the
-        Hadoop services using localhost.  In real clusters, external host names would almost
never be localhost.
-        -->
         <provider>
             <role>hostmap</role>
             <name>static</name>
             <enabled>true</enabled>
-            <param><name>localhost</name><value>sandbox,sandbox.hortonworks.com</value></param>
+            <param>
+                <name>localhost</name>
+                <value>sandbox,sandbox.hortonworks.com</value>
+            </param>
         </provider>
 
     </gateway>

http://git-wip-us.apache.org/repos/asf/knox/blob/f2c17d91/gateway-release/home/conf/topologies/knoxsso.xml
----------------------------------------------------------------------
diff --git a/gateway-release/home/conf/topologies/knoxsso.xml b/gateway-release/home/conf/topologies/knoxsso.xml
index c0b48ce..c0f4d63 100644
--- a/gateway-release/home/conf/topologies/knoxsso.xml
+++ b/gateway-release/home/conf/topologies/knoxsso.xml
@@ -89,7 +89,10 @@
             <role>hostmap</role>
             <name>static</name>
             <enabled>true</enabled>
-            <param><name>localhost</name><value>sandbox,sandbox.hortonworks.com</value></param>
+            <param>
+                <name>localhost</name>
+                <value>sandbox,sandbox.hortonworks.com</value>
+            </param>
         </provider>
 
     </gateway>

http://git-wip-us.apache.org/repos/asf/knox/blob/f2c17d91/gateway-release/home/conf/topologies/manager.xml
----------------------------------------------------------------------
diff --git a/gateway-release/home/conf/topologies/manager.xml b/gateway-release/home/conf/topologies/manager.xml
index 08416c3..736888b 100644
--- a/gateway-release/home/conf/topologies/manager.xml
+++ b/gateway-release/home/conf/topologies/manager.xml
@@ -89,27 +89,14 @@
             <enabled>true</enabled>
         </provider>
 
-        <!--
-        Defines rules for mapping host names internal to a Hadoop cluster to externally accessible
host names.
-        For example, a hadoop service running in AWS may return a response that includes
URLs containing the
-        some AWS internal host name.  If the client needs to make a subsequent request to
the host identified
-        in those URLs they need to be mapped to external host names that the client Knox
can use to connect.
-
-        If the external hostname and internal host names are same turn of this provider by
setting the value of
-        enabled parameter as false.
-
-        The name parameter specifies the external host names in a comma separated list.
-        The value parameter specifies corresponding internal host names in a comma separated
list.
-
-        Note that when you are using Sandbox, the external hostname needs to be localhost,
as seen in out
-        of box sandbox.xml.  This is because Sandbox uses port mapping to allow clients to
connect to the
-        Hadoop services using localhost.  In real clusters, external host names would almost
never be localhost.
-        -->
         <provider>
             <role>hostmap</role>
             <name>static</name>
             <enabled>true</enabled>
-            <param><name>localhost</name><value>sandbox,sandbox.hortonworks.com</value></param>
+            <param>
+                <name>localhost</name>
+                <value>sandbox,sandbox.hortonworks.com</value>
+            </param>
         </provider>
 
     </gateway>

http://git-wip-us.apache.org/repos/asf/knox/blob/f2c17d91/gateway-release/home/conf/topologies/sandbox.xml
----------------------------------------------------------------------
diff --git a/gateway-release/home/conf/topologies/sandbox.xml b/gateway-release/home/conf/topologies/sandbox.xml
index dabee2b..10493f0 100644
--- a/gateway-release/home/conf/topologies/sandbox.xml
+++ b/gateway-release/home/conf/topologies/sandbox.xml
@@ -68,27 +68,14 @@
             <enabled>true</enabled>
         </provider>
 
-        <!--
-        Defines rules for mapping host names internal to a Hadoop cluster to externally accessible
host names.
-        For example, a hadoop service running in AWS may return a response that includes
URLs containing the
-        some AWS internal host name.  If the client needs to make a subsequent request to
the host identified
-        in those URLs they need to be mapped to external host names that the client Knox
can use to connect.
-
-        If the external hostname and internal host names are same turn of this provider by
setting the value of
-        enabled parameter as false.
-
-        The name parameter specifies the external host names in a comma separated list.
-        The value parameter specifies corresponding internal host names in a comma separated
list.
-
-        Note that when you are using Sandbox, the external hostname needs to be localhost,
as seen in out
-        of box sandbox.xml.  This is because Sandbox uses port mapping to allow clients to
connect to the
-        Hadoop services using localhost.  In real clusters, external host names would almost
never be localhost.
-        -->
         <provider>
             <role>hostmap</role>
             <name>static</name>
             <enabled>true</enabled>
-            <param><name>localhost</name><value>sandbox,sandbox.hortonworks.com</value></param>
+            <param>
+                <name>localhost</name>
+                <value>sandbox,sandbox.hortonworks.com</value>
+            </param>
         </provider>
 
     </gateway>


Mime
View raw message