knox-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kris...@apache.org
Subject [1/2] knox git commit: KNOX-1605 - Ensure overridden methods have @Override annotation
Date Thu, 15 Nov 2018 21:00:42 GMT
Repository: knox
Updated Branches:
  refs/heads/master 0f89a951e -> c4b35aaff


http://git-wip-us.apache.org/repos/asf/knox/blob/c4b35aaf/gateway-server/src/main/java/org/apache/knox/gateway/topology/discovery/DefaultServiceDiscoveryConfig.java
----------------------------------------------------------------------
diff --git a/gateway-server/src/main/java/org/apache/knox/gateway/topology/discovery/DefaultServiceDiscoveryConfig.java b/gateway-server/src/main/java/org/apache/knox/gateway/topology/discovery/DefaultServiceDiscoveryConfig.java
index fde01b0..04e0e8c 100644
--- a/gateway-server/src/main/java/org/apache/knox/gateway/topology/discovery/DefaultServiceDiscoveryConfig.java
+++ b/gateway-server/src/main/java/org/apache/knox/gateway/topology/discovery/DefaultServiceDiscoveryConfig.java
@@ -33,14 +33,17 @@ public class DefaultServiceDiscoveryConfig implements ServiceDiscoveryConfig {
         this.pwdAlias = alias;
     }
 
+    @Override
     public String getAddress() {
         return address;
     }
 
+    @Override
     public String getUser() {
         return user;
     }
 
+    @Override
     public String getPasswordAlias() {
         return pwdAlias;
     }

http://git-wip-us.apache.org/repos/asf/knox/blob/c4b35aaf/gateway-server/src/main/java/org/apache/knox/gateway/topology/monitor/DefaultRemoteConfigurationMonitor.java
----------------------------------------------------------------------
diff --git a/gateway-server/src/main/java/org/apache/knox/gateway/topology/monitor/DefaultRemoteConfigurationMonitor.java b/gateway-server/src/main/java/org/apache/knox/gateway/topology/monitor/DefaultRemoteConfigurationMonitor.java
index d94eb73..87d9373 100644
--- a/gateway-server/src/main/java/org/apache/knox/gateway/topology/monitor/DefaultRemoteConfigurationMonitor.java
+++ b/gateway-server/src/main/java/org/apache/knox/gateway/topology/monitor/DefaultRemoteConfigurationMonitor.java
@@ -46,22 +46,27 @@ class DefaultRemoteConfigurationMonitor implements RemoteConfigurationMonitor {
     private static final RemoteConfigurationRegistryClient.EntryACL AUTHENTICATED_USERS_ALL;
     static {
         AUTHENTICATED_USERS_ALL = new RemoteConfigurationRegistryClient.EntryACL() {
+            @Override
             public String getId() {
                 return "";
             }
 
+            @Override
             public String getType() {
                 return "auth";
             }
 
+            @Override
             public Object getPermissions() {
                 return ZooDefs.Perms.ALL;
             }
 
+            @Override
             public boolean canRead() {
                 return true;
             }
 
+            @Override
             public boolean canWrite() {
                 return true;
             }
@@ -71,22 +76,27 @@ class DefaultRemoteConfigurationMonitor implements RemoteConfigurationMonitor {
     private static final RemoteConfigurationRegistryClient.EntryACL WORLD_ANYONE_READ;
     static {
         WORLD_ANYONE_READ = new RemoteConfigurationRegistryClient.EntryACL() {
+            @Override
             public String getId() {
                 return "anyone";
             }
 
+            @Override
             public String getType() {
                 return "world";
             }
 
+            @Override
             public Object getPermissions() {
                 return ZooDefs.Perms.READ;
             }
 
+            @Override
             public boolean canRead() {
                 return true;
             }
 
+            @Override
             public boolean canWrite() {
                 return false;
             }

http://git-wip-us.apache.org/repos/asf/knox/blob/c4b35aaf/gateway-server/src/main/java/org/apache/knox/gateway/topology/validation/TopologyValidator.java
----------------------------------------------------------------------
diff --git a/gateway-server/src/main/java/org/apache/knox/gateway/topology/validation/TopologyValidator.java b/gateway-server/src/main/java/org/apache/knox/gateway/topology/validation/TopologyValidator.java
index 090bffc..1a7359b 100644
--- a/gateway-server/src/main/java/org/apache/knox/gateway/topology/validation/TopologyValidator.java
+++ b/gateway-server/src/main/java/org/apache/knox/gateway/topology/validation/TopologyValidator.java
@@ -62,14 +62,17 @@ public class TopologyValidator {
       Validator validator = s.newValidator();
       final List<SAXParseException> exceptions = new LinkedList<>();
       validator.setErrorHandler(new ErrorHandler() {
+        @Override
         public void warning(SAXParseException exception) throws SAXException {
           exceptions.add(exception);
         }
 
+        @Override
         public void fatalError(SAXParseException exception) throws SAXException {
           exceptions.add(exception);
         }
 
+        @Override
         public void error(SAXParseException exception) throws SAXException {
           exceptions.add(exception);
         }

http://git-wip-us.apache.org/repos/asf/knox/blob/c4b35aaf/gateway-server/src/main/java/org/apache/knox/gateway/trace/TraceRequest.java
----------------------------------------------------------------------
diff --git a/gateway-server/src/main/java/org/apache/knox/gateway/trace/TraceRequest.java b/gateway-server/src/main/java/org/apache/knox/gateway/trace/TraceRequest.java
index 3b4eaca..e40ef98 100644
--- a/gateway-server/src/main/java/org/apache/knox/gateway/trace/TraceRequest.java
+++ b/gateway-server/src/main/java/org/apache/knox/gateway/trace/TraceRequest.java
@@ -40,6 +40,7 @@ class TraceRequest extends HttpServletRequestWrapper {
     }
   }
 
+  @Override
   public synchronized ServletInputStream getInputStream() throws IOException {
     if( log.isTraceEnabled() ) {
       if( input == null ) {

http://git-wip-us.apache.org/repos/asf/knox/blob/c4b35aaf/gateway-server/src/main/java/org/apache/knox/gateway/trace/TraceResponse.java
----------------------------------------------------------------------
diff --git a/gateway-server/src/main/java/org/apache/knox/gateway/trace/TraceResponse.java b/gateway-server/src/main/java/org/apache/knox/gateway/trace/TraceResponse.java
index 92d9ccc..e954338 100644
--- a/gateway-server/src/main/java/org/apache/knox/gateway/trace/TraceResponse.java
+++ b/gateway-server/src/main/java/org/apache/knox/gateway/trace/TraceResponse.java
@@ -41,6 +41,7 @@ class TraceResponse extends HttpServletResponseWrapper {
     this.filter = filter;
   }
 
+  @Override
   public synchronized ServletOutputStream getOutputStream() throws IOException {
     if( log.isTraceEnabled() ) {
       traceResponseDetails();

http://git-wip-us.apache.org/repos/asf/knox/blob/c4b35aaf/gateway-server/src/main/java/org/apache/knox/gateway/util/KnoxCLI.java
----------------------------------------------------------------------
diff --git a/gateway-server/src/main/java/org/apache/knox/gateway/util/KnoxCLI.java b/gateway-server/src/main/java/org/apache/knox/gateway/util/KnoxCLI.java
index 9e66ecc..90255cd 100644
--- a/gateway-server/src/main/java/org/apache/knox/gateway/util/KnoxCLI.java
+++ b/gateway-server/src/main/java/org/apache/knox/gateway/util/KnoxCLI.java
@@ -861,6 +861,7 @@ public class KnoxCLI extends Configured implements Tool {
      return result;
    }
 
+   @Override
    public boolean validate() {
      boolean valid = true;
      GatewayConfig config = getGatewayConfig();
@@ -990,6 +991,7 @@ public class KnoxCLI extends Configured implements Tool {
       return USAGE + ":\n\n" + DESC;
     }
 
+    @Override
     public void execute() throws Exception {
       GatewayConfig gc = getGatewayConfig();
       String topDir = gc.getGatewayTopologyDir();

http://git-wip-us.apache.org/repos/asf/knox/blob/c4b35aaf/gateway-server/src/test/java/org/apache/knox/gateway/jetty/SslSocketTest.java
----------------------------------------------------------------------
diff --git a/gateway-server/src/test/java/org/apache/knox/gateway/jetty/SslSocketTest.java b/gateway-server/src/test/java/org/apache/knox/gateway/jetty/SslSocketTest.java
index d21e8fd..a3cd6cd 100644
--- a/gateway-server/src/test/java/org/apache/knox/gateway/jetty/SslSocketTest.java
+++ b/gateway-server/src/test/java/org/apache/knox/gateway/jetty/SslSocketTest.java
@@ -75,6 +75,7 @@ public class SslSocketTest {
       return ready;
     }
 
+    @Override
     public void run() {
       try {
         SSLServerSocketFactory sslserversocketfactory = (SSLServerSocketFactory)SSLServerSocketFactory.getDefault();

http://git-wip-us.apache.org/repos/asf/knox/blob/c4b35aaf/gateway-service-admin/src/main/java/org/apache/knox/gateway/service/admin/beans/Application.java
----------------------------------------------------------------------
diff --git a/gateway-service-admin/src/main/java/org/apache/knox/gateway/service/admin/beans/Application.java b/gateway-service-admin/src/main/java/org/apache/knox/gateway/service/admin/beans/Application.java
index 0c56374..01145e1 100644
--- a/gateway-service-admin/src/main/java/org/apache/knox/gateway/service/admin/beans/Application.java
+++ b/gateway-service-admin/src/main/java/org/apache/knox/gateway/service/admin/beans/Application.java
@@ -23,11 +23,13 @@ import javax.xml.bind.annotation.XmlAccessorType;
 @XmlAccessorType(XmlAccessType.NONE)
 public class Application extends Service {
 
+  @Override
   public String getRole() {
     return getName();
   }
 
-  public void setRole( String role ) {
+  @Override
+  public void setRole(String role ) {
     setName( role );
   }
 

http://git-wip-us.apache.org/repos/asf/knox/blob/c4b35aaf/gateway-service-hbase/src/main/java/org/apache/knox/gateway/hbase/HBaseDispatch.java
----------------------------------------------------------------------
diff --git a/gateway-service-hbase/src/main/java/org/apache/knox/gateway/hbase/HBaseDispatch.java b/gateway-service-hbase/src/main/java/org/apache/knox/gateway/hbase/HBaseDispatch.java
index 833dea1..3e47383 100644
--- a/gateway-service-hbase/src/main/java/org/apache/knox/gateway/hbase/HBaseDispatch.java
+++ b/gateway-service-hbase/src/main/java/org/apache/knox/gateway/hbase/HBaseDispatch.java
@@ -33,7 +33,8 @@ import org.apache.knox.gateway.dispatch.DefaultDispatch;
 public class HBaseDispatch extends DefaultDispatch {
 
   // KNOX-709: HBase can't handle URL encoded paths.
-  public URI getDispatchUrl( HttpServletRequest request) {
+  @Override
+  public URI getDispatchUrl(HttpServletRequest request) {
     String base = request.getRequestURI();
     StringBuilder str = new StringBuilder();
     try {

http://git-wip-us.apache.org/repos/asf/knox/blob/c4b35aaf/gateway-service-hive/src/main/java/org/apache/knox/gateway/hive/HiveDispatch.java
----------------------------------------------------------------------
diff --git a/gateway-service-hive/src/main/java/org/apache/knox/gateway/hive/HiveDispatch.java b/gateway-service-hive/src/main/java/org/apache/knox/gateway/hive/HiveDispatch.java
index aa44241..4ddbe46 100644
--- a/gateway-service-hive/src/main/java/org/apache/knox/gateway/hive/HiveDispatch.java
+++ b/gateway-service-hive/src/main/java/org/apache/knox/gateway/hive/HiveDispatch.java
@@ -34,6 +34,7 @@ public class HiveDispatch extends DefaultDispatch {
     super.init();
   }
 
+  @Override
   protected void addCredentialsToRequest(HttpUriRequest request) {
     if( isBasicAuthPreemptive() ) {
       HiveDispatchUtils.addCredentialsToRequest(request);

http://git-wip-us.apache.org/repos/asf/knox/blob/c4b35aaf/gateway-service-hive/src/main/java/org/apache/knox/gateway/hive/HiveHaDispatch.java
----------------------------------------------------------------------
diff --git a/gateway-service-hive/src/main/java/org/apache/knox/gateway/hive/HiveHaDispatch.java b/gateway-service-hive/src/main/java/org/apache/knox/gateway/hive/HiveHaDispatch.java
index 92911ad..9403a2c 100644
--- a/gateway-service-hive/src/main/java/org/apache/knox/gateway/hive/HiveHaDispatch.java
+++ b/gateway-service-hive/src/main/java/org/apache/knox/gateway/hive/HiveHaDispatch.java
@@ -31,6 +31,7 @@ public class HiveHaDispatch extends DefaultHaDispatch {
     setServiceRole("HIVE");
   }
 
+  @Override
   protected void addCredentialsToRequest(HttpUriRequest request) {
     if ( isBasicAuthPreemptive() ) {
       HiveDispatchUtils.addCredentialsToRequest(request);

http://git-wip-us.apache.org/repos/asf/knox/blob/c4b35aaf/gateway-service-nifi/src/main/java/org/apache/knox/gateway/dispatch/NiFiDispatch.java
----------------------------------------------------------------------
diff --git a/gateway-service-nifi/src/main/java/org/apache/knox/gateway/dispatch/NiFiDispatch.java b/gateway-service-nifi/src/main/java/org/apache/knox/gateway/dispatch/NiFiDispatch.java
index da2c529..ef02bd0 100644
--- a/gateway-service-nifi/src/main/java/org/apache/knox/gateway/dispatch/NiFiDispatch.java
+++ b/gateway-service-nifi/src/main/java/org/apache/knox/gateway/dispatch/NiFiDispatch.java
@@ -43,6 +43,7 @@ public class NiFiDispatch extends DefaultDispatch {
   /**
    * Overridden to provide a spot to modify the outbound response before its stream is closed.
    */
+  @Override
   protected void writeOutboundResponse(HttpUriRequest outboundRequest, HttpServletRequest inboundRequest, HttpServletResponse outboundResponse, HttpResponse inboundResponse) throws IOException {
     // Copy the client respond header to the server respond.
     outboundResponse.setStatus(inboundResponse.getStatusLine().getStatusCode());

http://git-wip-us.apache.org/repos/asf/knox/blob/c4b35aaf/gateway-service-nifi/src/main/java/org/apache/knox/gateway/dispatch/NiFiHaDispatch.java
----------------------------------------------------------------------
diff --git a/gateway-service-nifi/src/main/java/org/apache/knox/gateway/dispatch/NiFiHaDispatch.java b/gateway-service-nifi/src/main/java/org/apache/knox/gateway/dispatch/NiFiHaDispatch.java
index bea1fac..c79124c 100644
--- a/gateway-service-nifi/src/main/java/org/apache/knox/gateway/dispatch/NiFiHaDispatch.java
+++ b/gateway-service-nifi/src/main/java/org/apache/knox/gateway/dispatch/NiFiHaDispatch.java
@@ -54,6 +54,7 @@ public class NiFiHaDispatch extends DefaultHaDispatch {
   /**
    * Overridden to provide a spot to modify the outbound response before its stream is closed.
    */
+  @Override
   protected void writeOutboundResponse(HttpUriRequest outboundRequest, HttpServletRequest inboundRequest, HttpServletResponse outboundResponse, HttpResponse inboundResponse) throws IOException {
     // Copy the client respond header to the server respond.
     outboundResponse.setStatus(inboundResponse.getStatusLine().getStatusCode());

http://git-wip-us.apache.org/repos/asf/knox/blob/c4b35aaf/gateway-service-remoteconfig/src/main/java/org/apache/knox/gateway/service/config/remote/config/RemoteConfigurationRegistry.java
----------------------------------------------------------------------
diff --git a/gateway-service-remoteconfig/src/main/java/org/apache/knox/gateway/service/config/remote/config/RemoteConfigurationRegistry.java b/gateway-service-remoteconfig/src/main/java/org/apache/knox/gateway/service/config/remote/config/RemoteConfigurationRegistry.java
index a934113..6c865e5 100644
--- a/gateway-service-remoteconfig/src/main/java/org/apache/knox/gateway/service/config/remote/config/RemoteConfigurationRegistry.java
+++ b/gateway-service-remoteconfig/src/main/java/org/apache/knox/gateway/service/config/remote/config/RemoteConfigurationRegistry.java
@@ -76,26 +76,31 @@ class RemoteConfigurationRegistry implements RemoteConfigurationRegistryConfig {
         this.keyTab = keytab;
     }
 
+    @Override
     @XmlElement(name="name")
     public String getName() {
         return name;
     }
 
+    @Override
     @XmlElement(name="type")
     public String getRegistryType() {
         return type;
     }
 
+    @Override
     @XmlElement(name="auth-type")
     public String getAuthType() {
         return authType;
     }
 
+    @Override
     @XmlElement(name="principal")
     public String getPrincipal() {
         return principal;
     }
 
+    @Override
     @XmlElement(name="credential-alias")
     public String getCredentialAlias() {
         return credentialAlias;

http://git-wip-us.apache.org/repos/asf/knox/blob/c4b35aaf/gateway-service-rm/src/main/java/org/apache/knox/gateway/rm/dispatch/RMHaDispatch.java
----------------------------------------------------------------------
diff --git a/gateway-service-rm/src/main/java/org/apache/knox/gateway/rm/dispatch/RMHaDispatch.java b/gateway-service-rm/src/main/java/org/apache/knox/gateway/rm/dispatch/RMHaDispatch.java
index 17ca574..bf3f050 100644
--- a/gateway-service-rm/src/main/java/org/apache/knox/gateway/rm/dispatch/RMHaDispatch.java
+++ b/gateway-service-rm/src/main/java/org/apache/knox/gateway/rm/dispatch/RMHaDispatch.java
@@ -28,6 +28,7 @@ public class RMHaDispatch extends RMHaBaseDispatcher {
   public RMHaDispatch() {
     super();
   }
+   @Override
    @Configure
    public void setHaProvider(HaProvider haProvider) {
         this.haProvider = haProvider;

http://git-wip-us.apache.org/repos/asf/knox/blob/c4b35aaf/gateway-service-rm/src/main/java/org/apache/knox/gateway/rm/dispatch/RMUI2HaDispatch.java
----------------------------------------------------------------------
diff --git a/gateway-service-rm/src/main/java/org/apache/knox/gateway/rm/dispatch/RMUI2HaDispatch.java b/gateway-service-rm/src/main/java/org/apache/knox/gateway/rm/dispatch/RMUI2HaDispatch.java
index d5adaed..3d247a4 100644
--- a/gateway-service-rm/src/main/java/org/apache/knox/gateway/rm/dispatch/RMUI2HaDispatch.java
+++ b/gateway-service-rm/src/main/java/org/apache/knox/gateway/rm/dispatch/RMUI2HaDispatch.java
@@ -29,6 +29,7 @@ public class RMUI2HaDispatch extends RMHaBaseDispatcher {
    super();
   }
 
+  @Override
   @Configure
   public void setHaProvider(HaProvider haProvider) {
     this.haProvider = haProvider;

http://git-wip-us.apache.org/repos/asf/knox/blob/c4b35aaf/gateway-service-rm/src/main/java/org/apache/knox/gateway/rm/dispatch/RMUIHaDispatch.java
----------------------------------------------------------------------
diff --git a/gateway-service-rm/src/main/java/org/apache/knox/gateway/rm/dispatch/RMUIHaDispatch.java b/gateway-service-rm/src/main/java/org/apache/knox/gateway/rm/dispatch/RMUIHaDispatch.java
index 3143af1..cf9068e 100644
--- a/gateway-service-rm/src/main/java/org/apache/knox/gateway/rm/dispatch/RMUIHaDispatch.java
+++ b/gateway-service-rm/src/main/java/org/apache/knox/gateway/rm/dispatch/RMUIHaDispatch.java
@@ -30,6 +30,7 @@ public class RMUIHaDispatch extends RMHaBaseDispatcher {
   public RMUIHaDispatch() throws ServletException {
     super();
   }
+   @Override
    @Configure
    public void setHaProvider(HaProvider haProvider) {
         this.haProvider = haProvider;

http://git-wip-us.apache.org/repos/asf/knox/blob/c4b35aaf/gateway-service-webhdfs/src/main/java/org/apache/knox/gateway/hdfs/dispatch/HdfsHttpClientDispatch.java
----------------------------------------------------------------------
diff --git a/gateway-service-webhdfs/src/main/java/org/apache/knox/gateway/hdfs/dispatch/HdfsHttpClientDispatch.java b/gateway-service-webhdfs/src/main/java/org/apache/knox/gateway/hdfs/dispatch/HdfsHttpClientDispatch.java
index 6da2190..b5fbf0f 100644
--- a/gateway-service-webhdfs/src/main/java/org/apache/knox/gateway/hdfs/dispatch/HdfsHttpClientDispatch.java
+++ b/gateway-service-webhdfs/src/main/java/org/apache/knox/gateway/hdfs/dispatch/HdfsHttpClientDispatch.java
@@ -39,6 +39,7 @@ public class HdfsHttpClientDispatch extends DefaultDispatch {
    * send the entire payload before redirect to the target component
    * like a datanode and have to send it again.
    */
+  @Override
   protected HttpEntity createRequestEntity(HttpServletRequest request)
       throws IOException {
     return null;

http://git-wip-us.apache.org/repos/asf/knox/blob/c4b35aaf/gateway-service-webhdfs/src/main/java/org/apache/knox/gateway/hdfs/dispatch/HdfsUIHaDispatch.java
----------------------------------------------------------------------
diff --git a/gateway-service-webhdfs/src/main/java/org/apache/knox/gateway/hdfs/dispatch/HdfsUIHaDispatch.java b/gateway-service-webhdfs/src/main/java/org/apache/knox/gateway/hdfs/dispatch/HdfsUIHaDispatch.java
index b84f8f3..d4edc96 100644
--- a/gateway-service-webhdfs/src/main/java/org/apache/knox/gateway/hdfs/dispatch/HdfsUIHaDispatch.java
+++ b/gateway-service-webhdfs/src/main/java/org/apache/knox/gateway/hdfs/dispatch/HdfsUIHaDispatch.java
@@ -26,6 +26,7 @@ public class HdfsUIHaDispatch extends AbstractHdfsHaDispatch {
     super();
   }
 
+  @Override
   protected String getResourceRole() {
     return RESOURCE_ROLE;
   }

http://git-wip-us.apache.org/repos/asf/knox/blob/c4b35aaf/gateway-service-webhdfs/src/main/java/org/apache/knox/gateway/hdfs/dispatch/WebHdfsHaDispatch.java
----------------------------------------------------------------------
diff --git a/gateway-service-webhdfs/src/main/java/org/apache/knox/gateway/hdfs/dispatch/WebHdfsHaDispatch.java b/gateway-service-webhdfs/src/main/java/org/apache/knox/gateway/hdfs/dispatch/WebHdfsHaDispatch.java
index 6cff354..925800e 100644
--- a/gateway-service-webhdfs/src/main/java/org/apache/knox/gateway/hdfs/dispatch/WebHdfsHaDispatch.java
+++ b/gateway-service-webhdfs/src/main/java/org/apache/knox/gateway/hdfs/dispatch/WebHdfsHaDispatch.java
@@ -26,6 +26,7 @@ public class WebHdfsHaDispatch extends AbstractHdfsHaDispatch {
     super();
   }
   
+  @Override
   protected String getResourceRole() {
     return RESOURCE_ROLE;
   }

http://git-wip-us.apache.org/repos/asf/knox/blob/c4b35aaf/gateway-shell/src/main/java/org/apache/knox/gateway/shell/BasicResponse.java
----------------------------------------------------------------------
diff --git a/gateway-shell/src/main/java/org/apache/knox/gateway/shell/BasicResponse.java b/gateway-shell/src/main/java/org/apache/knox/gateway/shell/BasicResponse.java
index bcfbfa7..d7e3b50 100644
--- a/gateway-shell/src/main/java/org/apache/knox/gateway/shell/BasicResponse.java
+++ b/gateway-shell/src/main/java/org/apache/knox/gateway/shell/BasicResponse.java
@@ -44,6 +44,7 @@ public class BasicResponse implements Closeable {
     }
   }
 
+  @Override
   public void close() {
     consume();
   }

http://git-wip-us.apache.org/repos/asf/knox/blob/c4b35aaf/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hbase/ClusterVersion.java
----------------------------------------------------------------------
diff --git a/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hbase/ClusterVersion.java b/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hbase/ClusterVersion.java
index 6a472ac..f07fe46 100644
--- a/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hbase/ClusterVersion.java
+++ b/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hbase/ClusterVersion.java
@@ -33,6 +33,7 @@ public class ClusterVersion {
       super( session );
     }
 
+    @Override
     protected Callable<Response> callable() {
       return new Callable<Response>() {
         @Override

http://git-wip-us.apache.org/repos/asf/knox/blob/c4b35aaf/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hbase/Status.java
----------------------------------------------------------------------
diff --git a/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hbase/Status.java b/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hbase/Status.java
index 1cc7953..199148e 100644
--- a/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hbase/Status.java
+++ b/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hbase/Status.java
@@ -33,6 +33,7 @@ public class Status {
       super( session );
     }
 
+    @Override
     protected Callable<Response> callable() {
       return new Callable<Response>() {
         @Override

http://git-wip-us.apache.org/repos/asf/knox/blob/c4b35aaf/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hbase/SystemVersion.java
----------------------------------------------------------------------
diff --git a/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hbase/SystemVersion.java b/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hbase/SystemVersion.java
index c2505d4..9043386 100644
--- a/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hbase/SystemVersion.java
+++ b/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hbase/SystemVersion.java
@@ -33,6 +33,7 @@ public class SystemVersion {
       super( session );
     }
 
+    @Override
     protected Callable<Response> callable() {
       return new Callable<Response>() {
         @Override

http://git-wip-us.apache.org/repos/asf/knox/blob/c4b35aaf/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hbase/table/CreateTable.java
----------------------------------------------------------------------
diff --git a/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hbase/table/CreateTable.java b/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hbase/table/CreateTable.java
index dc54037..3d0b801 100644
--- a/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hbase/table/CreateTable.java
+++ b/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hbase/table/CreateTable.java
@@ -72,6 +72,7 @@ public class CreateTable {
       return this;
     }
 
+    @Override
     protected Callable<Response> callable() {
       return new Callable<Response>() {
         @Override

http://git-wip-us.apache.org/repos/asf/knox/blob/c4b35aaf/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hbase/table/DeleteTable.java
----------------------------------------------------------------------
diff --git a/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hbase/table/DeleteTable.java b/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hbase/table/DeleteTable.java
index 5389eea..4cdf9f7 100644
--- a/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hbase/table/DeleteTable.java
+++ b/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hbase/table/DeleteTable.java
@@ -37,6 +37,7 @@ public class DeleteTable {
       this.tableName = tableName;
     }
 
+    @Override
     protected Callable<Response> callable() {
       return new Callable<Response>() {
         @Override

http://git-wip-us.apache.org/repos/asf/knox/blob/c4b35aaf/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hbase/table/TableList.java
----------------------------------------------------------------------
diff --git a/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hbase/table/TableList.java b/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hbase/table/TableList.java
index cdc022b..74a39cd 100644
--- a/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hbase/table/TableList.java
+++ b/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hbase/table/TableList.java
@@ -34,6 +34,7 @@ public class TableList {
       super( session );
     }
 
+    @Override
     protected Callable<Response> callable() {
       return new Callable<Response>() {
         @Override

http://git-wip-us.apache.org/repos/asf/knox/blob/c4b35aaf/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hbase/table/TableRegions.java
----------------------------------------------------------------------
diff --git a/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hbase/table/TableRegions.java b/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hbase/table/TableRegions.java
index 7455d56..d4bff64 100644
--- a/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hbase/table/TableRegions.java
+++ b/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hbase/table/TableRegions.java
@@ -37,6 +37,7 @@ public class TableRegions {
       this.tableName = tableName;
     }
 
+    @Override
     protected Callable<Response> callable() {
       return new Callable<Response>() {
         @Override

http://git-wip-us.apache.org/repos/asf/knox/blob/c4b35aaf/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hbase/table/TableSchema.java
----------------------------------------------------------------------
diff --git a/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hbase/table/TableSchema.java b/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hbase/table/TableSchema.java
index 97956bd..a1e76f3 100644
--- a/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hbase/table/TableSchema.java
+++ b/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hbase/table/TableSchema.java
@@ -37,6 +37,7 @@ public class TableSchema {
       this.tableName = tableName;
     }
 
+    @Override
     protected Callable<Response> callable() {
       return new Callable<Response>() {
         @Override

http://git-wip-us.apache.org/repos/asf/knox/blob/c4b35aaf/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hbase/table/TruncateTable.java
----------------------------------------------------------------------
diff --git a/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hbase/table/TruncateTable.java b/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hbase/table/TruncateTable.java
index c67e9bd..2fdcdbf 100644
--- a/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hbase/table/TruncateTable.java
+++ b/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hbase/table/TruncateTable.java
@@ -44,6 +44,7 @@ public class TruncateTable {
       this.tableName = tableName;
     }
 
+    @Override
     protected Callable<TruncateTable.Response> callable() {
       return new Callable<TruncateTable.Response>() {
         @Override

http://git-wip-us.apache.org/repos/asf/knox/blob/c4b35aaf/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hbase/table/UpdateTable.java
----------------------------------------------------------------------
diff --git a/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hbase/table/UpdateTable.java b/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hbase/table/UpdateTable.java
index eb6d879..16dda54 100644
--- a/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hbase/table/UpdateTable.java
+++ b/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hbase/table/UpdateTable.java
@@ -66,6 +66,7 @@ public class UpdateTable {
       return this;
     }
 
+    @Override
     protected Callable<Response> callable() {
       return new Callable<Response>() {
         @Override

http://git-wip-us.apache.org/repos/asf/knox/blob/c4b35aaf/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hbase/table/row/DeleteRows.java
----------------------------------------------------------------------
diff --git a/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hbase/table/row/DeleteRows.java b/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hbase/table/row/DeleteRows.java
index 8671b7f..ee8d7d1 100644
--- a/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hbase/table/row/DeleteRows.java
+++ b/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hbase/table/row/DeleteRows.java
@@ -56,6 +56,7 @@ public class DeleteRows {
       return this;
     }
 
+    @Override
     protected Callable<Response> callable() {
       return new Callable<Response>() {
         @Override

http://git-wip-us.apache.org/repos/asf/knox/blob/c4b35aaf/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hbase/table/row/QueryRows.java
----------------------------------------------------------------------
diff --git a/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hbase/table/row/QueryRows.java b/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hbase/table/row/QueryRows.java
index a30b3af..7686520 100644
--- a/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hbase/table/row/QueryRows.java
+++ b/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hbase/table/row/QueryRows.java
@@ -76,6 +76,7 @@ public class QueryRows {
       return this;
     }
 
+    @Override
     protected Callable<Response> callable() {
       return new Callable<Response>() {
         @Override

http://git-wip-us.apache.org/repos/asf/knox/blob/c4b35aaf/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hbase/table/row/StoreRow.java
----------------------------------------------------------------------
diff --git a/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hbase/table/row/StoreRow.java b/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hbase/table/row/StoreRow.java
index 77ba041..25cdce1 100644
--- a/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hbase/table/row/StoreRow.java
+++ b/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hbase/table/row/StoreRow.java
@@ -70,6 +70,7 @@ public class StoreRow {
       return this;
     }
 
+    @Override
     protected Callable<Response> callable() {
       return new Callable<Response>() {
         @Override

http://git-wip-us.apache.org/repos/asf/knox/blob/c4b35aaf/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hbase/table/scanner/CreateScanner.java
----------------------------------------------------------------------
diff --git a/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hbase/table/scanner/CreateScanner.java b/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hbase/table/scanner/CreateScanner.java
index 26816ee..53afadf 100644
--- a/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hbase/table/scanner/CreateScanner.java
+++ b/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hbase/table/scanner/CreateScanner.java
@@ -127,6 +127,7 @@ public class CreateScanner {
       return this;
     }
 
+    @Override
     protected Callable<Response> callable() {
       return new Callable<Response>() {
         @Override

http://git-wip-us.apache.org/repos/asf/knox/blob/c4b35aaf/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hbase/table/scanner/DeleteScanner.java
----------------------------------------------------------------------
diff --git a/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hbase/table/scanner/DeleteScanner.java b/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hbase/table/scanner/DeleteScanner.java
index a25acf6..3a31d59 100644
--- a/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hbase/table/scanner/DeleteScanner.java
+++ b/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hbase/table/scanner/DeleteScanner.java
@@ -39,6 +39,7 @@ public class DeleteScanner {
       this.tableName = tableName;
     }
 
+    @Override
     protected Callable<Response> callable() {
       return new Callable<Response>() {
         @Override

http://git-wip-us.apache.org/repos/asf/knox/blob/c4b35aaf/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hbase/table/scanner/ScannerGetNext.java
----------------------------------------------------------------------
diff --git a/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hbase/table/scanner/ScannerGetNext.java b/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hbase/table/scanner/ScannerGetNext.java
index 28f26b2..c9fd4f0 100644
--- a/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hbase/table/scanner/ScannerGetNext.java
+++ b/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hbase/table/scanner/ScannerGetNext.java
@@ -39,6 +39,7 @@ public class ScannerGetNext {
       this.tableName = tableName;
     }
 
+    @Override
     protected Callable<Response> callable() {
       return new Callable<Response>() {
         @Override

http://git-wip-us.apache.org/repos/asf/knox/blob/c4b35aaf/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hdfs/Get.java
----------------------------------------------------------------------
diff --git a/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hdfs/Get.java b/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hdfs/Get.java
index 202e735..28e4419 100644
--- a/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hdfs/Get.java
+++ b/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hdfs/Get.java
@@ -51,6 +51,7 @@ public class Get {
     }
 
 
+    @Override
     protected Callable<Response> callable() {
       return new Callable<Response>() {
         @Override

http://git-wip-us.apache.org/repos/asf/knox/blob/c4b35aaf/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hdfs/Ls.java
----------------------------------------------------------------------
diff --git a/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hdfs/Ls.java b/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hdfs/Ls.java
index 04c0a06..88d8d86 100644
--- a/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hdfs/Ls.java
+++ b/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hdfs/Ls.java
@@ -41,6 +41,7 @@ class Ls {
       return this;
     }
 
+    @Override
     protected Callable<Response> callable() {
       return new Callable<Response>() {
         @Override

http://git-wip-us.apache.org/repos/asf/knox/blob/c4b35aaf/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hdfs/Mkdir.java
----------------------------------------------------------------------
diff --git a/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hdfs/Mkdir.java b/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hdfs/Mkdir.java
index 3dd5d82..d4aaab7 100644
--- a/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hdfs/Mkdir.java
+++ b/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hdfs/Mkdir.java
@@ -47,6 +47,7 @@ class Mkdir {
       return this;
     }
 
+    @Override
     public Callable<Response> callable() {
       return new Callable<Response>() {
         @Override

http://git-wip-us.apache.org/repos/asf/knox/blob/c4b35aaf/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hdfs/Put.java
----------------------------------------------------------------------
diff --git a/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hdfs/Put.java b/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hdfs/Put.java
index 733185a..f48b40b 100644
--- a/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hdfs/Put.java
+++ b/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hdfs/Put.java
@@ -91,6 +91,7 @@ class Put {
       return this;
     }
 
+    @Override
     protected Callable<Response> callable() {
       return new Callable<Response>() {
         @Override

http://git-wip-us.apache.org/repos/asf/knox/blob/c4b35aaf/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hdfs/Rename.java
----------------------------------------------------------------------
diff --git a/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hdfs/Rename.java b/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hdfs/Rename.java
index af85643..cec30e5 100644
--- a/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hdfs/Rename.java
+++ b/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hdfs/Rename.java
@@ -47,6 +47,7 @@ public class Rename {
       return this;
     }
 
+    @Override
     protected Callable<Rename.Response> callable() {
       return new Callable<Rename.Response>() {
         @Override

http://git-wip-us.apache.org/repos/asf/knox/blob/c4b35aaf/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hdfs/Rm.java
----------------------------------------------------------------------
diff --git a/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hdfs/Rm.java b/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hdfs/Rm.java
index 4076da3..52f3a88 100644
--- a/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hdfs/Rm.java
+++ b/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hdfs/Rm.java
@@ -52,6 +52,7 @@ class Rm {
       return recursive( true );
     }
 
+    @Override
     public Callable<Response> callable() {
       return new Callable<Response>() {
         @Override

http://git-wip-us.apache.org/repos/asf/knox/blob/c4b35aaf/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hdfs/Status.java
----------------------------------------------------------------------
diff --git a/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hdfs/Status.java b/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hdfs/Status.java
index e49ba8e..7c5836f 100644
--- a/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hdfs/Status.java
+++ b/gateway-shell/src/main/java/org/apache/knox/gateway/shell/hdfs/Status.java
@@ -42,6 +42,7 @@ public class Status {
       return this;
     }
 
+    @Override
     public Callable<Response> callable() {
       return new Callable<Response>() {
         @Override

http://git-wip-us.apache.org/repos/asf/knox/blob/c4b35aaf/gateway-shell/src/main/java/org/apache/knox/gateway/shell/job/Hive.java
----------------------------------------------------------------------
diff --git a/gateway-shell/src/main/java/org/apache/knox/gateway/shell/job/Hive.java b/gateway-shell/src/main/java/org/apache/knox/gateway/shell/job/Hive.java
index 2ac0dd9..bb2714a 100644
--- a/gateway-shell/src/main/java/org/apache/knox/gateway/shell/job/Hive.java
+++ b/gateway-shell/src/main/java/org/apache/knox/gateway/shell/job/Hive.java
@@ -65,6 +65,7 @@ public class Hive {
       return this;
     }
 
+    @Override
     protected Callable<Response> callable() {
       return new Callable<Response>() {
         @Override

http://git-wip-us.apache.org/repos/asf/knox/blob/c4b35aaf/gateway-shell/src/main/java/org/apache/knox/gateway/shell/job/Java.java
----------------------------------------------------------------------
diff --git a/gateway-shell/src/main/java/org/apache/knox/gateway/shell/job/Java.java b/gateway-shell/src/main/java/org/apache/knox/gateway/shell/job/Java.java
index 69b50ed..72801fc 100644
--- a/gateway-shell/src/main/java/org/apache/knox/gateway/shell/job/Java.java
+++ b/gateway-shell/src/main/java/org/apache/knox/gateway/shell/job/Java.java
@@ -72,6 +72,7 @@ class Java {
       return this;
     }
 
+    @Override
     protected Callable<Response> callable() {
       return new Callable<Response>() {
         @Override

http://git-wip-us.apache.org/repos/asf/knox/blob/c4b35aaf/gateway-shell/src/main/java/org/apache/knox/gateway/shell/job/Pig.java
----------------------------------------------------------------------
diff --git a/gateway-shell/src/main/java/org/apache/knox/gateway/shell/job/Pig.java b/gateway-shell/src/main/java/org/apache/knox/gateway/shell/job/Pig.java
index 77383a5..69033b6 100644
--- a/gateway-shell/src/main/java/org/apache/knox/gateway/shell/job/Pig.java
+++ b/gateway-shell/src/main/java/org/apache/knox/gateway/shell/job/Pig.java
@@ -65,6 +65,7 @@ public class Pig {
       return this;
     }
 
+    @Override
     protected Callable<Response> callable() {
       return new Callable<Response>() {
         @Override

http://git-wip-us.apache.org/repos/asf/knox/blob/c4b35aaf/gateway-shell/src/main/java/org/apache/knox/gateway/shell/job/Queue.java
----------------------------------------------------------------------
diff --git a/gateway-shell/src/main/java/org/apache/knox/gateway/shell/job/Queue.java b/gateway-shell/src/main/java/org/apache/knox/gateway/shell/job/Queue.java
index 79ac9f2..07081eb 100644
--- a/gateway-shell/src/main/java/org/apache/knox/gateway/shell/job/Queue.java
+++ b/gateway-shell/src/main/java/org/apache/knox/gateway/shell/job/Queue.java
@@ -34,6 +34,7 @@ class Queue {
       super( session );
     }
 
+    @Override
     protected Callable<Response> callable() {
       return new Callable<Response>() {
         @Override

http://git-wip-us.apache.org/repos/asf/knox/blob/c4b35aaf/gateway-shell/src/main/java/org/apache/knox/gateway/shell/job/Sqoop.java
----------------------------------------------------------------------
diff --git a/gateway-shell/src/main/java/org/apache/knox/gateway/shell/job/Sqoop.java b/gateway-shell/src/main/java/org/apache/knox/gateway/shell/job/Sqoop.java
index 030b0c1..e58cf7e 100644
--- a/gateway-shell/src/main/java/org/apache/knox/gateway/shell/job/Sqoop.java
+++ b/gateway-shell/src/main/java/org/apache/knox/gateway/shell/job/Sqoop.java
@@ -68,6 +68,7 @@ public class Sqoop {
       return this;
     }
 
+    @Override
     protected Callable<Response> callable() {
       return new Callable<Response>() {
         @Override

http://git-wip-us.apache.org/repos/asf/knox/blob/c4b35aaf/gateway-shell/src/main/java/org/apache/knox/gateway/shell/job/Status.java
----------------------------------------------------------------------
diff --git a/gateway-shell/src/main/java/org/apache/knox/gateway/shell/job/Status.java b/gateway-shell/src/main/java/org/apache/knox/gateway/shell/job/Status.java
index 52bf296..2a1a9ae 100644
--- a/gateway-shell/src/main/java/org/apache/knox/gateway/shell/job/Status.java
+++ b/gateway-shell/src/main/java/org/apache/knox/gateway/shell/job/Status.java
@@ -41,6 +41,7 @@ class Status {
       return this;
     }
 
+    @Override
     protected Callable<Response> callable() {
       return new Callable<Response>() {
         @Override

http://git-wip-us.apache.org/repos/asf/knox/blob/c4b35aaf/gateway-shell/src/main/java/org/apache/knox/gateway/shell/knox/token/Get.java
----------------------------------------------------------------------
diff --git a/gateway-shell/src/main/java/org/apache/knox/gateway/shell/knox/token/Get.java b/gateway-shell/src/main/java/org/apache/knox/gateway/shell/knox/token/Get.java
index cf7ab19..fe1aa77 100644
--- a/gateway-shell/src/main/java/org/apache/knox/gateway/shell/knox/token/Get.java
+++ b/gateway-shell/src/main/java/org/apache/knox/gateway/shell/knox/token/Get.java
@@ -37,6 +37,7 @@ public class Get {
       super(session);
     }
 
+    @Override
     protected Callable<Response> callable() {
       return new Callable<Response>() {
         @Override

http://git-wip-us.apache.org/repos/asf/knox/blob/c4b35aaf/gateway-shell/src/main/java/org/apache/knox/gateway/shell/workflow/Status.java
----------------------------------------------------------------------
diff --git a/gateway-shell/src/main/java/org/apache/knox/gateway/shell/workflow/Status.java b/gateway-shell/src/main/java/org/apache/knox/gateway/shell/workflow/Status.java
index 2c5612e..0e3725a 100644
--- a/gateway-shell/src/main/java/org/apache/knox/gateway/shell/workflow/Status.java
+++ b/gateway-shell/src/main/java/org/apache/knox/gateway/shell/workflow/Status.java
@@ -41,6 +41,7 @@ class Status {
       return this;
     }
 
+    @Override
     protected Callable<Response> callable() {
       return new Callable<Response>() {
         @Override

http://git-wip-us.apache.org/repos/asf/knox/blob/c4b35aaf/gateway-shell/src/main/java/org/apache/knox/gateway/shell/workflow/Submit.java
----------------------------------------------------------------------
diff --git a/gateway-shell/src/main/java/org/apache/knox/gateway/shell/workflow/Submit.java b/gateway-shell/src/main/java/org/apache/knox/gateway/shell/workflow/Submit.java
index d22d85e..cf860b0 100644
--- a/gateway-shell/src/main/java/org/apache/knox/gateway/shell/workflow/Submit.java
+++ b/gateway-shell/src/main/java/org/apache/knox/gateway/shell/workflow/Submit.java
@@ -61,6 +61,7 @@ class Submit {
       return this;
     }
 
+    @Override
     protected Callable<Response> callable() {
       return new Callable<Response>() {
         @Override

http://git-wip-us.apache.org/repos/asf/knox/blob/c4b35aaf/gateway-shell/src/main/java/org/apache/knox/gateway/shell/yarn/SubmitApp.java
----------------------------------------------------------------------
diff --git a/gateway-shell/src/main/java/org/apache/knox/gateway/shell/yarn/SubmitApp.java b/gateway-shell/src/main/java/org/apache/knox/gateway/shell/yarn/SubmitApp.java
index 65e7f1e..9605b38 100644
--- a/gateway-shell/src/main/java/org/apache/knox/gateway/shell/yarn/SubmitApp.java
+++ b/gateway-shell/src/main/java/org/apache/knox/gateway/shell/yarn/SubmitApp.java
@@ -52,6 +52,7 @@ public class SubmitApp {
             return this;
         }
 
+        @Override
         protected Callable<Response> callable() {
             return new Callable<Response>() {
                 @Override

http://git-wip-us.apache.org/repos/asf/knox/blob/c4b35aaf/gateway-spi/src/main/java/org/apache/knox/gateway/deploy/ProviderDeploymentContributorBase.java
----------------------------------------------------------------------
diff --git a/gateway-spi/src/main/java/org/apache/knox/gateway/deploy/ProviderDeploymentContributorBase.java b/gateway-spi/src/main/java/org/apache/knox/gateway/deploy/ProviderDeploymentContributorBase.java
index 68798ef..f796dc6 100644
--- a/gateway-spi/src/main/java/org/apache/knox/gateway/deploy/ProviderDeploymentContributorBase.java
+++ b/gateway-spi/src/main/java/org/apache/knox/gateway/deploy/ProviderDeploymentContributorBase.java
@@ -21,15 +21,18 @@ import org.apache.knox.gateway.topology.Provider;
 
 public abstract class ProviderDeploymentContributorBase extends DeploymentContributorBase implements ProviderDeploymentContributor {
 
-  public void initializeContribution( DeploymentContext context ) {
+  @Override
+  public void initializeContribution(DeploymentContext context ) {
     // Noop.
   }
 
-  public void contributeProvider( DeploymentContext context, Provider provider ) {
+  @Override
+  public void contributeProvider(DeploymentContext context, Provider provider ) {
     // Noop.
   }
 
-  public void finalizeContribution( DeploymentContext context ) {
+  @Override
+  public void finalizeContribution(DeploymentContext context ) {
     // Noop.
   }
 

http://git-wip-us.apache.org/repos/asf/knox/blob/c4b35aaf/gateway-spi/src/main/java/org/apache/knox/gateway/deploy/ServiceDeploymentContributorBase.java
----------------------------------------------------------------------
diff --git a/gateway-spi/src/main/java/org/apache/knox/gateway/deploy/ServiceDeploymentContributorBase.java b/gateway-spi/src/main/java/org/apache/knox/gateway/deploy/ServiceDeploymentContributorBase.java
index 1102f49..f4d8fb6 100644
--- a/gateway-spi/src/main/java/org/apache/knox/gateway/deploy/ServiceDeploymentContributorBase.java
+++ b/gateway-spi/src/main/java/org/apache/knox/gateway/deploy/ServiceDeploymentContributorBase.java
@@ -34,11 +34,13 @@ public abstract class ServiceDeploymentContributorBase extends DeploymentContrib
     return new Version();
   }
 
-  public void initializeContribution( DeploymentContext context ) {
+  @Override
+  public void initializeContribution(DeploymentContext context ) {
     // Noop.
   }
 
-  public void finalizeContribution( DeploymentContext context ) {
+  @Override
+  public void finalizeContribution(DeploymentContext context ) {
     // Noop.
   }
 

http://git-wip-us.apache.org/repos/asf/knox/blob/c4b35aaf/gateway-spi/src/main/java/org/apache/knox/gateway/dispatch/AbstractGatewayDispatch.java
----------------------------------------------------------------------
diff --git a/gateway-spi/src/main/java/org/apache/knox/gateway/dispatch/AbstractGatewayDispatch.java b/gateway-spi/src/main/java/org/apache/knox/gateway/dispatch/AbstractGatewayDispatch.java
index cef53be..00c16e2 100644
--- a/gateway-spi/src/main/java/org/apache/knox/gateway/dispatch/AbstractGatewayDispatch.java
+++ b/gateway-spi/src/main/java/org/apache/knox/gateway/dispatch/AbstractGatewayDispatch.java
@@ -90,27 +90,32 @@ public abstract class AbstractGatewayDispatch implements Dispatch {
     return url;
   }
 
-  public void doGet( URI url, HttpServletRequest request, HttpServletResponse response )
+  @Override
+  public void doGet(URI url, HttpServletRequest request, HttpServletResponse response )
       throws IOException, URISyntaxException {
     response.sendError( HttpServletResponse.SC_METHOD_NOT_ALLOWED );
   }
 
-  public void doPost( URI url, HttpServletRequest request, HttpServletResponse response )
+  @Override
+  public void doPost(URI url, HttpServletRequest request, HttpServletResponse response )
       throws IOException, URISyntaxException {
     response.sendError( HttpServletResponse.SC_METHOD_NOT_ALLOWED );
   }
 
-  public void doPut( URI url, HttpServletRequest request, HttpServletResponse response )
+  @Override
+  public void doPut(URI url, HttpServletRequest request, HttpServletResponse response )
       throws IOException, URISyntaxException {
     response.sendError( HttpServletResponse.SC_METHOD_NOT_ALLOWED );
   }
 
-  public void doDelete( URI url, HttpServletRequest request, HttpServletResponse response )
+  @Override
+  public void doDelete(URI url, HttpServletRequest request, HttpServletResponse response )
       throws IOException, URISyntaxException {
     response.sendError( HttpServletResponse.SC_METHOD_NOT_ALLOWED );
   }
 
-  public void doOptions( URI url, HttpServletRequest request, HttpServletResponse response )
+  @Override
+  public void doOptions(URI url, HttpServletRequest request, HttpServletResponse response )
       throws IOException, URISyntaxException {
     response.sendError( HttpServletResponse.SC_METHOD_NOT_ALLOWED );
   }
@@ -118,7 +123,8 @@ public abstract class AbstractGatewayDispatch implements Dispatch {
   /**
    * @since 0.14.0
    */
-  public void doHead( URI url, HttpServletRequest request, HttpServletResponse response )
+  @Override
+  public void doHead(URI url, HttpServletRequest request, HttpServletResponse response )
       throws IOException, URISyntaxException {
     response.sendError( HttpServletResponse.SC_METHOD_NOT_ALLOWED );
   }

http://git-wip-us.apache.org/repos/asf/knox/blob/c4b35aaf/gateway-spi/src/main/java/org/apache/knox/gateway/dispatch/CappedBufferHttpEntity.java
----------------------------------------------------------------------
diff --git a/gateway-spi/src/main/java/org/apache/knox/gateway/dispatch/CappedBufferHttpEntity.java b/gateway-spi/src/main/java/org/apache/knox/gateway/dispatch/CappedBufferHttpEntity.java
index b7f104f..8e5d455 100644
--- a/gateway-spi/src/main/java/org/apache/knox/gateway/dispatch/CappedBufferHttpEntity.java
+++ b/gateway-spi/src/main/java/org/apache/knox/gateway/dispatch/CappedBufferHttpEntity.java
@@ -121,7 +121,8 @@ public class CappedBufferHttpEntity extends HttpEntityWrapper {
       return b;
     }
 
-    public int read( byte[] buffer, int offset, int limit ) throws IOException {
+    @Override
+    public int read(byte[] buffer, int offset, int limit ) throws IOException {
       int count = -1;
       // If we can read from the buffer do so.
       if( replayReadIndex < replayWriteIndex ) {

http://git-wip-us.apache.org/repos/asf/knox/blob/c4b35aaf/gateway-spi/src/main/java/org/apache/knox/gateway/dispatch/DefaultHttpClientFactory.java
----------------------------------------------------------------------
diff --git a/gateway-spi/src/main/java/org/apache/knox/gateway/dispatch/DefaultHttpClientFactory.java b/gateway-spi/src/main/java/org/apache/knox/gateway/dispatch/DefaultHttpClientFactory.java
index 29a66de..fd69e74 100644
--- a/gateway-spi/src/main/java/org/apache/knox/gateway/dispatch/DefaultHttpClientFactory.java
+++ b/gateway-spi/src/main/java/org/apache/knox/gateway/dispatch/DefaultHttpClientFactory.java
@@ -196,10 +196,12 @@ public class DefaultHttpClientFactory implements HttpClientFactory {
 
   private static class UseJaasCredentials implements Credentials {
 
+    @Override
     public String getPassword() {
       return null;
     }
 
+    @Override
     public Principal getUserPrincipal() {
       return null;
     }

http://git-wip-us.apache.org/repos/asf/knox/blob/c4b35aaf/gateway-spi/src/main/java/org/apache/knox/gateway/dispatch/GatewayDispatchFilter.java
----------------------------------------------------------------------
diff --git a/gateway-spi/src/main/java/org/apache/knox/gateway/dispatch/GatewayDispatchFilter.java b/gateway-spi/src/main/java/org/apache/knox/gateway/dispatch/GatewayDispatchFilter.java
index 216ff6e..5f6611f 100644
--- a/gateway-spi/src/main/java/org/apache/knox/gateway/dispatch/GatewayDispatchFilter.java
+++ b/gateway-spi/src/main/java/org/apache/knox/gateway/dispatch/GatewayDispatchFilter.java
@@ -167,6 +167,7 @@ public class GatewayDispatchFilter extends AbstractGatewayFilter {
   }
 
   private static class GetAdapter implements Adapter {
+    @Override
     public void doMethod(Dispatch dispatch, HttpServletRequest request, HttpServletResponse response)
         throws IOException, ServletException, URISyntaxException {
       dispatch.doGet( dispatch.getDispatchUrl(request), request, response);
@@ -174,6 +175,7 @@ public class GatewayDispatchFilter extends AbstractGatewayFilter {
   }
 
   private static class PostAdapter implements Adapter {
+    @Override
     public void doMethod(Dispatch dispatch, HttpServletRequest request, HttpServletResponse response)
         throws IOException, ServletException, URISyntaxException {
       dispatch.doPost( dispatch.getDispatchUrl(request), request, response);
@@ -181,6 +183,7 @@ public class GatewayDispatchFilter extends AbstractGatewayFilter {
   }
 
   private static class PutAdapter implements Adapter {
+    @Override
     public void doMethod(Dispatch dispatch, HttpServletRequest request, HttpServletResponse response)
         throws IOException, ServletException, URISyntaxException {
       dispatch.doPut( dispatch.getDispatchUrl(request), request, response);
@@ -188,6 +191,7 @@ public class GatewayDispatchFilter extends AbstractGatewayFilter {
   }
 
   private static class DeleteAdapter implements Adapter {
+    @Override
     public void doMethod(Dispatch dispatch, HttpServletRequest request, HttpServletResponse response)
         throws IOException, ServletException, URISyntaxException {
       dispatch.doDelete( dispatch.getDispatchUrl(request), request, response);
@@ -195,6 +199,7 @@ public class GatewayDispatchFilter extends AbstractGatewayFilter {
   }
 
   private static class OptionsAdapter implements Adapter {
+    @Override
     public void doMethod(Dispatch dispatch, HttpServletRequest request, HttpServletResponse response)
         throws IOException, ServletException, URISyntaxException {
       dispatch.doOptions( dispatch.getDispatchUrl(request), request, response);
@@ -202,6 +207,7 @@ public class GatewayDispatchFilter extends AbstractGatewayFilter {
   }
 
   private static class HeadAdapter implements Adapter {
+    @Override
     public void doMethod(Dispatch dispatch, HttpServletRequest request, HttpServletResponse response)
         throws IOException, ServletException, URISyntaxException {
       dispatch.doHead( dispatch.getDispatchUrl(request), request, response);

http://git-wip-us.apache.org/repos/asf/knox/blob/c4b35aaf/gateway-spi/src/main/java/org/apache/knox/gateway/dispatch/HadoopAuthCookieStore.java
----------------------------------------------------------------------
diff --git a/gateway-spi/src/main/java/org/apache/knox/gateway/dispatch/HadoopAuthCookieStore.java b/gateway-spi/src/main/java/org/apache/knox/gateway/dispatch/HadoopAuthCookieStore.java
index 44b3390..b8aa618 100644
--- a/gateway-spi/src/main/java/org/apache/knox/gateway/dispatch/HadoopAuthCookieStore.java
+++ b/gateway-spi/src/main/java/org/apache/knox/gateway/dispatch/HadoopAuthCookieStore.java
@@ -184,8 +184,10 @@ public class HadoopAuthCookieStore extends BasicCookieStore {
       return delegate.isExpired( date );
     }
 
+    @Override
     public String toString() {
       return (new ReflectionToStringBuilder(this) {
+        @Override
         protected boolean accept(Field f) {
           return super.accept(f) && !f.getName().equals("delegate");
         }

http://git-wip-us.apache.org/repos/asf/knox/blob/c4b35aaf/gateway-spi/src/main/java/org/apache/knox/gateway/dispatch/InputStreamEntity.java
----------------------------------------------------------------------
diff --git a/gateway-spi/src/main/java/org/apache/knox/gateway/dispatch/InputStreamEntity.java b/gateway-spi/src/main/java/org/apache/knox/gateway/dispatch/InputStreamEntity.java
index 2b231c9..e1975aa 100644
--- a/gateway-spi/src/main/java/org/apache/knox/gateway/dispatch/InputStreamEntity.java
+++ b/gateway-spi/src/main/java/org/apache/knox/gateway/dispatch/InputStreamEntity.java
@@ -94,6 +94,7 @@ public class InputStreamEntity extends AbstractHttpEntity {
     }
   }
 
+  @Override
   public boolean isRepeatable() {
     return false;
   }
@@ -101,10 +102,12 @@ public class InputStreamEntity extends AbstractHttpEntity {
   /**
    * @return the content length or {@code -1} if unknown
    */
+  @Override
   public long getContentLength() {
     return this.length;
   }
 
+  @Override
   public InputStream getContent() throws IOException {
     return this.content;
   }
@@ -115,7 +118,8 @@ public class InputStreamEntity extends AbstractHttpEntity {
    * determines how many bytes are written.  If the length is unknown ({@code -1}), the
    * stream will be completely consumed (to the end of the stream).
    */
-  public void writeTo( final OutputStream outstream ) throws IOException {
+  @Override
+  public void writeTo(final OutputStream outstream ) throws IOException {
     Args.notNull( outstream, "Output stream" );
     final InputStream instream = this.content;
     try {
@@ -143,6 +147,7 @@ public class InputStreamEntity extends AbstractHttpEntity {
     }
   }
 
+  @Override
   public boolean isStreaming() {
     return true;
   }

http://git-wip-us.apache.org/repos/asf/knox/blob/c4b35aaf/gateway-spi/src/main/java/org/apache/knox/gateway/dispatch/KnoxSpnegoAuthSchemeFactory.java
----------------------------------------------------------------------
diff --git a/gateway-spi/src/main/java/org/apache/knox/gateway/dispatch/KnoxSpnegoAuthSchemeFactory.java b/gateway-spi/src/main/java/org/apache/knox/gateway/dispatch/KnoxSpnegoAuthSchemeFactory.java
index 6c730a1..0e4145a 100644
--- a/gateway-spi/src/main/java/org/apache/knox/gateway/dispatch/KnoxSpnegoAuthSchemeFactory.java
+++ b/gateway-spi/src/main/java/org/apache/knox/gateway/dispatch/KnoxSpnegoAuthSchemeFactory.java
@@ -31,7 +31,8 @@ public class KnoxSpnegoAuthSchemeFactory extends SPNegoSchemeFactory {
     super();
   }
 
-  public AuthScheme newInstance( final HttpParams params ) {
+  @Override
+  public AuthScheme newInstance(final HttpParams params ) {
     return new KnoxSpnegoAuthScheme( isStripPort() );
   }
 

http://git-wip-us.apache.org/repos/asf/knox/blob/c4b35aaf/gateway-spi/src/main/java/org/apache/knox/gateway/dispatch/PartiallyRepeatableHttpEntity.java
----------------------------------------------------------------------
diff --git a/gateway-spi/src/main/java/org/apache/knox/gateway/dispatch/PartiallyRepeatableHttpEntity.java b/gateway-spi/src/main/java/org/apache/knox/gateway/dispatch/PartiallyRepeatableHttpEntity.java
index a882e02..b9c18ed 100644
--- a/gateway-spi/src/main/java/org/apache/knox/gateway/dispatch/PartiallyRepeatableHttpEntity.java
+++ b/gateway-spi/src/main/java/org/apache/knox/gateway/dispatch/PartiallyRepeatableHttpEntity.java
@@ -129,7 +129,8 @@ public class PartiallyRepeatableHttpEntity extends HttpEntityWrapper {
       return b;
     }
 
-    public int read( byte[] buffer, int offset, int limit ) throws IOException {
+    @Override
+    public int read(byte[] buffer, int offset, int limit ) throws IOException {
       int count = -1;
       if( finalStream != null && finalStream != this ) {
         throw new IOException( "Replay stream taken over by another consumer." );

http://git-wip-us.apache.org/repos/asf/knox/blob/c4b35aaf/gateway-spi/src/main/java/org/apache/knox/gateway/dispatch/PassAllHeadersNoEncodingDispatch.java
----------------------------------------------------------------------
diff --git a/gateway-spi/src/main/java/org/apache/knox/gateway/dispatch/PassAllHeadersNoEncodingDispatch.java b/gateway-spi/src/main/java/org/apache/knox/gateway/dispatch/PassAllHeadersNoEncodingDispatch.java
index 928857c..e947057 100644
--- a/gateway-spi/src/main/java/org/apache/knox/gateway/dispatch/PassAllHeadersNoEncodingDispatch.java
+++ b/gateway-spi/src/main/java/org/apache/knox/gateway/dispatch/PassAllHeadersNoEncodingDispatch.java
@@ -30,7 +30,8 @@ import javax.servlet.http.HttpServletRequest;
    * UIs may require this at some point as well.
    */
 public class PassAllHeadersNoEncodingDispatch extends PassAllHeadersDispatch {
-  public URI getDispatchUrl( HttpServletRequest request) {
+  @Override
+  public URI getDispatchUrl(HttpServletRequest request) {
     String base = request.getRequestURI();
     StringBuffer str = new StringBuffer();
     str.append( base );

http://git-wip-us.apache.org/repos/asf/knox/blob/c4b35aaf/gateway-spi/src/main/java/org/apache/knox/gateway/filter/security/AbstractIdentityAssertionFilter.java
----------------------------------------------------------------------
diff --git a/gateway-spi/src/main/java/org/apache/knox/gateway/filter/security/AbstractIdentityAssertionFilter.java b/gateway-spi/src/main/java/org/apache/knox/gateway/filter/security/AbstractIdentityAssertionFilter.java
index 76a8db5..f0cca53 100644
--- a/gateway-spi/src/main/java/org/apache/knox/gateway/filter/security/AbstractIdentityAssertionFilter.java
+++ b/gateway-spi/src/main/java/org/apache/knox/gateway/filter/security/AbstractIdentityAssertionFilter.java
@@ -66,6 +66,7 @@ public abstract class AbstractIdentityAssertionFilter extends AbstractIdentityAs
     loadPrincipalMappings(filterConfig);
   }
 
+  @Override
   public void destroy() {
     
   }

http://git-wip-us.apache.org/repos/asf/knox/blob/c4b35aaf/gateway-spi/src/main/java/org/apache/knox/gateway/security/GroupPrincipal.java
----------------------------------------------------------------------
diff --git a/gateway-spi/src/main/java/org/apache/knox/gateway/security/GroupPrincipal.java b/gateway-spi/src/main/java/org/apache/knox/gateway/security/GroupPrincipal.java
index 30c8f92..485356f 100644
--- a/gateway-spi/src/main/java/org/apache/knox/gateway/security/GroupPrincipal.java
+++ b/gateway-spi/src/main/java/org/apache/knox/gateway/security/GroupPrincipal.java
@@ -26,6 +26,7 @@ public class GroupPrincipal implements Principal {
     this.name = name;
   }
   
+  @Override
   public String getName() {
     return name;
   }

http://git-wip-us.apache.org/repos/asf/knox/blob/c4b35aaf/gateway-spi/src/main/java/org/apache/knox/gateway/security/PrimaryPrincipal.java
----------------------------------------------------------------------
diff --git a/gateway-spi/src/main/java/org/apache/knox/gateway/security/PrimaryPrincipal.java b/gateway-spi/src/main/java/org/apache/knox/gateway/security/PrimaryPrincipal.java
index 9212c28..cfa6518 100644
--- a/gateway-spi/src/main/java/org/apache/knox/gateway/security/PrimaryPrincipal.java
+++ b/gateway-spi/src/main/java/org/apache/knox/gateway/security/PrimaryPrincipal.java
@@ -26,6 +26,7 @@ public class PrimaryPrincipal implements Principal {
     this.name = name;
   }
   
+  @Override
   public String getName() {
     return name;
   }

http://git-wip-us.apache.org/repos/asf/knox/blob/c4b35aaf/gateway-spi/src/main/java/org/apache/knox/gateway/services/security/token/impl/JWTToken.java
----------------------------------------------------------------------
diff --git a/gateway-spi/src/main/java/org/apache/knox/gateway/services/security/token/impl/JWTToken.java b/gateway-spi/src/main/java/org/apache/knox/gateway/services/security/token/impl/JWTToken.java
index f714ccc..da8bfe3 100644
--- a/gateway-spi/src/main/java/org/apache/knox/gateway/services/security/token/impl/JWTToken.java
+++ b/gateway-spi/src/main/java/org/apache/knox/gateway/services/security/token/impl/JWTToken.java
@@ -103,6 +103,7 @@ public class JWTToken implements JWT {
     return payload.toString();
   }
 
+  @Override
   public String toString() {
     return jwt.serialize();
   }
@@ -222,6 +223,7 @@ public class JWTToken implements JWT {
     }
   }
 
+  @Override
   public boolean verify(JWSVerifier verifier) {
     boolean rc = false;
 

http://git-wip-us.apache.org/repos/asf/knox/blob/c4b35aaf/gateway-spi/src/main/java/org/apache/knox/gateway/topology/Application.java
----------------------------------------------------------------------
diff --git a/gateway-spi/src/main/java/org/apache/knox/gateway/topology/Application.java b/gateway-spi/src/main/java/org/apache/knox/gateway/topology/Application.java
index a95792a..ad44f31 100644
--- a/gateway-spi/src/main/java/org/apache/knox/gateway/topology/Application.java
+++ b/gateway-spi/src/main/java/org/apache/knox/gateway/topology/Application.java
@@ -19,11 +19,13 @@ package org.apache.knox.gateway.topology;
 
 public class Application extends Service {
 
+  @Override
   public String getRole() {
     return getName();
   }
 
-  public void setRole( String role ) {
+  @Override
+  public void setRole(String role ) {
     setName( role );
   }
 

http://git-wip-us.apache.org/repos/asf/knox/blob/c4b35aaf/gateway-spi/src/test/java/org/apache/knox/gateway/services/security/impl/CMFKeystoreServiceTest.java
----------------------------------------------------------------------
diff --git a/gateway-spi/src/test/java/org/apache/knox/gateway/services/security/impl/CMFKeystoreServiceTest.java b/gateway-spi/src/test/java/org/apache/knox/gateway/services/security/impl/CMFKeystoreServiceTest.java
index b7109d6..dd0584b 100644
--- a/gateway-spi/src/test/java/org/apache/knox/gateway/services/security/impl/CMFKeystoreServiceTest.java
+++ b/gateway-spi/src/test/java/org/apache/knox/gateway/services/security/impl/CMFKeystoreServiceTest.java
@@ -61,6 +61,7 @@ public class CMFKeystoreServiceTest {
 
         public void stop() throws ServiceLifecycleException {}
 
+        @Override
         public char[] getMasterSecret() {
           return "testmaster".toCharArray();
         }

http://git-wip-us.apache.org/repos/asf/knox/blob/c4b35aaf/gateway-test-release-utils/src/main/java/org/apache/knox/gateway/GatewayTestConfig.java
----------------------------------------------------------------------
diff --git a/gateway-test-release-utils/src/main/java/org/apache/knox/gateway/GatewayTestConfig.java b/gateway-test-release-utils/src/main/java/org/apache/knox/gateway/GatewayTestConfig.java
index bd50e07..c4a71a0 100644
--- a/gateway-test-release-utils/src/main/java/org/apache/knox/gateway/GatewayTestConfig.java
+++ b/gateway-test-release-utils/src/main/java/org/apache/knox/gateway/GatewayTestConfig.java
@@ -130,6 +130,7 @@ public class GatewayTestConfig extends Configuration implements GatewayConfig {
     return new InetSocketAddress( getGatewayHost(), getGatewayPort() );
   }
 
+  @Override
   public long getGatewayIdleTimeout() {
     return 0l;
   }
@@ -347,6 +348,7 @@ public class GatewayTestConfig extends Configuration implements GatewayConfig {
     backupVersionLimit = newBackupVersionLimit;
   }
 
+  @Override
   public int getGatewayDeploymentsBackupVersionLimit() {
     return backupVersionLimit;
   }
@@ -611,6 +613,7 @@ public class GatewayTestConfig extends Configuration implements GatewayConfig {
     return null;
   }
 
+  @Override
   public String getDispatchWhitelist() {
     return null;
   }

http://git-wip-us.apache.org/repos/asf/knox/blob/c4b35aaf/gateway-test-utils/src/main/java/org/apache/knox/test/mock/MockRequestMatcher.java
----------------------------------------------------------------------
diff --git a/gateway-test-utils/src/main/java/org/apache/knox/test/mock/MockRequestMatcher.java b/gateway-test-utils/src/main/java/org/apache/knox/test/mock/MockRequestMatcher.java
index 46d3316..c2fe83e 100644
--- a/gateway-test-utils/src/main/java/org/apache/knox/test/mock/MockRequestMatcher.java
+++ b/gateway-test-utils/src/main/java/org/apache/knox/test/mock/MockRequestMatcher.java
@@ -320,6 +320,7 @@ public class MockRequestMatcher {
     }
   }
 
+  @Override
   public String toString() {
     return "from=" + from + ", pathInfo=" + pathInfo;
   }

http://git-wip-us.apache.org/repos/asf/knox/blob/c4b35aaf/gateway-test/src/test/java/org/apache/knox/gateway/GatewaySslFuncTest.java
----------------------------------------------------------------------
diff --git a/gateway-test/src/test/java/org/apache/knox/gateway/GatewaySslFuncTest.java b/gateway-test/src/test/java/org/apache/knox/gateway/GatewaySslFuncTest.java
index 52fc618..449cf5f 100644
--- a/gateway-test/src/test/java/org/apache/knox/gateway/GatewaySslFuncTest.java
+++ b/gateway-test/src/test/java/org/apache/knox/gateway/GatewaySslFuncTest.java
@@ -280,14 +280,17 @@ public class GatewaySslFuncTest {
 
   public static class TrustAllCerts implements X509TrustManager {
 
-    public void checkClientTrusted( X509Certificate[] x509Certificates, String s ) throws CertificateException {
+    @Override
+    public void checkClientTrusted(X509Certificate[] x509Certificates, String s ) throws CertificateException {
       // Trust all certificates.
     }
 
-    public void checkServerTrusted( X509Certificate[] x509Certificates, String s ) throws CertificateException {
+    @Override
+    public void checkServerTrusted(X509Certificate[] x509Certificates, String s ) throws CertificateException {
       // Trust all certificates.
     }
 
+    @Override
     public X509Certificate[] getAcceptedIssuers() {
       return null;
     }

http://git-wip-us.apache.org/repos/asf/knox/blob/c4b35aaf/gateway-util-common/src/main/java/org/apache/knox/gateway/audit/log4j/appender/JdbmStoreAndForwardAppender.java
----------------------------------------------------------------------
diff --git a/gateway-util-common/src/main/java/org/apache/knox/gateway/audit/log4j/appender/JdbmStoreAndForwardAppender.java b/gateway-util-common/src/main/java/org/apache/knox/gateway/audit/log4j/appender/JdbmStoreAndForwardAppender.java
index 98cb2ab..dac9290 100644
--- a/gateway-util-common/src/main/java/org/apache/knox/gateway/audit/log4j/appender/JdbmStoreAndForwardAppender.java
+++ b/gateway-util-common/src/main/java/org/apache/knox/gateway/audit/log4j/appender/JdbmStoreAndForwardAppender.java
@@ -91,6 +91,7 @@ public class JdbmStoreAndForwardAppender extends AppenderSkeleton {
 
   private class Forwarder extends Thread {
 
+    @Override
     public void run() {
       final AtomicBoolean done = new AtomicBoolean( false );
       while( !done.get() ) {

http://git-wip-us.apache.org/repos/asf/knox/blob/c4b35aaf/gateway-util-common/src/main/java/org/apache/knox/gateway/util/JsonPath.java
----------------------------------------------------------------------
diff --git a/gateway-util-common/src/main/java/org/apache/knox/gateway/util/JsonPath.java b/gateway-util-common/src/main/java/org/apache/knox/gateway/util/JsonPath.java
index fcfb972..c9d537e 100644
--- a/gateway-util-common/src/main/java/org/apache/knox/gateway/util/JsonPath.java
+++ b/gateway-util-common/src/main/java/org/apache/knox/gateway/util/JsonPath.java
@@ -72,6 +72,7 @@ public class JsonPath {
       return index;
     }
 
+    @Override
     public String toString() {
       StringBuilder s = new StringBuilder();
       s.append( "JsonPath{" );
@@ -312,6 +313,7 @@ public class JsonPath {
       }
     }
 
+    @Override
     public String toString() {
       StringBuilder s = new StringBuilder();
       s.append( "JsonPath.Expression{" );
@@ -368,6 +370,7 @@ public class JsonPath {
       return index;
     }
 
+    @Override
     public String toString() {
       StringBuilder s = new StringBuilder();
       s.append( "JsonPath.Segment{" );

http://git-wip-us.apache.org/repos/asf/knox/blob/c4b35aaf/gateway-util-common/src/test/java/org/apache/knox/gateway/audit/JdbmQueueTest.java
----------------------------------------------------------------------
diff --git a/gateway-util-common/src/test/java/org/apache/knox/gateway/audit/JdbmQueueTest.java b/gateway-util-common/src/test/java/org/apache/knox/gateway/audit/JdbmQueueTest.java
index 885ce55..47f1f92 100644
--- a/gateway-util-common/src/test/java/org/apache/knox/gateway/audit/JdbmQueueTest.java
+++ b/gateway-util-common/src/test/java/org/apache/knox/gateway/audit/JdbmQueueTest.java
@@ -214,6 +214,7 @@ public class JdbmQueueTest {
     public Producer( int iterations ) {
       this.iterations = iterations;
     }
+    @Override
     public void run() {
       try {
         for( int i = 0; i < iterations; i++ ) {
@@ -230,6 +231,7 @@ public class JdbmQueueTest {
     public Consumer( Set<String> consumed ) {
       this.consumed = consumed;
     }
+    @Override
     public void run() {
       try {
         while( true ) {
@@ -254,6 +256,7 @@ public class JdbmQueueTest {
     public Processor( Set<String> consumed ) {
       this.consumed = consumed;
     }
+    @Override
     public void run() {
       try {
         final AtomicBoolean done = new AtomicBoolean( false );

http://git-wip-us.apache.org/repos/asf/knox/blob/c4b35aaf/gateway-util-urltemplate/src/main/java/org/apache/knox/gateway/util/urltemplate/Matcher.java
----------------------------------------------------------------------
diff --git a/gateway-util-urltemplate/src/main/java/org/apache/knox/gateway/util/urltemplate/Matcher.java b/gateway-util-urltemplate/src/main/java/org/apache/knox/gateway/util/urltemplate/Matcher.java
index d307156..20e20f6 100644
--- a/gateway-util-urltemplate/src/main/java/org/apache/knox/gateway/util/urltemplate/Matcher.java
+++ b/gateway-util-urltemplate/src/main/java/org/apache/knox/gateway/util/urltemplate/Matcher.java
@@ -376,6 +376,7 @@ public class Matcher<V> {
 
     private Map<String,List<String>> map = new HashMap<>();
 
+    @Override
     public Set<String> getNames() {
       return map.keySet();
     }

http://git-wip-us.apache.org/repos/asf/knox/blob/c4b35aaf/gateway-util-urltemplate/src/main/java/org/apache/knox/gateway/util/urltemplate/MockParams.java
----------------------------------------------------------------------
diff --git a/gateway-util-urltemplate/src/main/java/org/apache/knox/gateway/util/urltemplate/MockParams.java b/gateway-util-urltemplate/src/main/java/org/apache/knox/gateway/util/urltemplate/MockParams.java
index a5c7dae..dbc06ee 100644
--- a/gateway-util-urltemplate/src/main/java/org/apache/knox/gateway/util/urltemplate/MockParams.java
+++ b/gateway-util-urltemplate/src/main/java/org/apache/knox/gateway/util/urltemplate/MockParams.java
@@ -27,6 +27,7 @@ public class MockParams implements Params {
 
   private Map<String,List<String>> map = new HashMap<>();
 
+  @Override
   public Set<String> getNames() {
     return map.keySet();
   }

http://git-wip-us.apache.org/repos/asf/knox/blob/c4b35aaf/gateway-util-urltemplate/src/main/java/org/apache/knox/gateway/util/urltemplate/Segment.java
----------------------------------------------------------------------
diff --git a/gateway-util-urltemplate/src/main/java/org/apache/knox/gateway/util/urltemplate/Segment.java b/gateway-util-urltemplate/src/main/java/org/apache/knox/gateway/util/urltemplate/Segment.java
index 61eb1d4..6e563b3 100644
--- a/gateway-util-urltemplate/src/main/java/org/apache/knox/gateway/util/urltemplate/Segment.java
+++ b/gateway-util-urltemplate/src/main/java/org/apache/knox/gateway/util/urltemplate/Segment.java
@@ -133,6 +133,7 @@ abstract class Segment {
 //    values.put( valuePattern, value );
 //  }
 
+  @Override
   public String toString() {
     StringBuilder s = new StringBuilder();
     s.append( getParamName() );
@@ -227,6 +228,7 @@ abstract class Segment {
       return regex;
     }
 
+    @Override
     public String toString() {
       return token.effectivePattern;
     }

http://git-wip-us.apache.org/repos/asf/knox/blob/c4b35aaf/gateway-util-urltemplate/src/main/java/org/apache/knox/gateway/util/urltemplate/Template.java
----------------------------------------------------------------------
diff --git a/gateway-util-urltemplate/src/main/java/org/apache/knox/gateway/util/urltemplate/Template.java b/gateway-util-urltemplate/src/main/java/org/apache/knox/gateway/util/urltemplate/Template.java
index 6ff732d..f284438 100644
--- a/gateway-util-urltemplate/src/main/java/org/apache/knox/gateway/util/urltemplate/Template.java
+++ b/gateway-util-urltemplate/src/main/java/org/apache/knox/gateway/util/urltemplate/Template.java
@@ -311,6 +311,7 @@ public class Template {
     }
   }
 
+  @Override
   public String toString() {
     String s = null;
     StringBuilder b = new StringBuilder();
@@ -323,6 +324,7 @@ public class Template {
     return s;
   }
 
+  @Override
   public int hashCode() {
     Integer hc = hash;
     if( hc == null ) {
@@ -332,7 +334,8 @@ public class Template {
     return hc.intValue();
   }
 
-  public boolean equals( Object object ) {
+  @Override
+  public boolean equals(Object object ) {
     boolean equals = false;
     if( object != null && object instanceof Template ) {
       String thisStr = toString();

http://git-wip-us.apache.org/repos/asf/knox/blob/c4b35aaf/gateway-util-urltemplate/src/test/java/org/apache/knox/gateway/util/urltemplate/RewriterTest.java
----------------------------------------------------------------------
diff --git a/gateway-util-urltemplate/src/test/java/org/apache/knox/gateway/util/urltemplate/RewriterTest.java b/gateway-util-urltemplate/src/test/java/org/apache/knox/gateway/util/urltemplate/RewriterTest.java
index 068493c..e8ea0b5 100644
--- a/gateway-util-urltemplate/src/test/java/org/apache/knox/gateway/util/urltemplate/RewriterTest.java
+++ b/gateway-util-urltemplate/src/test/java/org/apache/knox/gateway/util/urltemplate/RewriterTest.java
@@ -393,6 +393,7 @@ public class RewriterTest {
     }
 
     // Picks the values from either the expect or the config in that order.
+    @Override
     @SuppressWarnings( "unchecked" )
     public List<String> resolve( String name ) {
       List<String> values = null;

http://git-wip-us.apache.org/repos/asf/knox/blob/c4b35aaf/hadoop-examples/src/main/java/org/apache/knox/examples/WordCount.java
----------------------------------------------------------------------
diff --git a/hadoop-examples/src/main/java/org/apache/knox/examples/WordCount.java b/hadoop-examples/src/main/java/org/apache/knox/examples/WordCount.java
index 7021d7d..cecc23f 100644
--- a/hadoop-examples/src/main/java/org/apache/knox/examples/WordCount.java
+++ b/hadoop-examples/src/main/java/org/apache/knox/examples/WordCount.java
@@ -39,6 +39,7 @@ public class WordCount {
     private static final IntWritable one = new IntWritable(1);
     private Text word = new Text();
 
+    @Override
     public void map(Object key, Text value, Context context
     ) throws IOException, InterruptedException {
       StringTokenizer itr = new StringTokenizer(value.toString());
@@ -53,6 +54,7 @@ public class WordCount {
       extends Reducer<Text,IntWritable,Text,IntWritable> {
     private IntWritable result = new IntWritable();
 
+    @Override
     public void reduce(Text key, Iterable<IntWritable> values,
                        Context context
     ) throws IOException, InterruptedException {


Mime
View raw message