knox-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kris...@apache.org
Subject [knox] 01/02: KNOX-1786 - Use mocking to simplify DefaultRemoteConfigurationMonitorTest
Date Tue, 19 Feb 2019 20:43:21 GMT
This is an automated email from the ASF dual-hosted git repository.

krisden pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/knox.git

commit 6aa1759d108250ffd93ba809e7106705c081e8a2
Author: Kevin Risden <krisden@apache.org>
AuthorDate: Tue Feb 19 15:08:10 2019 -0500

    KNOX-1786 - Use mocking to simplify DefaultRemoteConfigurationMonitorTest
    
    Signed-off-by: Kevin Risden <krisden@apache.org>
---
 .../DefaultRemoteConfigurationMonitorTest.java     | 492 +--------------------
 1 file changed, 8 insertions(+), 484 deletions(-)

diff --git a/gateway-server/src/test/java/org/apache/knox/gateway/topology/monitor/DefaultRemoteConfigurationMonitorTest.java
b/gateway-server/src/test/java/org/apache/knox/gateway/topology/monitor/DefaultRemoteConfigurationMonitorTest.java
index 03e0f12..0d48828 100644
--- a/gateway-server/src/test/java/org/apache/knox/gateway/topology/monitor/DefaultRemoteConfigurationMonitorTest.java
+++ b/gateway-server/src/test/java/org/apache/knox/gateway/topology/monitor/DefaultRemoteConfigurationMonitorTest.java
@@ -17,497 +17,21 @@
 package org.apache.knox.gateway.topology.monitor;
 
 import org.apache.knox.gateway.config.GatewayConfig;
-import org.apache.knox.gateway.services.ServiceLifecycleException;
-import org.apache.knox.gateway.services.config.client.RemoteConfigurationRegistryClient;
 import org.apache.knox.gateway.services.config.client.RemoteConfigurationRegistryClientService;
-import org.apache.knox.gateway.services.security.AliasService;
+import org.easymock.EasyMock;
 import org.junit.Test;
 
-import java.net.InetSocketAddress;
-import java.net.UnknownHostException;
-import java.util.List;
-import java.util.Map;
-
-
 public class DefaultRemoteConfigurationMonitorTest {
-
   @Test(expected=IllegalStateException.class)
   public void testInitWithoutRequiredConfig() {
-    GatewayConfig testConfig = new TestGatewayConfig();
-    new DefaultRemoteConfigurationMonitor(testConfig, new TestRemoteConfigurationRegistryClientService());
-  }
-
-  private static class TestGatewayConfig implements GatewayConfig {
-    @Override
-    public String getGatewayConfDir() {
-      return null;
-    }
-
-    @Override
-    public String getGatewayDataDir() {
-      return null;
-    }
-
-    @Override
-    public String getGatewayServicesDir() {
-      return null;
-    }
-
-    @Override
-    public String getGatewayApplicationsDir() {
-      return null;
-    }
-
-    @Override
-    public String getHadoopConfDir() {
-      return null;
-    }
-
-    @Override
-    public String getGatewayHost() {
-      return null;
-    }
-
-    @Override
-    public int getGatewayPort() {
-      return 0;
-    }
-
-    @Override
-    public String getGatewayPath() {
-      return null;
-    }
-
-    @Override
-    public String getGatewayProvidersConfigDir() {
-      return "./shared-providers";
-    }
-
-    @Override
-    public String getGatewayDescriptorsDir() {
-      return "./descriptors";
-    }
-
-    @Override
-    public String getGatewayTopologyDir() {
-      return null;
-    }
-
-    @Override
-    public String getGatewaySecurityDir() {
-      return null;
-    }
-
-    @Override
-    public String getGatewayDeploymentDir() {
-      return null;
-    }
-
-    @Override
-    public InetSocketAddress getGatewayAddress() throws UnknownHostException {
-      return null;
-    }
-
-    @Override
-    public boolean isSSLEnabled() {
-      return false;
-    }
-
-    @Override
-    public List<String> getExcludedSSLProtocols() {
-      return null;
-    }
-
-    @Override
-    public List<String> getIncludedSSLCiphers() {
-      return null;
-    }
-
-    @Override
-    public List<String> getExcludedSSLCiphers() {
-      return null;
-    }
-
-    @Override
-    public boolean isHadoopKerberosSecured() {
-      return false;
-    }
-
-    @Override
-    public String getKerberosConfig() {
-      return null;
-    }
-
-    @Override
-    public boolean isKerberosDebugEnabled() {
-      return false;
-    }
-
-    @Override
-    public String getKerberosLoginConfig() {
-      return null;
-    }
-
-    @Override
-    public String getDefaultTopologyName() {
-      return null;
-    }
-
-    @Override
-    public String getDefaultAppRedirectPath() {
-      return null;
-    }
-
-    @Override
-    public String getFrontendUrl() {
-      return null;
-    }
-
-    @Override
-    public boolean isClientAuthNeeded() {
-      return false;
-    }
-
-    @Override
-    public boolean isClientAuthWanted() {
-      return false;
-    }
-
-    @Override
-    public String getTruststorePath() {
-      return null;
-    }
-
-    @Override
-    public boolean getTrustAllCerts() {
-      return false;
-    }
-
-    @Override
-    public String getKeystoreType() {
-      return null;
-    }
-
-    @Override
-    public String getTruststoreType() {
-      return null;
-    }
-
-    @Override
-    public boolean isXForwardedEnabled() {
-      return false;
-    }
-
-    @Override
-    public String getEphemeralDHKeySize() {
-      return null;
-    }
-
-    @Override
-    public int getHttpClientMaxConnections() {
-      return 0;
-    }
-
-    @Override
-    public int getHttpClientConnectionTimeout() {
-      return 0;
-    }
-
-    @Override
-    public int getHttpClientSocketTimeout() {
-      return 0;
-    }
-
-    @Override
-    public int getThreadPoolMax() {
-      return 0;
-    }
-
-    @Override
-    public int getHttpServerRequestBuffer() {
-      return 0;
-    }
-
-    @Override
-    public int getHttpServerRequestHeaderBuffer() {
-      return 0;
-    }
-
-    @Override
-    public int getHttpServerResponseBuffer() {
-      return 0;
-    }
-
-    @Override
-    public int getHttpServerResponseHeaderBuffer() {
-      return 0;
-    }
-
-    @Override
-    public int getGatewayDeploymentsBackupVersionLimit() {
-      return 0;
-    }
-
-    @Override
-    public long getGatewayDeploymentsBackupAgeLimit() {
-      return 0;
-    }
-
-    @Override
-    public long getGatewayIdleTimeout() {
-      return 0;
-    }
-
-    @Override
-    public String getSigningKeystoreName() {
-      return null;
-    }
-
-    @Override
-    public String getSigningKeyAlias() {
-      return null;
-    }
-
-    @Override
-    public List<String> getGlobalRulesServices() {
-      return null;
-    }
-
-    @Override
-    public boolean isWebsocketEnabled() {
-      return false;
-    }
-
-    @Override
-    public int getWebsocketMaxTextMessageSize() {
-      return 0;
-    }
-
-    @Override
-    public int getWebsocketMaxBinaryMessageSize() {
-      return 0;
-    }
-
-    @Override
-    public int getWebsocketMaxTextMessageBufferSize() {
-      return 0;
-    }
-
-    @Override
-    public int getWebsocketMaxBinaryMessageBufferSize() {
-      return 0;
-    }
-
-    @Override
-    public int getWebsocketInputBufferSize() {
-      return 0;
-    }
-
-    @Override
-    public int getWebsocketAsyncWriteTimeout() {
-      return 0;
-    }
-
-    @Override
-    public int getWebsocketIdleTimeout() {
-      return 0;
-    }
-
-    @Override
-    public boolean isMetricsEnabled() {
-      return false;
-    }
-
-    @Override
-    public boolean isJmxMetricsReportingEnabled() {
-      return false;
-    }
-
-    @Override
-    public boolean isGraphiteMetricsReportingEnabled() {
-      return false;
-    }
-
-    @Override
-    public String getGraphiteHost() {
-      return null;
-    }
-
-    @Override
-    public int getGraphitePort() {
-      return 0;
-    }
-
-    @Override
-    public int getGraphiteReportingFrequency() {
-      return 0;
-    }
-
-    @Override
-    public boolean isCookieScopingToPathEnabled() {
-      return false;
-    }
-
-    @Override
-    public String getHeaderNameForRemoteAddress() {
-      return null;
-    }
-
-    @Override
-    public String getAlgorithm() {
-      return null;
-    }
-
-    @Override
-    public String getPBEAlgorithm() {
-      return null;
-    }
-
-    @Override
-    public String getTransformation() {
-      return null;
-    }
-
-    @Override
-    public String getSaltSize() {
-      return null;
-    }
-
-    @Override
-    public String getIterationCount() {
-      return null;
-    }
-
-    @Override
-    public String getKeyLength() {
-      return null;
-    }
-
-    @Override
-    public Map<String, Integer> getGatewayPortMappings() {
-      return null;
-    }
-
-    @Override
-    public boolean isGatewayPortMappingEnabled() {
-      return false;
-    }
-
-    @Override
-    public boolean isGatewayServerHeaderEnabled() {
-      return false;
-    }
-
-    @Override
-    public String getDefaultDiscoveryAddress() {
-      return null;
-    }
-
-    @Override
-    public String getDefaultDiscoveryCluster() {
-      return null;
-    }
-
-    @Override
-    public int getClusterMonitorPollingInterval(String type) {
-      return 0;
-    }
-
-    @Override
-    public boolean isClusterMonitorEnabled(String type) {
-      return false;
-    }
-
-    @Override
-    public List<String> getRemoteRegistryConfigurationNames() {
-      return null;
-    }
-
-    @Override
-    public String getRemoteRegistryConfiguration(String name) {
-      return null;
-    }
-
-    @Override
-    public String getRemoteConfigurationMonitorClientName() {
-      return null;
-    }
-
-    @Override
-    public boolean allowUnauthenticatedRemoteRegistryReadAccess() {
-      return false;
-    }
-
-    @Override
-    public boolean isRemoteAliasServiceEnabled() {
-      return false;
-    }
-
-    @Override
-    public List<String> getReadOnlyOverrideTopologyNames() {
-      return null;
-    }
-
-    @Override
-    public String getKnoxAdminGroups() {
-      return null;
-    }
-
-    @Override
-    public String getKnoxAdminUsers() {
-      return null;
-    }
-
-    @Override
-    public String getFederationHeaderName() {
-      return null;
-    }
-
-    @Override
-    public List<String> getAutoDeployTopologyNames() {
-      return null;
-    }
-
-    @Override
-    public String getDispatchWhitelist() {
-      return null;
-    }
-
-    @Override
-    public List<String> getDispatchWhitelistServices() {
-      return null;
-    }
-
-    @Override
-    public boolean isTopologyValidationEnabled() {
-      return false;
-    }
-  }
-
-  private static class TestRemoteConfigurationRegistryClientService implements RemoteConfigurationRegistryClientService
{
-    @Override
-    public void setAliasService(AliasService aliasService) {
-
-    }
-
-    @Override
-    public RemoteConfigurationRegistryClient get(String l) {
-      return null;
-    }
-
-    @Override
-    public void init(GatewayConfig config, Map<String, String> options) throws ServiceLifecycleException
{
-
-    }
-
-    @Override
-    public void start() throws ServiceLifecycleException {
-
-    }
+    GatewayConfig gatewayConfig = EasyMock.createNiceMock(GatewayConfig.class);
+    EasyMock.expect(gatewayConfig.getGatewayProvidersConfigDir()).andReturn("./shared-providers").anyTimes();
+    EasyMock.expect(gatewayConfig.getGatewayDescriptorsDir()).andReturn("./descriptors").anyTimes();
+    EasyMock.replay(gatewayConfig);
 
-    @Override
-    public void stop() throws ServiceLifecycleException {
+    RemoteConfigurationRegistryClientService remoteConfigurationRegistryClientService =
+        EasyMock.createNiceMock(RemoteConfigurationRegistryClientService.class);
 
-    }
+    new DefaultRemoteConfigurationMonitor(gatewayConfig, remoteConfigurationRegistryClientService);
   }
 }


Mime
View raw message