kudu-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From danburk...@apache.org
Subject incubator-kudu git commit: Build thirdparty CMake and LLVM without debugging symbols
Date Wed, 13 Jan 2016 21:35:00 GMT
Repository: incubator-kudu
Updated Branches:
  refs/heads/master 8ed68d7a5 -> 160cb18f9


Build thirdparty CMake and LLVM without debugging symbols

This change drops the size of a fully built thirdparty from 26G to 3.8G.
Debug symbols are occasionally useful for debugging codegen issues, but
the overhead is too much to always enable them.

Change-Id: I4c1bd34f9e90a7e3a7a6f30e38f0f76711a57237
Reviewed-on: http://gerrit.cloudera.org:8080/1777
Reviewed-by: Todd Lipcon <todd@apache.org>
Tested-by: Internal Jenkins


Project: http://git-wip-us.apache.org/repos/asf/incubator-kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-kudu/commit/160cb18f
Tree: http://git-wip-us.apache.org/repos/asf/incubator-kudu/tree/160cb18f
Diff: http://git-wip-us.apache.org/repos/asf/incubator-kudu/diff/160cb18f

Branch: refs/heads/master
Commit: 160cb18f984769c9ed3b47fa180f0d5cfc20b010
Parents: 8ed68d7
Author: Dan Burkert <dan@cloudera.com>
Authored: Tue Jan 12 16:52:48 2016 -0800
Committer: Dan Burkert <dan@cloudera.com>
Committed: Wed Jan 13 21:34:45 2016 +0000

----------------------------------------------------------------------
 thirdparty/build-thirdparty.sh | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/160cb18f/thirdparty/build-thirdparty.sh
----------------------------------------------------------------------
diff --git a/thirdparty/build-thirdparty.sh b/thirdparty/build-thirdparty.sh
index 8f893b4..2ff69ba 100755
--- a/thirdparty/build-thirdparty.sh
+++ b/thirdparty/build-thirdparty.sh
@@ -58,8 +58,8 @@ done
 #
 # We also enable -fno-omit-frame-pointer so that profiling tools which
 # use frame-pointer based stack unwinding can function correctly.
-EXTRA_CFLAGS="$CFLAGS $EXTRA_CFLAGS -g -fno-omit-frame-pointer"
-EXTRA_CXXFLAGS="$CXXFLAGS $EXTRA_CXXFLAGS -g -fno-omit-frame-pointer -O2"
+EXTRA_CFLAGS="$CFLAGS $EXTRA_CFLAGS -fno-omit-frame-pointer"
+EXTRA_CXXFLAGS="$CXXFLAGS $EXTRA_CXXFLAGS -fno-omit-frame-pointer -O2"
 EXTRA_LDFLAGS="$LDFLAGS $EXTRA_LDFLAGS"
 EXTRA_LIBS="$LIBS $EXTRA_LIBS"
 
@@ -147,6 +147,13 @@ if [ -n "$F_ALL" -o -n "$F_LLVM" ]; then
   build_llvm
 fi
 
+# Enable debug symbols so that stacktraces and linenumbers are available at
+# runtime. CMake and LLVM are compiled without debug symbols since CMake is a
+# compile-time only tool, and the LLVM debug symbols take up more than 20GiB of
+# disk space.
+EXTRA_CFLAGS="-g $EXTRA_CFLAGS"
+EXTRA_CXXFLAGS="-g $EXTRA_CXXFLAGS"
+
 if [ -n "$OS_LINUX" ] && [ -n "$F_ALL" -o -n "$F_LIBUNWIND" ]; then
   build_libunwind
 fi


Mime
View raw message