kudu-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From danburk...@apache.org
Subject [3/4] incubator-kudu git commit: Convert from pass-by-reference with copy to pass-by-value
Date Wed, 20 Jan 2016 00:35:38 GMT
Convert from pass-by-reference with copy to pass-by-value

This patch was created using the clang-modernize pass-by-value
transform tool.

Change-Id: Idc237fef1e1c3b9399cc07b71f961eccb087a7fd
Reviewed-on: http://gerrit.cloudera.org:8080/1801
Tested-by: Internal Jenkins
Reviewed-by: Dan Burkert <dan@cloudera.com>


Project: http://git-wip-us.apache.org/repos/asf/incubator-kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-kudu/commit/61934118
Tree: http://git-wip-us.apache.org/repos/asf/incubator-kudu/tree/61934118
Diff: http://git-wip-us.apache.org/repos/asf/incubator-kudu/diff/61934118

Branch: refs/heads/master
Commit: 6193411835079dbf0098229e1975d77d4c9ee95a
Parents: 35b49cc
Author: Dan Burkert <dan@cloudera.com>
Authored: Tue Nov 24 14:36:15 2015 -0800
Committer: Dan Burkert <dan@cloudera.com>
Committed: Wed Jan 20 00:34:56 2016 +0000

----------------------------------------------------------------------
 src/kudu/benchmarks/tpch/rpc_line_item_dao.cc   | 28 +++++----
 src/kudu/benchmarks/tpch/rpc_line_item_dao.h    |  7 +--
 src/kudu/cfile/binary_dict_block.cc             |  6 +-
 src/kudu/cfile/binary_dict_block.h              |  2 +-
 src/kudu/cfile/binary_plain_block.cc            | 12 ++--
 src/kudu/cfile/binary_plain_block.h             |  2 +-
 src/kudu/cfile/binary_prefix_block.cc           | 20 +++----
 src/kudu/cfile/binary_prefix_block.h            |  2 +-
 src/kudu/cfile/block_handle.h                   |  8 +--
 src/kudu/cfile/bshuf_block.h                    | 16 ++---
 src/kudu/cfile/gvint_block.cc                   | 12 ++--
 src/kudu/cfile/gvint_block.h                    |  2 +-
 src/kudu/cfile/plain_bitmap_block.h             | 12 ++--
 src/kudu/cfile/plain_block.h                    | 12 ++--
 src/kudu/cfile/rle_block.h                      | 24 ++++----
 src/kudu/client/batcher.cc                      | 15 +++--
 src/kudu/client/client-internal.cc              | 14 ++---
 src/kudu/client/meta_cache.cc                   | 27 +++++----
 src/kudu/client/meta_cache.h                    |  8 +--
 src/kudu/client/scan_predicate-internal.h       |  2 +-
 src/kudu/client/scan_predicate.cc               | 10 ++--
 src/kudu/client/schema-internal.h               | 24 ++++----
 src/kudu/client/session-internal.cc             | 13 +++--
 src/kudu/client/session-internal.h              |  2 +-
 src/kudu/client/table-internal.cc               | 18 +++---
 src/kudu/client/table-internal.h                |  8 +--
 src/kudu/client/table_alterer-internal.cc       |  9 ++-
 src/kudu/client/table_alterer-internal.h        |  2 +-
 src/kudu/client/tablet_server-internal.cc       |  7 +--
 src/kudu/client/tablet_server-internal.h        |  3 +-
 src/kudu/common/columnblock.h                   |  3 +-
 src/kudu/common/generic_iterators-test.cc       |  8 +--
 src/kudu/common/generic_iterators.cc            | 12 ++--
 src/kudu/common/generic_iterators.h             |  6 +-
 src/kudu/common/row_changelist.h                |  4 +-
 src/kudu/common/scan_predicate.cc               | 10 ++--
 src/kudu/common/scan_predicate.h                |  3 +-
 src/kudu/common/schema.h                        | 20 +++----
 src/kudu/consensus/consensus-test-util.h        | 20 +++----
 src/kudu/consensus/consensus.cc                 |  7 +--
 src/kudu/consensus/consensus.h                  |  5 +-
 src/kudu/consensus/consensus_meta.cc            | 11 ++--
 src/kudu/consensus/consensus_meta.h             |  5 +-
 src/kudu/consensus/consensus_peers.cc           | 26 ++++-----
 src/kudu/consensus/consensus_peers.h            |  9 +--
 src/kudu/consensus/consensus_queue.h            | 21 ++++---
 src/kudu/consensus/leader_election.cc           | 15 +++--
 src/kudu/consensus/leader_election.h            |  8 +--
 src/kudu/consensus/local_consensus.cc           | 11 ++--
 src/kudu/consensus/local_consensus.h            |  4 +-
 src/kudu/consensus/log.cc                       | 38 ++++++------
 src/kudu/consensus/log.h                        |  8 +--
 src/kudu/consensus/log_anchor_registry.cc       | 10 ++--
 src/kudu/consensus/log_anchor_registry.h        |  2 +-
 src/kudu/consensus/log_index.cc                 | 13 ++---
 src/kudu/consensus/log_index.h                  |  2 +-
 src/kudu/consensus/log_reader.cc                | 12 ++--
 src/kudu/consensus/log_reader.h                 |  6 +-
 src/kudu/consensus/log_util.cc                  | 34 +++++------
 src/kudu/consensus/log_util.h                   |  8 +--
 src/kudu/consensus/raft_consensus.cc            | 37 +++++-------
 src/kudu/consensus/raft_consensus.h             |  4 +-
 src/kudu/consensus/raft_consensus_state.cc      | 21 ++++---
 src/kudu/consensus/raft_consensus_state.h       |  3 +-
 src/kudu/fs/block_manager_util.cc               | 11 ++--
 src/kudu/fs/block_manager_util.h                |  5 +-
 src/kudu/fs/file_block_manager.cc               | 43 ++++++--------
 src/kudu/fs/log_block_manager.cc                | 59 +++++++++----------
 src/kudu/gutil/bind_internal.h                  | 51 +++++++---------
 src/kudu/gutil/gscoped_ptr.h                    |  2 +-
 src/kudu/gutil/ref_counted_memory.cc            |  5 +-
 src/kudu/gutil/ref_counted_memory.h             |  2 +-
 src/kudu/gutil/strings/split.h                  |  2 +-
 src/kudu/gutil/strings/split_internal.h         | 14 +++--
 src/kudu/gutil/strings/strcat.h                 |  3 +-
 .../alter_table-randomized-test.cc              |  5 +-
 .../integration-tests/external_mini_cluster.cc  | 41 ++++++-------
 .../integration-tests/external_mini_cluster.h   |  9 ++-
 .../integration-tests/linked_list-test-util.h   | 51 ++++++++--------
 src/kudu/master/catalog_manager.cc              | 46 +++++++--------
 src/kudu/master/catalog_manager.h               |  4 +-
 src/kudu/master/master_rpc.cc                   | 23 ++++----
 src/kudu/master/master_rpc.h                    |  6 +-
 src/kudu/master/mini_master.cc                  | 11 ++--
 src/kudu/master/mini_master.h                   |  2 +-
 src/kudu/master/sys_catalog.cc                  |  7 +--
 src/kudu/master/sys_catalog.h                   |  5 +-
 src/kudu/master/ts_descriptor.cc                | 11 ++--
 src/kudu/master/ts_descriptor.h                 |  2 +-
 src/kudu/rpc/acceptor_pool.cc                   | 17 +++---
 src/kudu/rpc/acceptor_pool.h                    |  3 +-
 src/kudu/rpc/connection.cc                      | 28 +++++----
 src/kudu/rpc/connection.h                       |  4 +-
 src/kudu/rpc/messenger.cc                       | 14 ++---
 src/kudu/rpc/messenger.h                        |  7 +--
 src/kudu/rpc/outbound_call.cc                   | 15 +++--
 src/kudu/rpc/outbound_call.h                    |  7 +--
 src/kudu/rpc/proxy.cc                           |  9 ++-
 src/kudu/rpc/proxy.h                            |  5 +-
 src/kudu/rpc/reactor.cc                         | 18 ++----
 src/kudu/rpc/reactor.h                          |  3 +-
 src/kudu/rpc/remote_method.cc                   |  7 +--
 src/kudu/rpc/remote_method.h                    |  2 +-
 src/kudu/rpc/rpc.h                              |  9 ++-
 src/kudu/rpc/sasl_client.cc                     | 15 +++--
 src/kudu/rpc/sasl_client.h                      |  2 +-
 src/kudu/rpc/sasl_server.cc                     | 15 +++--
 src/kudu/rpc/sasl_server.h                      |  2 +-
 src/kudu/server/rpc_server.cc                   |  6 +-
 src/kudu/server/rpc_server.h                    |  2 +-
 src/kudu/server/server_base.cc                  | 22 +++----
 src/kudu/server/server_base.h                   |  3 +-
 src/kudu/server/webserver.h                     |  5 +-
 src/kudu/tablet/cfile_set.cc                    |  5 +-
 src/kudu/tablet/cfile_set.h                     | 15 +++--
 src/kudu/tablet/compaction.cc                   | 21 ++++---
 src/kudu/tablet/concurrent_btree.h              | 15 ++---
 src/kudu/tablet/delta_applier.cc                | 11 ++--
 src/kudu/tablet/delta_applier.h                 |  4 +-
 src/kudu/tablet/delta_compaction.cc             | 29 +++++-----
 src/kudu/tablet/delta_compaction.h              | 11 ++--
 src/kudu/tablet/delta_iterator_merger.cc        |  6 +-
 src/kudu/tablet/delta_iterator_merger.h         |  2 +-
 src/kudu/tablet/delta_key.h                     |  7 +--
 src/kudu/tablet/delta_tracker.cc                | 15 +++--
 src/kudu/tablet/delta_tracker.h                 |  7 +--
 src/kudu/tablet/deltafile.cc                    | 36 +++++-------
 src/kudu/tablet/deltafile.h                     |  8 +--
 src/kudu/tablet/deltamemstore.cc                | 24 ++++----
 src/kudu/tablet/deltamemstore.h                 |  3 +-
 src/kudu/tablet/diskrowset.cc                   | 52 ++++++++---------
 src/kudu/tablet/diskrowset.h                    | 14 ++---
 src/kudu/tablet/lock_manager-test.cc            |  5 +-
 src/kudu/tablet/maintenance_manager.cc          |  7 +--
 src/kudu/tablet/maintenance_manager.h           |  2 +-
 src/kudu/tablet/memrowset.cc                    | 23 ++++----
 src/kudu/tablet/memrowset.h                     |  5 +-
 src/kudu/tablet/mock-rowsets.h                  | 10 ++--
 src/kudu/tablet/row_op.cc                       |  5 +-
 src/kudu/tablet/row_op.h                        |  2 +-
 src/kudu/tablet/rowset.cc                       |  8 +--
 src/kudu/tablet/rowset.h                        |  7 +--
 src/kudu/tablet/rowset_tree.h                   |  6 +-
 src/kudu/tablet/tablet-harness.h                | 18 +++---
 src/kudu/tablet/tablet.cc                       | 19 +++---
 src/kudu/tablet/tablet.h                        |  8 +--
 src/kudu/tablet/tablet_bootstrap.cc             | 18 +++---
 src/kudu/tablet/tablet_metadata.cc              | 61 ++++++++++----------
 src/kudu/tablet/tablet_metadata.h               | 11 ++--
 src/kudu/tablet/tablet_peer.cc                  | 19 +++---
 src/kudu/tablet/tablet_peer.h                   |  5 +-
 src/kudu/tablet/transactions/transaction.h      |  5 +-
 src/kudu/tools/fs_dump-tool.cc                  |  7 +--
 src/kudu/tools/fs_list-tool.cc                  |  7 +--
 src/kudu/tools/ksck.cc                          | 11 ++--
 src/kudu/tools/ksck.h                           | 25 +++-----
 src/kudu/tools/ksck_remote.cc                   | 19 +++---
 src/kudu/tools/kudu-admin.cc                    |  9 ++-
 src/kudu/tools/ts-cli.cc                        |  9 ++-
 src/kudu/tserver/remote_bootstrap_client.cc     | 29 +++++-----
 src/kudu/tserver/remote_bootstrap_client.h      |  7 +--
 src/kudu/tserver/remote_bootstrap_session.cc    | 20 +++----
 src/kudu/tserver/remote_bootstrap_session.h     |  9 +--
 src/kudu/tserver/scanners.cc                    | 10 ++--
 src/kudu/tserver/scanners.h                     | 13 ++---
 src/kudu/tserver/ts_tablet_manager.cc           | 10 +---
 src/kudu/tserver/ts_tablet_manager.h            |  5 +-
 src/kudu/util/debug/trace_event_impl.cc         |  9 +--
 src/kudu/util/env-test.cc                       |  5 +-
 src/kudu/util/env_posix.cc                      | 30 ++++------
 src/kudu/util/env_util.cc                       |  7 +--
 src/kudu/util/env_util.h                        |  2 +-
 src/kudu/util/failure_detector.cc               |  3 +-
 src/kudu/util/interval_tree-inl.h               |  9 +--
 src/kudu/util/jsonreader.cc                     |  4 +-
 src/kudu/util/jsonreader.h                      |  2 +-
 src/kudu/util/logging.cc                        |  4 +-
 src/kudu/util/mem_tracker.cc                    | 10 ++--
 src/kudu/util/mem_tracker.h                     | 16 ++---
 src/kudu/util/memenv/memenv.cc                  |  6 +-
 src/kudu/util/memory/memory.h                   |  9 ++-
 src/kudu/util/metrics.cc                        | 18 +++---
 src/kudu/util/metrics.h                         | 17 +++---
 src/kudu/util/net/net_util.cc                   |  6 +-
 src/kudu/util/net/net_util.h                    |  2 +-
 src/kudu/util/pstack_watcher.cc                 |  6 +-
 src/kudu/util/pstack_watcher.h                  |  2 +-
 src/kudu/util/resettable_heartbeater.cc         | 17 +++---
 src/kudu/util/rolling_log.cc                    | 15 ++---
 src/kudu/util/rolling_log.h                     |  4 +-
 src/kudu/util/stopwatch.h                       | 20 +++----
 src/kudu/util/subprocess.cc                     | 15 +++--
 src/kudu/util/subprocess.h                      |  3 +-
 src/kudu/util/sync_point.cc                     |  6 +-
 src/kudu/util/sync_point.h                      |  2 +-
 src/kudu/util/test_graph.h                      |  7 +--
 src/kudu/util/thread.cc                         |  7 ++-
 src/kudu/util/thread.h                          | 17 +++---
 src/kudu/util/threadpool.cc                     | 17 +++---
 src/kudu/util/threadpool.h                      |  2 +-
 200 files changed, 1046 insertions(+), 1345 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/61934118/src/kudu/benchmarks/tpch/rpc_line_item_dao.cc
----------------------------------------------------------------------
diff --git a/src/kudu/benchmarks/tpch/rpc_line_item_dao.cc b/src/kudu/benchmarks/tpch/rpc_line_item_dao.cc
index 55e7d58..e90801a 100644
--- a/src/kudu/benchmarks/tpch/rpc_line_item_dao.cc
+++ b/src/kudu/benchmarks/tpch/rpc_line_item_dao.cc
@@ -59,9 +59,9 @@ namespace {
 
 class FlushCallback : public KuduStatusCallback {
  public:
-  FlushCallback(client::sp::shared_ptr<KuduSession> session, Semaphore *sem)
-    : session_(session),
-      sem_(sem) {
+  FlushCallback(client::sp::shared_ptr<KuduSession> session, Semaphore* sem)
+      : session_(std::move(session)),
+        sem_(sem) {
     sem_->Acquire();
   }
 
@@ -220,18 +220,16 @@ RpcLineItemDAO::~RpcLineItemDAO() {
   FinishWriting();
 }
 
-RpcLineItemDAO::RpcLineItemDAO(const string& master_address,
-                               const string& table_name,
-                               int batch_size,
-                               int mstimeout,
-                               const vector<const KuduPartialRow*>& tablet_splits)
-  : master_address_(master_address),
-    table_name_(table_name),
-    timeout_(MonoDelta::FromMilliseconds(mstimeout)),
-    batch_max_(batch_size),
-    tablet_splits_(tablet_splits),
-    batch_size_(0),
-    semaphore_(1) {
+RpcLineItemDAO::RpcLineItemDAO(string master_address, string table_name,
+                               int batch_size, int mstimeout,
+                               vector<const KuduPartialRow*> tablet_splits)
+    : master_address_(std::move(master_address)),
+      table_name_(std::move(table_name)),
+      timeout_(MonoDelta::FromMilliseconds(mstimeout)),
+      batch_max_(batch_size),
+      tablet_splits_(std::move(tablet_splits)),
+      batch_size_(0),
+      semaphore_(1) {
 }
 
 } // namespace kudu

http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/61934118/src/kudu/benchmarks/tpch/rpc_line_item_dao.h
----------------------------------------------------------------------
diff --git a/src/kudu/benchmarks/tpch/rpc_line_item_dao.h b/src/kudu/benchmarks/tpch/rpc_line_item_dao.h
index 3ad6bcb..b29eef2 100644
--- a/src/kudu/benchmarks/tpch/rpc_line_item_dao.h
+++ b/src/kudu/benchmarks/tpch/rpc_line_item_dao.h
@@ -36,12 +36,11 @@ class RpcLineItemDAO {
  public:
   class Scanner;
 
-  RpcLineItemDAO(const std::string& master_address,
-                 const std::string& table_name,
+  RpcLineItemDAO(std::string master_address,
+                 std::string table_name,
                  int batch_size,
                  int mstimeout = 5000,
-                 const std::vector<const KuduPartialRow*>& tablet_splits =
-                    std::vector<const KuduPartialRow*>());
+                 std::vector<const KuduPartialRow*> tablet_splits = {});
   ~RpcLineItemDAO();
   void WriteLine(boost::function<void(KuduPartialRow*)> f);
   void MutateLine(boost::function<void(KuduPartialRow*)> f);

http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/61934118/src/kudu/cfile/binary_dict_block.cc
----------------------------------------------------------------------
diff --git a/src/kudu/cfile/binary_dict_block.cc b/src/kudu/cfile/binary_dict_block.cc
index 98aa7af..731e16d 100644
--- a/src/kudu/cfile/binary_dict_block.cc
+++ b/src/kudu/cfile/binary_dict_block.cc
@@ -173,9 +173,9 @@ Status BinaryDictBlockBuilder::GetFirstKey(void* key_void) const {
 // Decoding
 ////////////////////////////////////////////////////////////
 
-BinaryDictBlockDecoder::BinaryDictBlockDecoder(const Slice& slice, CFileIterator* iter)
-  : data_(slice),
-    parsed_(false) {
+BinaryDictBlockDecoder::BinaryDictBlockDecoder(Slice slice, CFileIterator* iter)
+    : data_(std::move(slice)),
+      parsed_(false) {
   dict_decoder_ = iter->GetDictDecoder();
 }
 

http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/61934118/src/kudu/cfile/binary_dict_block.h
----------------------------------------------------------------------
diff --git a/src/kudu/cfile/binary_dict_block.h b/src/kudu/cfile/binary_dict_block.h
index 19a69eb..7740795 100644
--- a/src/kudu/cfile/binary_dict_block.h
+++ b/src/kudu/cfile/binary_dict_block.h
@@ -119,7 +119,7 @@ class CFileIterator;
 
 class BinaryDictBlockDecoder : public BlockDecoder {
  public:
-  explicit BinaryDictBlockDecoder(const Slice& slice, CFileIterator* iter);
+  explicit BinaryDictBlockDecoder(Slice slice, CFileIterator* iter);
 
   virtual Status ParseHeader() OVERRIDE;
   virtual void SeekToPositionInBlock(uint pos) OVERRIDE;

http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/61934118/src/kudu/cfile/binary_plain_block.cc
----------------------------------------------------------------------
diff --git a/src/kudu/cfile/binary_plain_block.cc b/src/kudu/cfile/binary_plain_block.cc
index 3446db5..3248158 100644
--- a/src/kudu/cfile/binary_plain_block.cc
+++ b/src/kudu/cfile/binary_plain_block.cc
@@ -133,12 +133,12 @@ Status BinaryPlainBlockBuilder::GetFirstKey(void *key_void) const {
 // Decoding
 ////////////////////////////////////////////////////////////
 
-BinaryPlainBlockDecoder::BinaryPlainBlockDecoder(const Slice &slice)
-  : data_(slice),
-    parsed_(false),
-    num_elems_(0),
-    ordinal_pos_base_(0),
-    cur_idx_(0) {
+BinaryPlainBlockDecoder::BinaryPlainBlockDecoder(Slice slice)
+    : data_(std::move(slice)),
+      parsed_(false),
+      num_elems_(0),
+      ordinal_pos_base_(0),
+      cur_idx_(0) {
 }
 
 Status BinaryPlainBlockDecoder::ParseHeader() {

http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/61934118/src/kudu/cfile/binary_plain_block.h
----------------------------------------------------------------------
diff --git a/src/kudu/cfile/binary_plain_block.h b/src/kudu/cfile/binary_plain_block.h
index de1d215..97a9e39 100644
--- a/src/kudu/cfile/binary_plain_block.h
+++ b/src/kudu/cfile/binary_plain_block.h
@@ -82,7 +82,7 @@ class BinaryPlainBlockBuilder : public BlockBuilder {
 
 class BinaryPlainBlockDecoder : public BlockDecoder {
  public:
-  explicit BinaryPlainBlockDecoder(const Slice &slice);
+  explicit BinaryPlainBlockDecoder(Slice slice);
 
   virtual Status ParseHeader() OVERRIDE;
   virtual void SeekToPositionInBlock(uint pos) OVERRIDE;

http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/61934118/src/kudu/cfile/binary_prefix_block.cc
----------------------------------------------------------------------
diff --git a/src/kudu/cfile/binary_prefix_block.cc b/src/kudu/cfile/binary_prefix_block.cc
index efc66cd..e316aa6 100644
--- a/src/kudu/cfile/binary_prefix_block.cc
+++ b/src/kudu/cfile/binary_prefix_block.cc
@@ -237,16 +237,16 @@ size_t BinaryPrefixBlockBuilder::CommonPrefixLength(const Slice& slice_a,
 // StringPrefixBlockDecoder
 ////////////////////////////////////////////////////////////
 
-BinaryPrefixBlockDecoder::BinaryPrefixBlockDecoder(const Slice &slice)
-  : data_(slice),
-    parsed_(false),
-    num_elems_(0),
-    ordinal_pos_base_(0),
-    num_restarts_(0),
-    restarts_(nullptr),
-    data_start_(nullptr),
-    cur_idx_(0),
-    next_ptr_(nullptr) {
+BinaryPrefixBlockDecoder::BinaryPrefixBlockDecoder(Slice slice)
+    : data_(std::move(slice)),
+      parsed_(false),
+      num_elems_(0),
+      ordinal_pos_base_(0),
+      num_restarts_(0),
+      restarts_(nullptr),
+      data_start_(nullptr),
+      cur_idx_(0),
+      next_ptr_(nullptr) {
 }
 
 Status BinaryPrefixBlockDecoder::ParseHeader() {

http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/61934118/src/kudu/cfile/binary_prefix_block.h
----------------------------------------------------------------------
diff --git a/src/kudu/cfile/binary_prefix_block.h b/src/kudu/cfile/binary_prefix_block.h
index dc6273f..ecee9c6 100644
--- a/src/kudu/cfile/binary_prefix_block.h
+++ b/src/kudu/cfile/binary_prefix_block.h
@@ -83,7 +83,7 @@ class BinaryPrefixBlockBuilder : public BlockBuilder {
 // Decoder for BINARY type, PREFIX encoding
 class BinaryPrefixBlockDecoder : public BlockDecoder {
  public:
-  explicit BinaryPrefixBlockDecoder(const Slice &slice);
+  explicit BinaryPrefixBlockDecoder(Slice slice);
 
   virtual Status ParseHeader() OVERRIDE;
   virtual void SeekToPositionInBlock(uint pos) OVERRIDE;

http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/61934118/src/kudu/cfile/block_handle.h
----------------------------------------------------------------------
diff --git a/src/kudu/cfile/block_handle.h b/src/kudu/cfile/block_handle.h
index adc79e6..0c34e41 100644
--- a/src/kudu/cfile/block_handle.h
+++ b/src/kudu/cfile/block_handle.h
@@ -71,10 +71,10 @@ class BlockHandle {
   Slice data_;
   bool is_data_owner_;
 
-  explicit BlockHandle(const Slice &data)
-  // We copy the slice but not the data itself.
-    : data_(data),
-      is_data_owner_(true) { }
+  explicit BlockHandle(Slice data)
+      : data_(std::move(data)),
+        is_data_owner_(true) {
+  }
 
   explicit BlockHandle(BlockCacheHandle *dblk_data)
     : is_data_owner_(false) {

http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/61934118/src/kudu/cfile/bshuf_block.h
----------------------------------------------------------------------
diff --git a/src/kudu/cfile/bshuf_block.h b/src/kudu/cfile/bshuf_block.h
index a373b9c..1058eb0 100644
--- a/src/kudu/cfile/bshuf_block.h
+++ b/src/kudu/cfile/bshuf_block.h
@@ -173,14 +173,14 @@ Slice BShufBlockBuilder<UINT32>::Finish(rowid_t ordinal_pos);
 template<DataType Type>
 class BShufBlockDecoder : public BlockDecoder {
  public:
-  explicit BShufBlockDecoder(const Slice& slice)
-    : data_(slice),
-      parsed_(false),
-      ordinal_pos_base_(0),
-      num_elems_(0),
-      compressed_size_(0),
-      num_elems_after_padding_(0),
-      cur_idx_(0) {
+  explicit BShufBlockDecoder(Slice slice)
+      : data_(std::move(slice)),
+        parsed_(false),
+        ordinal_pos_base_(0),
+        num_elems_(0),
+        compressed_size_(0),
+        num_elems_after_padding_(0),
+        cur_idx_(0) {
   }
 
   Status ParseHeader() OVERRIDE {

http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/61934118/src/kudu/cfile/gvint_block.cc
----------------------------------------------------------------------
diff --git a/src/kudu/cfile/gvint_block.cc b/src/kudu/cfile/gvint_block.cc
index c3fc8f7..6f3ecc7 100644
--- a/src/kudu/cfile/gvint_block.cc
+++ b/src/kudu/cfile/gvint_block.cc
@@ -116,15 +116,13 @@ Slice GVIntBlockBuilder::Finish(rowid_t ordinal_pos) {
 // Decoder
 ////////////////////////////////////////////////////////////
 
-
-GVIntBlockDecoder::GVIntBlockDecoder(const Slice &slice)
-  : data_(slice),
-    parsed_(false),
-    cur_pos_(nullptr),
-    cur_idx_(0) {
+GVIntBlockDecoder::GVIntBlockDecoder(Slice slice)
+    : data_(std::move(slice)),
+      parsed_(false),
+      cur_pos_(nullptr),
+      cur_idx_(0) {
 }
 
-
 Status GVIntBlockDecoder::ParseHeader() {
   // TODO: better range check
   CHECK_GE(data_.size(), kMinHeaderSize);

http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/61934118/src/kudu/cfile/gvint_block.h
----------------------------------------------------------------------
diff --git a/src/kudu/cfile/gvint_block.h b/src/kudu/cfile/gvint_block.h
index 4e51a6c..def0e3e 100644
--- a/src/kudu/cfile/gvint_block.h
+++ b/src/kudu/cfile/gvint_block.h
@@ -96,7 +96,7 @@ class GVIntBlockBuilder : public BlockBuilder {
 // Decoder for UINT32 type, GROUP_VARINT coding
 class GVIntBlockDecoder : public BlockDecoder {
  public:
-  explicit GVIntBlockDecoder(const Slice &slice);
+  explicit GVIntBlockDecoder(Slice slice);
 
   Status ParseHeader() OVERRIDE;
   void SeekToStart() {

http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/61934118/src/kudu/cfile/plain_bitmap_block.h
----------------------------------------------------------------------
diff --git a/src/kudu/cfile/plain_bitmap_block.h b/src/kudu/cfile/plain_bitmap_block.h
index a3d51b5..33461a6 100644
--- a/src/kudu/cfile/plain_bitmap_block.h
+++ b/src/kudu/cfile/plain_bitmap_block.h
@@ -99,12 +99,12 @@ class PlainBitMapBlockBuilder : public BlockBuilder {
 //
 class PlainBitMapBlockDecoder : public BlockDecoder {
  public:
-  explicit PlainBitMapBlockDecoder(const Slice& slice)
-  : data_(slice),
-    parsed_(false),
-    num_elems_(0),
-    ordinal_pos_base_(0),
-    cur_idx_(0)  {
+  explicit PlainBitMapBlockDecoder(Slice slice)
+      : data_(std::move(slice)),
+        parsed_(false),
+        num_elems_(0),
+        ordinal_pos_base_(0),
+        cur_idx_(0) {
   }
 
   virtual Status ParseHeader() OVERRIDE {

http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/61934118/src/kudu/cfile/plain_block.h
----------------------------------------------------------------------
diff --git a/src/kudu/cfile/plain_block.h b/src/kudu/cfile/plain_block.h
index 7d6af1f..7b40bd5 100644
--- a/src/kudu/cfile/plain_block.h
+++ b/src/kudu/cfile/plain_block.h
@@ -104,12 +104,12 @@ class PlainBlockBuilder : public BlockBuilder {
 template<DataType Type>
 class PlainBlockDecoder : public BlockDecoder {
  public:
-  explicit PlainBlockDecoder(const Slice &slice)
-    : data_(slice),
-      parsed_(false),
-      num_elems_(0),
-      ordinal_pos_base_(0),
-      cur_idx_(0) {
+  explicit PlainBlockDecoder(Slice slice)
+      : data_(std::move(slice)),
+        parsed_(false),
+        num_elems_(0),
+        ordinal_pos_base_(0),
+        cur_idx_(0) {
   }
 
   virtual Status ParseHeader() OVERRIDE {

http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/61934118/src/kudu/cfile/rle_block.h
----------------------------------------------------------------------
diff --git a/src/kudu/cfile/rle_block.h b/src/kudu/cfile/rle_block.h
index e8054c7..0a4ac0d 100644
--- a/src/kudu/cfile/rle_block.h
+++ b/src/kudu/cfile/rle_block.h
@@ -101,12 +101,12 @@ class RleBitMapBlockBuilder : public BlockBuilder {
 //
 class RleBitMapBlockDecoder : public BlockDecoder {
  public:
-  explicit RleBitMapBlockDecoder(const Slice& slice)
-    : data_(slice),
-      parsed_(false),
-      num_elems_(0),
-      ordinal_pos_base_(0),
-      cur_idx_(0) {
+  explicit RleBitMapBlockDecoder(Slice slice)
+      : data_(std::move(slice)),
+        parsed_(false),
+        num_elems_(0),
+        ordinal_pos_base_(0),
+        cur_idx_(0) {
   }
 
   virtual Status ParseHeader() OVERRIDE {
@@ -276,12 +276,12 @@ class RleIntBlockBuilder : public BlockBuilder {
 template <DataType IntType>
 class RleIntBlockDecoder : public BlockDecoder {
  public:
-  explicit RleIntBlockDecoder(const Slice& slice)
-  :  data_(slice),
-     parsed_(false),
-     num_elems_(0),
-     ordinal_pos_base_(0),
-     cur_idx_(0) {
+  explicit RleIntBlockDecoder(Slice slice)
+      : data_(std::move(slice)),
+        parsed_(false),
+        num_elems_(0),
+        ordinal_pos_base_(0),
+        cur_idx_(0) {
   }
 
   virtual Status ParseHeader() OVERRIDE {

http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/61934118/src/kudu/client/batcher.cc
----------------------------------------------------------------------
diff --git a/src/kudu/client/batcher.cc b/src/kudu/client/batcher.cc
index 5b5d2bf..69a683c 100644
--- a/src/kudu/client/batcher.cc
+++ b/src/kudu/client/batcher.cc
@@ -182,7 +182,7 @@ class WriteRpc : public Rpc {
  public:
   WriteRpc(const scoped_refptr<Batcher>& batcher,
            RemoteTablet* const tablet,
-           const vector<InFlightOp*>& ops,
+           vector<InFlightOp*> ops,
            const MonoTime& deadline,
            const shared_ptr<Messenger>& messenger);
   virtual ~WriteRpc();
@@ -240,15 +240,14 @@ class WriteRpc : public Rpc {
 
 WriteRpc::WriteRpc(const scoped_refptr<Batcher>& batcher,
                    RemoteTablet* const tablet,
-                   const vector<InFlightOp*>& ops,
+                   vector<InFlightOp*> ops,
                    const MonoTime& deadline,
                    const shared_ptr<Messenger>& messenger)
-  : Rpc(deadline, messenger),
-    batcher_(batcher),
-    tablet_(tablet),
-    current_ts_(NULL),
-    ops_(ops) {
-
+    : Rpc(deadline, messenger),
+      batcher_(batcher),
+      tablet_(tablet),
+      current_ts_(NULL),
+      ops_(std::move(ops)) {
   const Schema* schema = table()->schema().schema_;
 
   req_.set_tablet_id(tablet->tablet_id());

http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/61934118/src/kudu/client/client-internal.cc
----------------------------------------------------------------------
diff --git a/src/kudu/client/client-internal.cc b/src/kudu/client/client-internal.cc
index 8c8f939..bc56abd 100644
--- a/src/kudu/client/client-internal.cc
+++ b/src/kudu/client/client-internal.cc
@@ -556,9 +556,9 @@ namespace internal {
 class GetTableSchemaRpc : public Rpc {
  public:
   GetTableSchemaRpc(KuduClient* client,
-                    const StatusCallback& user_cb,
-                    const string& table_name,
-                    KuduSchema *out_schema,
+                    StatusCallback user_cb,
+                    string table_name,
+                    KuduSchema* out_schema,
                     PartitionSchema* out_partition_schema,
                     string* out_id,
                     const MonoTime& deadline,
@@ -587,8 +587,8 @@ class GetTableSchemaRpc : public Rpc {
 };
 
 GetTableSchemaRpc::GetTableSchemaRpc(KuduClient* client,
-                                     const StatusCallback& user_cb,
-                                     const string& table_name,
+                                     StatusCallback user_cb,
+                                     string table_name,
                                      KuduSchema* out_schema,
                                      PartitionSchema* out_partition_schema,
                                      string* out_id,
@@ -596,8 +596,8 @@ GetTableSchemaRpc::GetTableSchemaRpc(KuduClient* client,
                                      const shared_ptr<rpc::Messenger>& messenger)
     : Rpc(deadline, messenger),
       client_(DCHECK_NOTNULL(client)),
-      user_cb_(user_cb),
-      table_name_(table_name),
+      user_cb_(std::move(user_cb)),
+      table_name_(std::move(table_name)),
       out_schema_(DCHECK_NOTNULL(out_schema)),
       out_partition_schema_(DCHECK_NOTNULL(out_partition_schema)),
       out_id_(DCHECK_NOTNULL(out_id)) {

http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/61934118/src/kudu/client/meta_cache.cc
----------------------------------------------------------------------
diff --git a/src/kudu/client/meta_cache.cc b/src/kudu/client/meta_cache.cc
index c9877d8..79a992f 100644
--- a/src/kudu/client/meta_cache.cc
+++ b/src/kudu/client/meta_cache.cc
@@ -308,10 +308,10 @@ void MetaCache::UpdateTabletServer(const TSInfoPB& pb) {
 class LookupRpc : public Rpc {
  public:
   LookupRpc(const scoped_refptr<MetaCache>& meta_cache,
-            const StatusCallback& user_cb,
+            StatusCallback user_cb,
             const KuduTable* table,
-            const string& partition_key,
-            scoped_refptr<RemoteTablet> *remote_tablet,
+            string partition_key,
+            scoped_refptr<RemoteTablet>* remote_tablet,
             const MonoTime& deadline,
             const shared_ptr<Messenger>& messenger);
   virtual ~LookupRpc();
@@ -366,19 +366,18 @@ class LookupRpc : public Rpc {
 };
 
 LookupRpc::LookupRpc(const scoped_refptr<MetaCache>& meta_cache,
-                     const StatusCallback& user_cb,
-                     const KuduTable* table,
-                     const string& partition_key,
-                     scoped_refptr<RemoteTablet> *remote_tablet,
+                     StatusCallback user_cb, const KuduTable* table,
+                     string partition_key,
+                     scoped_refptr<RemoteTablet>* remote_tablet,
                      const MonoTime& deadline,
                      const shared_ptr<Messenger>& messenger)
-  : Rpc(deadline, messenger),
-    meta_cache_(meta_cache),
-    user_cb_(user_cb),
-    table_(table),
-    partition_key_(partition_key),
-    remote_tablet_(remote_tablet),
-    has_permit_(false) {
+    : Rpc(deadline, messenger),
+      meta_cache_(meta_cache),
+      user_cb_(std::move(user_cb)),
+      table_(table),
+      partition_key_(std::move(partition_key)),
+      remote_tablet_(remote_tablet),
+      has_permit_(false) {
   DCHECK(deadline.Initialized());
 }
 

http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/61934118/src/kudu/client/meta_cache.h
----------------------------------------------------------------------
diff --git a/src/kudu/client/meta_cache.h b/src/kudu/client/meta_cache.h
index 6e122c1..44a11d5 100644
--- a/src/kudu/client/meta_cache.h
+++ b/src/kudu/client/meta_cache.h
@@ -120,10 +120,10 @@ typedef std::unordered_map<std::string, RemoteTabletServer*> TabletServerMap;
 // This class is thread-safe.
 class RemoteTablet : public RefCountedThreadSafe<RemoteTablet> {
  public:
-  RemoteTablet(const std::string& tablet_id,
-               const Partition& partition)
-    : tablet_id_(tablet_id),
-      partition_(partition) {
+  RemoteTablet(std::string tablet_id,
+               Partition partition)
+      : tablet_id_(std::move(tablet_id)),
+        partition_(std::move(partition)) {
   }
 
   // Updates this tablet's replica locations.

http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/61934118/src/kudu/client/scan_predicate-internal.h
----------------------------------------------------------------------
diff --git a/src/kudu/client/scan_predicate-internal.h b/src/kudu/client/scan_predicate-internal.h
index 52023f0..32ce5bd 100644
--- a/src/kudu/client/scan_predicate-internal.h
+++ b/src/kudu/client/scan_predicate-internal.h
@@ -67,7 +67,7 @@ class ErrorPredicateData : public KuduPredicate::Data {
 // a constant.
 class ComparisonPredicateData : public KuduPredicate::Data {
  public:
-  ComparisonPredicateData(const ColumnSchema& col,
+  ComparisonPredicateData(ColumnSchema col,
                           KuduPredicate::ComparisonOp op,
                           KuduValue* value);
   virtual ~ComparisonPredicateData();

http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/61934118/src/kudu/client/scan_predicate.cc
----------------------------------------------------------------------
diff --git a/src/kudu/client/scan_predicate.cc b/src/kudu/client/scan_predicate.cc
index 8844cda..4a4df8b 100644
--- a/src/kudu/client/scan_predicate.cc
+++ b/src/kudu/client/scan_predicate.cc
@@ -48,12 +48,12 @@ KuduPredicate* KuduPredicate::Clone() const {
   return new KuduPredicate(data_->Clone());
 }
 
-ComparisonPredicateData::ComparisonPredicateData(const ColumnSchema& col,
+ComparisonPredicateData::ComparisonPredicateData(ColumnSchema col,
                                                  KuduPredicate::ComparisonOp op,
-                                                 KuduValue* val) :
-  col_(col),
-  op_(op),
-  val_(val) {
+                                                 KuduValue* val)
+    : col_(std::move(col)),
+      op_(op),
+      val_(val) {
 }
 ComparisonPredicateData::~ComparisonPredicateData() {
 }

http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/61934118/src/kudu/client/schema-internal.h
----------------------------------------------------------------------
diff --git a/src/kudu/client/schema-internal.h b/src/kudu/client/schema-internal.h
index 58ec14e..873519c 100644
--- a/src/kudu/client/schema-internal.h
+++ b/src/kudu/client/schema-internal.h
@@ -45,18 +45,18 @@ KuduColumnSchema::DataType FromInternalDataType(
 
 class KuduColumnSpec::Data {
  public:
-  explicit Data(const std::string& name)
-    : name(name),
-      has_type(false),
-      has_encoding(false),
-      has_compression(false),
-      has_block_size(false),
-      has_nullable(false),
-      primary_key(false),
-      has_default(false),
-      default_val(NULL),
-      remove_default(false),
-      has_rename_to(false) {
+  explicit Data(std::string name)
+      : name(std::move(name)),
+        has_type(false),
+        has_encoding(false),
+        has_compression(false),
+        has_block_size(false),
+        has_nullable(false),
+        primary_key(false),
+        has_default(false),
+        default_val(NULL),
+        remove_default(false),
+        has_rename_to(false) {
   }
 
   ~Data() {

http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/61934118/src/kudu/client/session-internal.cc
----------------------------------------------------------------------
diff --git a/src/kudu/client/session-internal.cc b/src/kudu/client/session-internal.cc
index 4052305..062615f 100644
--- a/src/kudu/client/session-internal.cc
+++ b/src/kudu/client/session-internal.cc
@@ -30,12 +30,13 @@ using internal::ErrorCollector;
 
 using sp::shared_ptr;
 
-KuduSession::Data::Data(const shared_ptr<KuduClient>& client)
-  : client_(client),
-    error_collector_(new ErrorCollector()),
-    flush_mode_(AUTO_FLUSH_SYNC),
-    external_consistency_mode_(CLIENT_PROPAGATED),
-    timeout_ms_(-1) {}
+KuduSession::Data::Data(shared_ptr<KuduClient> client)
+    : client_(std::move(client)),
+      error_collector_(new ErrorCollector()),
+      flush_mode_(AUTO_FLUSH_SYNC),
+      external_consistency_mode_(CLIENT_PROPAGATED),
+      timeout_ms_(-1) {
+}
 
 KuduSession::Data::~Data() {
 }

http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/61934118/src/kudu/client/session-internal.h
----------------------------------------------------------------------
diff --git a/src/kudu/client/session-internal.h b/src/kudu/client/session-internal.h
index 9611e61..d839314 100644
--- a/src/kudu/client/session-internal.h
+++ b/src/kudu/client/session-internal.h
@@ -33,7 +33,7 @@ class ErrorCollector;
 
 class KuduSession::Data {
  public:
-  explicit Data(const sp::shared_ptr<KuduClient>& client);
+  explicit Data(sp::shared_ptr<KuduClient> client);
   ~Data();
 
   void Init(const sp::shared_ptr<KuduSession>& session);

http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/61934118/src/kudu/client/table-internal.cc
----------------------------------------------------------------------
diff --git a/src/kudu/client/table-internal.cc b/src/kudu/client/table-internal.cc
index 04575f7..e603f49 100644
--- a/src/kudu/client/table-internal.cc
+++ b/src/kudu/client/table-internal.cc
@@ -39,16 +39,16 @@ namespace client {
 
 using sp::shared_ptr;
 
-KuduTable::Data::Data(const shared_ptr<KuduClient>& client,
-                      const string& name,
-                      const string& id,
+KuduTable::Data::Data(shared_ptr<KuduClient> client,
+                      string name,
+                      string id,
                       const KuduSchema& schema,
-                      const PartitionSchema& partition_schema)
-  : client_(client),
-    name_(name),
-    id_(id),
-    schema_(schema),
-    partition_schema_(partition_schema) {
+                      PartitionSchema partition_schema)
+    : client_(std::move(client)),
+      name_(std::move(name)),
+      id_(std::move(id)),
+      schema_(schema),
+      partition_schema_(std::move(partition_schema)) {
 }
 
 KuduTable::Data::~Data() {

http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/61934118/src/kudu/client/table-internal.h
----------------------------------------------------------------------
diff --git a/src/kudu/client/table-internal.h b/src/kudu/client/table-internal.h
index 5d3beb7..0a56f0d 100644
--- a/src/kudu/client/table-internal.h
+++ b/src/kudu/client/table-internal.h
@@ -28,11 +28,11 @@ namespace client {
 
 class KuduTable::Data {
  public:
-  Data(const sp::shared_ptr<KuduClient>& client,
-       const std::string& name,
-       const std::string& table_id,
+  Data(sp::shared_ptr<KuduClient> client,
+       std::string name,
+       std::string table_id,
        const KuduSchema& schema,
-       const PartitionSchema& partition_schema);
+       PartitionSchema partition_schema);
   ~Data();
 
   Status Open();

http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/61934118/src/kudu/client/table_alterer-internal.cc
----------------------------------------------------------------------
diff --git a/src/kudu/client/table_alterer-internal.cc b/src/kudu/client/table_alterer-internal.cc
index d9594bb..178bb8f 100644
--- a/src/kudu/client/table_alterer-internal.cc
+++ b/src/kudu/client/table_alterer-internal.cc
@@ -32,11 +32,10 @@ namespace client {
 using master::AlterTableRequestPB;
 using master::AlterTableRequestPB_AlterColumn;
 
-KuduTableAlterer::Data::Data(
-    KuduClient* client, const string& name)
-  : client_(client),
-    table_name_(name),
-    wait_(true) {
+KuduTableAlterer::Data::Data(KuduClient* client, string name)
+    : client_(client),
+      table_name_(std::move(name)),
+      wait_(true) {
 }
 
 KuduTableAlterer::Data::~Data() {

http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/61934118/src/kudu/client/table_alterer-internal.h
----------------------------------------------------------------------
diff --git a/src/kudu/client/table_alterer-internal.h b/src/kudu/client/table_alterer-internal.h
index 07a82ed..aa0c641 100644
--- a/src/kudu/client/table_alterer-internal.h
+++ b/src/kudu/client/table_alterer-internal.h
@@ -35,7 +35,7 @@ class KuduColumnSpec;
 
 class KuduTableAlterer::Data {
  public:
-  Data(KuduClient* client, const std::string& name);
+  Data(KuduClient* client, std::string name);
   ~Data();
   Status ToRequest(master::AlterTableRequestPB* req);
 

http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/61934118/src/kudu/client/tablet_server-internal.cc
----------------------------------------------------------------------
diff --git a/src/kudu/client/tablet_server-internal.cc b/src/kudu/client/tablet_server-internal.cc
index 0c06d58..d5ad1c7 100644
--- a/src/kudu/client/tablet_server-internal.cc
+++ b/src/kudu/client/tablet_server-internal.cc
@@ -22,10 +22,9 @@ using std::string;
 namespace kudu {
 namespace client {
 
-KuduTabletServer::Data::Data(const string& uuid,
-                             const string& hostname)
-  : uuid_(uuid),
-    hostname_(hostname) {
+KuduTabletServer::Data::Data(string uuid, string hostname)
+    : uuid_(std::move(uuid)),
+      hostname_(std::move(hostname)) {
 }
 
 KuduTabletServer::Data::~Data() {

http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/61934118/src/kudu/client/tablet_server-internal.h
----------------------------------------------------------------------
diff --git a/src/kudu/client/tablet_server-internal.h b/src/kudu/client/tablet_server-internal.h
index 87d41b1..edc903f 100644
--- a/src/kudu/client/tablet_server-internal.h
+++ b/src/kudu/client/tablet_server-internal.h
@@ -27,8 +27,7 @@ namespace client {
 
 class KuduTabletServer::Data {
  public:
-  Data(const std::string& uuid,
-       const std::string& hostname);
+  Data(std::string uuid, std::string hostname);
   ~Data();
 
   const std::string uuid_;

http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/61934118/src/kudu/common/columnblock.h
----------------------------------------------------------------------
diff --git a/src/kudu/common/columnblock.h b/src/kudu/common/columnblock.h
index b12c25a..f294349 100644
--- a/src/kudu/common/columnblock.h
+++ b/src/kudu/common/columnblock.h
@@ -127,8 +127,7 @@ class ColumnBlock {
 class ColumnBlockCell {
  public:
   ColumnBlockCell(ColumnBlock block, size_t row_idx)
-    : block_(block), row_idx_(row_idx) {
-  }
+      : block_(std::move(block)), row_idx_(row_idx) {}
 
   const TypeInfo* typeinfo() const { return block_.type_info(); }
   size_t size() const { return block_.type_info()->size(); }

http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/61934118/src/kudu/common/generic_iterators-test.cc
----------------------------------------------------------------------
diff --git a/src/kudu/common/generic_iterators-test.cc b/src/kudu/common/generic_iterators-test.cc
index 0571166..cb870be 100644
--- a/src/kudu/common/generic_iterators-test.cc
+++ b/src/kudu/common/generic_iterators-test.cc
@@ -44,10 +44,10 @@ static const Schema kIntSchema({ ColumnSchema("val", UINT32) }, 1);
 // vector.
 class VectorIterator : public ColumnwiseIterator {
  public:
-  explicit VectorIterator(const vector<uint32_t> &ints) :
-    ints_(ints),
-    cur_idx_(0)
-  {}
+  explicit VectorIterator(vector<uint32_t> ints)
+      : ints_(std::move(ints)),
+        cur_idx_(0) {
+  }
 
   Status Init(ScanSpec *spec) OVERRIDE {
     return Status::OK();

http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/61934118/src/kudu/common/generic_iterators.cc
----------------------------------------------------------------------
diff --git a/src/kudu/common/generic_iterators.cc b/src/kudu/common/generic_iterators.cc
index ebe8788..8d7651c 100644
--- a/src/kudu/common/generic_iterators.cc
+++ b/src/kudu/common/generic_iterators.cc
@@ -425,9 +425,9 @@ void UnionIterator::GetIteratorStats(std::vector<IteratorStats>* stats) const {
 // Materializing iterator
 ////////////////////////////////////////////////////////////
 
-MaterializingIterator::MaterializingIterator(const shared_ptr<ColumnwiseIterator> &iter)
-  : iter_(iter),
-    disallow_pushdown_for_tests_(!FLAGS_materializing_iterator_do_pushdown) {
+MaterializingIterator::MaterializingIterator(shared_ptr<ColumnwiseIterator> iter)
+    : iter_(std::move(iter)),
+      disallow_pushdown_for_tests_(!FLAGS_materializing_iterator_do_pushdown) {
 }
 
 Status MaterializingIterator::Init(ScanSpec *spec) {
@@ -541,10 +541,8 @@ string MaterializingIterator::ToString() const {
 // PredicateEvaluatingIterator
 ////////////////////////////////////////////////////////////
 
-
-PredicateEvaluatingIterator::PredicateEvaluatingIterator(
-  const shared_ptr<RowwiseIterator> &base_iter) :
-  base_iter_(base_iter) {
+PredicateEvaluatingIterator::PredicateEvaluatingIterator(shared_ptr<RowwiseIterator> base_iter)
+    : base_iter_(std::move(base_iter)) {
 }
 
 Status PredicateEvaluatingIterator::InitAndMaybeWrap(

http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/61934118/src/kudu/common/generic_iterators.h
----------------------------------------------------------------------
diff --git a/src/kudu/common/generic_iterators.h b/src/kudu/common/generic_iterators.h
index dff1b38..da5e706 100644
--- a/src/kudu/common/generic_iterators.h
+++ b/src/kudu/common/generic_iterators.h
@@ -139,7 +139,7 @@ class UnionIterator : public RowwiseIterator {
 // an entire batch, then other columns may avoid doing any IO.
 class MaterializingIterator : public RowwiseIterator {
  public:
-  explicit MaterializingIterator(const std::shared_ptr<ColumnwiseIterator> &iter);
+  explicit MaterializingIterator(std::shared_ptr<ColumnwiseIterator> iter);
 
   // Initialize the iterator, performing predicate pushdown as described above.
   Status Init(ScanSpec *spec) OVERRIDE;
@@ -213,8 +213,8 @@ class PredicateEvaluatingIterator : public RowwiseIterator {
   // Construct the evaluating iterator.
   // This is only called from ::InitAndMaybeWrap()
   // REQUIRES: base_iter is already Init()ed.
-  explicit PredicateEvaluatingIterator(const std::shared_ptr<RowwiseIterator> &base_iter);
-
+  explicit PredicateEvaluatingIterator(
+      std::shared_ptr<RowwiseIterator> base_iter);
 
   FRIEND_TEST(TestPredicateEvaluatingIterator, TestPredicateEvaluation);
 

http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/61934118/src/kudu/common/row_changelist.h
----------------------------------------------------------------------
diff --git a/src/kudu/common/row_changelist.h b/src/kudu/common/row_changelist.h
index 373f0b0..c48af75 100644
--- a/src/kudu/common/row_changelist.h
+++ b/src/kudu/common/row_changelist.h
@@ -95,9 +95,7 @@ class RowChangeList {
     : encoded_data_(fs) {
   }
 
-  explicit RowChangeList(const Slice &s)
-    : encoded_data_(s) {
-  }
+  explicit RowChangeList(Slice s) : encoded_data_(std::move(s)) {}
 
   // Create a RowChangeList which represents a delete.
   // This points to static (const) memory and should not be

http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/61934118/src/kudu/common/scan_predicate.cc
----------------------------------------------------------------------
diff --git a/src/kudu/common/scan_predicate.cc b/src/kudu/common/scan_predicate.cc
index 1113920..e919cae 100644
--- a/src/kudu/common/scan_predicate.cc
+++ b/src/kudu/common/scan_predicate.cc
@@ -56,13 +56,11 @@ bool ValueRange::ContainsCell(const void* cell) const {
 
 ////////////////////////////////////////////////////////////
 
-ColumnRangePredicate::ColumnRangePredicate(const ColumnSchema &col,
+ColumnRangePredicate::ColumnRangePredicate(ColumnSchema col,
                                            const void* lower_bound,
-                                           const void* upper_bound) :
-  col_(col),
-  range_(col_.type_info(), lower_bound, upper_bound) {
-}
-
+                                           const void* upper_bound)
+    : col_(std::move(col)),
+      range_(col_.type_info(), lower_bound, upper_bound) {}
 
 void ColumnRangePredicate::Evaluate(RowBlock* block, SelectionVector* vec) const {
   int col_idx = block->schema().find_column(col_.name());

http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/61934118/src/kudu/common/scan_predicate.h
----------------------------------------------------------------------
diff --git a/src/kudu/common/scan_predicate.h b/src/kudu/common/scan_predicate.h
index 1de084f..6d52b7c 100644
--- a/src/kudu/common/scan_predicate.h
+++ b/src/kudu/common/scan_predicate.h
@@ -90,8 +90,7 @@ class ColumnRangePredicate {
   // The range is inclusive on both ends.
   // If either optional is unspecified (i.e. NULL), then the range is
   // open on that end.
-  ColumnRangePredicate(const ColumnSchema &col,
-                       const void* lower_bound,
+  ColumnRangePredicate(ColumnSchema col, const void* lower_bound,
                        const void* upper_bound);
 
   const ColumnSchema &column() const {

http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/61934118/src/kudu/common/schema.h
----------------------------------------------------------------------
diff --git a/src/kudu/common/schema.h b/src/kudu/common/schema.h
index 3788072..463abec 100644
--- a/src/kudu/common/schema.h
+++ b/src/kudu/common/schema.h
@@ -120,17 +120,15 @@ class ColumnSchema {
   //   ColumnSchema col_c("c", INT32, false, &default_i32);
   //   Slice default_str("Hello");
   //   ColumnSchema col_d("d", STRING, false, &default_str);
-  ColumnSchema(const string &name,
-               DataType type,
-               bool is_nullable = false,
-               const void *read_default = NULL,
-               const void *write_default = NULL,
-               ColumnStorageAttributes attributes = ColumnStorageAttributes()) :
-      name_(name),
-      type_info_(GetTypeInfo(type)),
-      is_nullable_(is_nullable),
-      read_default_(read_default ? new Variant(type, read_default) : NULL),
-      attributes_(attributes) {
+  ColumnSchema(string name, DataType type, bool is_nullable = false,
+               const void* read_default = NULL,
+               const void* write_default = NULL,
+               ColumnStorageAttributes attributes = ColumnStorageAttributes())
+      : name_(std::move(name)),
+        type_info_(GetTypeInfo(type)),
+        is_nullable_(is_nullable),
+        read_default_(read_default ? new Variant(type, read_default) : NULL),
+        attributes_(std::move(attributes)) {
     if (write_default == read_default) {
       write_default_ = read_default_;
     } else if (write_default != NULL) {

http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/61934118/src/kudu/consensus/consensus-test-util.h
----------------------------------------------------------------------
diff --git a/src/kudu/consensus/consensus-test-util.h b/src/kudu/consensus/consensus-test-util.h
index 8398230..e8cb3a8 100644
--- a/src/kudu/consensus/consensus-test-util.h
+++ b/src/kudu/consensus/consensus-test-util.h
@@ -420,14 +420,12 @@ class TestPeerMapManager {
 // asynchronously in a ThreadPool.
 class LocalTestPeerProxy : public TestPeerProxy {
  public:
-  LocalTestPeerProxy(const std::string& peer_uuid,
-                     ThreadPool* pool,
+  LocalTestPeerProxy(std::string peer_uuid, ThreadPool* pool,
                      TestPeerMapManager* peers)
-    : TestPeerProxy(pool),
-      peer_uuid_(peer_uuid),
-      peers_(peers),
-      miss_comm_(false) {
-  }
+      : TestPeerProxy(pool),
+        peer_uuid_(std::move(peer_uuid)),
+        peers_(peers),
+        miss_comm_(false) {}
 
   virtual void UpdateAsync(const ConsensusRequestPB* request,
                            ConsensusResponsePB* response,
@@ -692,8 +690,9 @@ class TestTransactionFactory : public ReplicaTransactionFactory {
 // If non-null, the passed hook instance will be called first for all methods.
 class CounterHooks : public Consensus::ConsensusFaultHooks {
  public:
-  explicit CounterHooks(const std::shared_ptr<Consensus::ConsensusFaultHooks>& current_hook)
-      : current_hook_(current_hook),
+  explicit CounterHooks(
+      std::shared_ptr<Consensus::ConsensusFaultHooks> current_hook)
+      : current_hook_(std::move(current_hook)),
         pre_start_calls_(0),
         post_start_calls_(0),
         pre_config_change_calls_(0),
@@ -703,8 +702,7 @@ class CounterHooks : public Consensus::ConsensusFaultHooks {
         pre_update_calls_(0),
         post_update_calls_(0),
         pre_shutdown_calls_(0),
-        post_shutdown_calls_(0) {
-  }
+        post_shutdown_calls_(0) {}
 
   virtual Status PreStart() OVERRIDE {
     if (current_hook_.get()) RETURN_NOT_OK(current_hook_->PreStart());

http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/61934118/src/kudu/consensus/consensus.cc
----------------------------------------------------------------------
diff --git a/src/kudu/consensus/consensus.cc b/src/kudu/consensus/consensus.cc
index 52d2fbd..886367e 100644
--- a/src/kudu/consensus/consensus.cc
+++ b/src/kudu/consensus/consensus.cc
@@ -41,12 +41,11 @@ ConsensusBootstrapInfo::~ConsensusBootstrapInfo() {
 
 ConsensusRound::ConsensusRound(Consensus* consensus,
                                gscoped_ptr<ReplicateMsg> replicate_msg,
-                               const ConsensusReplicatedCallback& replicated_cb)
+                               ConsensusReplicatedCallback replicated_cb)
     : consensus_(consensus),
       replicate_msg_(new RefCountedReplicate(replicate_msg.release())),
-      replicated_cb_(replicated_cb),
-      bound_term_(-1) {
-}
+      replicated_cb_(std::move(replicated_cb)),
+      bound_term_(-1) {}
 
 ConsensusRound::ConsensusRound(Consensus* consensus,
                                const ReplicateRefPtr& replicate_msg)

http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/61934118/src/kudu/consensus/consensus.h
----------------------------------------------------------------------
diff --git a/src/kudu/consensus/consensus.h b/src/kudu/consensus/consensus.h
index aea8230..db44d4b 100644
--- a/src/kudu/consensus/consensus.h
+++ b/src/kudu/consensus/consensus.h
@@ -329,9 +329,8 @@ class ConsensusRound : public RefCountedThreadSafe<ConsensusRound> {
  public:
   // Ctor used for leader transactions. Leader transactions can and must specify the
   // callbacks prior to initiating the consensus round.
-  ConsensusRound(Consensus* consensus,
-                 gscoped_ptr<ReplicateMsg> replicate_msg,
-                 const ConsensusReplicatedCallback& replicated_cb);
+  ConsensusRound(Consensus* consensus, gscoped_ptr<ReplicateMsg> replicate_msg,
+                 ConsensusReplicatedCallback replicated_cb);
 
   // Ctor used for follower/learner transactions. These transactions do not use the
   // replicate callback and the commit callback is set later, after the transaction

http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/61934118/src/kudu/consensus/consensus_meta.cc
----------------------------------------------------------------------
diff --git a/src/kudu/consensus/consensus_meta.cc b/src/kudu/consensus/consensus_meta.cc
index 338f52b..d6cf74a 100644
--- a/src/kudu/consensus/consensus_meta.cc
+++ b/src/kudu/consensus/consensus_meta.cc
@@ -214,13 +214,12 @@ Status ConsensusMetadata::Flush() {
 }
 
 ConsensusMetadata::ConsensusMetadata(FsManager* fs_manager,
-                                     const std::string& tablet_id,
-                                     const std::string& peer_uuid)
+                                     std::string tablet_id,
+                                     std::string peer_uuid)
     : fs_manager_(CHECK_NOTNULL(fs_manager)),
-      tablet_id_(tablet_id),
-      peer_uuid_(peer_uuid),
-      has_pending_config_(false) {
-}
+      tablet_id_(std::move(tablet_id)),
+      peer_uuid_(std::move(peer_uuid)),
+      has_pending_config_(false) {}
 
 std::string ConsensusMetadata::LogPrefix() const {
   return Substitute("T $0 P $1: ", tablet_id_, peer_uuid_);

http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/61934118/src/kudu/consensus/consensus_meta.h
----------------------------------------------------------------------
diff --git a/src/kudu/consensus/consensus_meta.h b/src/kudu/consensus/consensus_meta.h
index 1cafcb0..af1424a 100644
--- a/src/kudu/consensus/consensus_meta.h
+++ b/src/kudu/consensus/consensus_meta.h
@@ -139,9 +139,8 @@ class ConsensusMetadata {
   Status Flush();
 
  private:
-  ConsensusMetadata(FsManager* fs_manager,
-                    const std::string& tablet_id,
-                    const std::string& peer_uuid);
+  ConsensusMetadata(FsManager* fs_manager, std::string tablet_id,
+                    std::string peer_uuid);
 
   std::string LogPrefix() const;
 

http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/61934118/src/kudu/consensus/consensus_peers.cc
----------------------------------------------------------------------
diff --git a/src/kudu/consensus/consensus_peers.cc b/src/kudu/consensus/consensus_peers.cc
index 4dbccde..6879451 100644
--- a/src/kudu/consensus/consensus_peers.cc
+++ b/src/kudu/consensus/consensus_peers.cc
@@ -92,25 +92,22 @@ Status Peer::NewRemotePeer(const RaftPeerPB& peer_pb,
   return Status::OK();
 }
 
-Peer::Peer(const RaftPeerPB& peer_pb,
-           const string& tablet_id,
-           const string& leader_uuid,
-           gscoped_ptr<PeerProxy> proxy,
-           PeerMessageQueue* queue,
+Peer::Peer(const RaftPeerPB& peer_pb, string tablet_id, string leader_uuid,
+           gscoped_ptr<PeerProxy> proxy, PeerMessageQueue* queue,
            ThreadPool* thread_pool)
-    : tablet_id_(tablet_id),
-      leader_uuid_(leader_uuid),
+    : tablet_id_(std::move(tablet_id)),
+      leader_uuid_(std::move(leader_uuid)),
       peer_pb_(peer_pb),
       proxy_(proxy.Pass()),
       queue_(queue),
       failed_attempts_(0),
       sem_(1),
-      heartbeater_(peer_pb.permanent_uuid(),
-                   MonoDelta::FromMilliseconds(FLAGS_raft_heartbeat_interval_ms),
-                   boost::bind(&Peer::SignalRequest, this, true)),
+      heartbeater_(
+          peer_pb.permanent_uuid(),
+          MonoDelta::FromMilliseconds(FLAGS_raft_heartbeat_interval_ms),
+          boost::bind(&Peer::SignalRequest, this, true)),
       thread_pool_(thread_pool),
-      state_(kPeerCreated) {
-}
+      state_(kPeerCreated) {}
 
 void Peer::SetTermForTest(int term) {
   response_.set_responder_term(term);
@@ -399,9 +396,8 @@ Status CreateConsensusServiceProxyForHost(const shared_ptr<Messenger>& messenger
 
 } // anonymous namespace
 
-RpcPeerProxyFactory::RpcPeerProxyFactory(const shared_ptr<Messenger>& messenger)
-    : messenger_(messenger) {
-}
+RpcPeerProxyFactory::RpcPeerProxyFactory(shared_ptr<Messenger> messenger)
+    : messenger_(std::move(messenger)) {}
 
 Status RpcPeerProxyFactory::NewProxy(const RaftPeerPB& peer_pb,
                                      gscoped_ptr<PeerProxy>* proxy) {

http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/61934118/src/kudu/consensus/consensus_peers.h
----------------------------------------------------------------------
diff --git a/src/kudu/consensus/consensus_peers.h b/src/kudu/consensus/consensus_peers.h
index ddb8b1e..e10856f 100644
--- a/src/kudu/consensus/consensus_peers.h
+++ b/src/kudu/consensus/consensus_peers.h
@@ -145,11 +145,8 @@ class Peer {
                               gscoped_ptr<Peer>* peer);
 
  private:
-  Peer(const RaftPeerPB& peer,
-       const std::string& tablet_id,
-       const std::string& leader_uuid,
-       gscoped_ptr<PeerProxy> proxy,
-       PeerMessageQueue* queue,
+  Peer(const RaftPeerPB& peer, std::string tablet_id, std::string leader_uuid,
+       gscoped_ptr<PeerProxy> proxy, PeerMessageQueue* queue,
        ThreadPool* thread_pool);
 
   void SendNextRequest(bool even_if_queue_empty);
@@ -305,7 +302,7 @@ class RpcPeerProxy : public PeerProxy {
 // PeerProxyFactory implementation that generates RPCPeerProxies
 class RpcPeerProxyFactory : public PeerProxyFactory {
  public:
-  explicit RpcPeerProxyFactory(const std::shared_ptr<rpc::Messenger>& messenger);
+  explicit RpcPeerProxyFactory(std::shared_ptr<rpc::Messenger> messenger);
 
   virtual Status NewProxy(const RaftPeerPB& peer_pb,
                           gscoped_ptr<PeerProxy>* proxy) OVERRIDE;

http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/61934118/src/kudu/consensus/consensus_queue.h
----------------------------------------------------------------------
diff --git a/src/kudu/consensus/consensus_queue.h b/src/kudu/consensus/consensus_queue.h
index 69c08d8..6c22f68 100644
--- a/src/kudu/consensus/consensus_queue.h
+++ b/src/kudu/consensus/consensus_queue.h
@@ -67,17 +67,16 @@ extern const char kConsensusQueueParentTrackerId[];
 class PeerMessageQueue {
  public:
   struct TrackedPeer {
-    explicit TrackedPeer(const std::string& uuid)
-      : uuid(uuid),
-        is_new(true),
-        next_index(kInvalidOpIdIndex),
-        last_received(MinimumOpId()),
-        last_known_committed_idx(MinimumOpId().index()),
-        is_last_exchange_successful(false),
-        last_successful_communication_time(MonoTime::Now(MonoTime::FINE)),
-        needs_remote_bootstrap(false),
-        last_seen_term_(0) {
-    }
+    explicit TrackedPeer(std::string uuid)
+        : uuid(std::move(uuid)),
+          is_new(true),
+          next_index(kInvalidOpIdIndex),
+          last_received(MinimumOpId()),
+          last_known_committed_idx(MinimumOpId().index()),
+          is_last_exchange_successful(false),
+          last_successful_communication_time(MonoTime::Now(MonoTime::FINE)),
+          needs_remote_bootstrap(false),
+          last_seen_term_(0) {}
 
     // Check that the terms seen from a given peer only increase
     // monotonically.

http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/61934118/src/kudu/consensus/leader_election.cc
----------------------------------------------------------------------
diff --git a/src/kudu/consensus/leader_election.cc b/src/kudu/consensus/leader_election.cc
index 5c01db0..f7d4630 100644
--- a/src/kudu/consensus/leader_election.cc
+++ b/src/kudu/consensus/leader_election.cc
@@ -154,14 +154,13 @@ LeaderElection::LeaderElection(const RaftConfigPB& config,
                                PeerProxyFactory* proxy_factory,
                                const VoteRequestPB& request,
                                gscoped_ptr<VoteCounter> vote_counter,
-                               const MonoDelta& timeout,
-                               const ElectionDecisionCallback& decision_callback)
-  : has_responded_(false),
-    request_(request),
-    vote_counter_(vote_counter.Pass()),
-    timeout_(timeout),
-    decision_callback_(decision_callback) {
-
+                               MonoDelta timeout,
+                               ElectionDecisionCallback decision_callback)
+    : has_responded_(false),
+      request_(request),
+      vote_counter_(vote_counter.Pass()),
+      timeout_(std::move(timeout)),
+      decision_callback_(std::move(decision_callback)) {
   for (const RaftPeerPB& peer : config.peers()) {
     if (request.candidate_uuid() == peer.permanent_uuid()) continue;
     follower_uuids_.push_back(peer.permanent_uuid());

http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/61934118/src/kudu/consensus/leader_election.h
----------------------------------------------------------------------
diff --git a/src/kudu/consensus/leader_election.h b/src/kudu/consensus/leader_election.h
index c44f1ae..394bca4 100644
--- a/src/kudu/consensus/leader_election.h
+++ b/src/kudu/consensus/leader_election.h
@@ -153,12 +153,10 @@ class LeaderElection : public RefCountedThreadSafe<LeaderElection> {
   // Set up a new leader election driver.
   //
   // The 'vote_counter' must be initialized with the candidate's own yes vote.
-  LeaderElection(const RaftConfigPB& config,
-                 PeerProxyFactory* proxy_factory,
+  LeaderElection(const RaftConfigPB& config, PeerProxyFactory* proxy_factory,
                  const VoteRequestPB& request,
-                 gscoped_ptr<VoteCounter> vote_counter,
-                 const MonoDelta& timeout,
-                 const ElectionDecisionCallback& decision_callback);
+                 gscoped_ptr<VoteCounter> vote_counter, MonoDelta timeout,
+                 ElectionDecisionCallback decision_callback);
 
   // Run the election: send the vote request to followers.
   void Run();

http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/61934118/src/kudu/consensus/local_consensus.cc
----------------------------------------------------------------------
diff --git a/src/kudu/consensus/local_consensus.cc b/src/kudu/consensus/local_consensus.cc
index b378bf3..9154032 100644
--- a/src/kudu/consensus/local_consensus.cc
+++ b/src/kudu/consensus/local_consensus.cc
@@ -37,14 +37,13 @@ using log::Log;
 using log::LogEntryBatch;
 using strings::Substitute;
 
-LocalConsensus::LocalConsensus(const ConsensusOptions& options,
+LocalConsensus::LocalConsensus(ConsensusOptions options,
                                gscoped_ptr<ConsensusMetadata> cmeta,
-                               const string& peer_uuid,
+                               string peer_uuid,
                                const scoped_refptr<server::Clock>& clock,
-                               ReplicaTransactionFactory* txn_factory,
-                               Log* log)
-    : peer_uuid_(peer_uuid),
-      options_(options),
+                               ReplicaTransactionFactory* txn_factory, Log* log)
+    : peer_uuid_(std::move(peer_uuid)),
+      options_(std::move(options)),
       cmeta_(cmeta.Pass()),
       txn_factory_(DCHECK_NOTNULL(txn_factory)),
       log_(DCHECK_NOTNULL(log)),

http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/61934118/src/kudu/consensus/local_consensus.h
----------------------------------------------------------------------
diff --git a/src/kudu/consensus/local_consensus.h b/src/kudu/consensus/local_consensus.h
index 8eb0497..9e5f799 100644
--- a/src/kudu/consensus/local_consensus.h
+++ b/src/kudu/consensus/local_consensus.h
@@ -46,9 +46,9 @@ namespace consensus {
 // This class is not thread safe.
 class LocalConsensus : public Consensus {
  public:
-  explicit LocalConsensus(const ConsensusOptions& options,
+  explicit LocalConsensus(ConsensusOptions options,
                           gscoped_ptr<ConsensusMetadata> cmeta,
-                          const std::string& peer_uuid,
+                          std::string peer_uuid,
                           const scoped_refptr<server::Clock>& clock,
                           ReplicaTransactionFactory* txn_factory,
                           log::Log* log);

http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/61934118/src/kudu/consensus/log.cc
----------------------------------------------------------------------
diff --git a/src/kudu/consensus/log.cc b/src/kudu/consensus/log.cc
index 7285025..f5c6960 100644
--- a/src/kudu/consensus/log.cc
+++ b/src/kudu/consensus/log.cc
@@ -276,28 +276,24 @@ Status Log::Open(const LogOptions &options,
   return Status::OK();
 }
 
-Log::Log(const LogOptions &options,
-         FsManager *fs_manager,
-         const string& log_path,
-         const string& tablet_id,
-         const Schema& schema,
-         uint32_t schema_version,
+Log::Log(LogOptions options, FsManager* fs_manager, string log_path,
+         string tablet_id, const Schema& schema, uint32_t schema_version,
          const scoped_refptr<MetricEntity>& metric_entity)
-  : options_(options),
-    fs_manager_(fs_manager),
-    log_dir_(log_path),
-    tablet_id_(tablet_id),
-    schema_(schema),
-    schema_version_(schema_version),
-    active_segment_sequence_number_(0),
-    log_state_(kLogInitialized),
-    max_segment_size_(options_.segment_size_mb * 1024 * 1024),
-    entry_batch_queue_(FLAGS_group_commit_queue_size_bytes),
-    append_thread_(new AppendThread(this)),
-    force_sync_all_(options_.force_fsync_all),
-    sync_disabled_(false),
-    allocation_state_(kAllocationNotStarted),
-    metric_entity_(metric_entity) {
+    : options_(std::move(options)),
+      fs_manager_(fs_manager),
+      log_dir_(std::move(log_path)),
+      tablet_id_(std::move(tablet_id)),
+      schema_(schema),
+      schema_version_(schema_version),
+      active_segment_sequence_number_(0),
+      log_state_(kLogInitialized),
+      max_segment_size_(options_.segment_size_mb * 1024 * 1024),
+      entry_batch_queue_(FLAGS_group_commit_queue_size_bytes),
+      append_thread_(new AppendThread(this)),
+      force_sync_all_(options_.force_fsync_all),
+      sync_disabled_(false),
+      allocation_state_(kAllocationNotStarted),
+      metric_entity_(metric_entity) {
   CHECK_OK(ThreadPoolBuilder("log-alloc").set_max_threads(1).Build(&allocation_pool_));
   if (metric_entity_) {
     metrics_.reset(new LogMetrics(metric_entity_));

http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/61934118/src/kudu/consensus/log.h
----------------------------------------------------------------------
diff --git a/src/kudu/consensus/log.h b/src/kudu/consensus/log.h
index 8c4b1e7..642319b 100644
--- a/src/kudu/consensus/log.h
+++ b/src/kudu/consensus/log.h
@@ -251,12 +251,8 @@ class Log : public RefCountedThreadSafe<Log> {
     kAllocationFinished // Next segment ready
   };
 
-  Log(const LogOptions &options,
-      FsManager *fs_manager,
-      const std::string& log_path,
-      const std::string& tablet_id,
-      const Schema& schema,
-      uint32_t schema_version,
+  Log(LogOptions options, FsManager* fs_manager, std::string log_path,
+      std::string tablet_id, const Schema& schema, uint32_t schema_version,
       const scoped_refptr<MetricEntity>& metric_entity);
 
   // Initializes a new one or continues an existing log.

http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/61934118/src/kudu/consensus/log_anchor_registry.cc
----------------------------------------------------------------------
diff --git a/src/kudu/consensus/log_anchor_registry.cc b/src/kudu/consensus/log_anchor_registry.cc
index d310d66..b139cb8 100644
--- a/src/kudu/consensus/log_anchor_registry.cc
+++ b/src/kudu/consensus/log_anchor_registry.cc
@@ -142,11 +142,11 @@ LogAnchor::~LogAnchor() {
   CHECK(!is_registered) << "Attempted to destruct a registered LogAnchor";
 }
 
-MinLogIndexAnchorer::MinLogIndexAnchorer(LogAnchorRegistry* registry, const string& owner)
-  : registry_(DCHECK_NOTNULL(registry)),
-    owner_(owner),
-    minimum_log_index_(kInvalidOpIdIndex) {
-}
+MinLogIndexAnchorer::MinLogIndexAnchorer(LogAnchorRegistry* registry,
+                                         string owner)
+    : registry_(DCHECK_NOTNULL(registry)),
+      owner_(std::move(owner)),
+      minimum_log_index_(kInvalidOpIdIndex) {}
 
 MinLogIndexAnchorer::~MinLogIndexAnchorer() {
   CHECK_OK(ReleaseAnchor());

http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/61934118/src/kudu/consensus/log_anchor_registry.h
----------------------------------------------------------------------
diff --git a/src/kudu/consensus/log_anchor_registry.h b/src/kudu/consensus/log_anchor_registry.h
index 6ba7e6b..aaf5c8d 100644
--- a/src/kudu/consensus/log_anchor_registry.h
+++ b/src/kudu/consensus/log_anchor_registry.h
@@ -127,7 +127,7 @@ class MinLogIndexAnchorer {
  public:
   // Construct anchorer for specified registry that will register anchors with
   // the specified owner name.
-  MinLogIndexAnchorer(LogAnchorRegistry* registry, const std::string& owner);
+  MinLogIndexAnchorer(LogAnchorRegistry* registry, std::string owner);
 
   // The destructor will unregister the anchor if it is registered.
   ~MinLogIndexAnchorer();

http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/61934118/src/kudu/consensus/log_index.cc
----------------------------------------------------------------------
diff --git a/src/kudu/consensus/log_index.cc b/src/kudu/consensus/log_index.cc
index 06e3e94..6da0a9a 100644
--- a/src/kudu/consensus/log_index.cc
+++ b/src/kudu/consensus/log_index.cc
@@ -73,7 +73,7 @@ static const int64_t kChunkFileSize = kEntriesPerIndexChunk * sizeof(PhysicalEnt
 // This class maintains the open file descriptor and mapped memory.
 class LogIndex::IndexChunk : public RefCountedThreadSafe<LogIndex::IndexChunk> {
  public:
-  explicit IndexChunk(const string& path);
+  explicit IndexChunk(string path);
   ~IndexChunk();
 
   // Open and map the memory.
@@ -97,11 +97,8 @@ Status CheckError(int rc, const char* operation) {
 }
 } // anonymous namespace
 
-LogIndex::IndexChunk::IndexChunk(const std::string& path)
-  : path_(path),
-    fd_(-1),
-    mapping_(nullptr) {
-}
+LogIndex::IndexChunk::IndexChunk(std::string path)
+    : path_(std::move(path)), fd_(-1), mapping_(nullptr) {}
 
 LogIndex::IndexChunk::~IndexChunk() {
   if (mapping_ != nullptr) {
@@ -149,9 +146,7 @@ void LogIndex::IndexChunk::SetEntry(int entry_index, const PhysicalEntry& phys)
 // LogIndex
 ////////////////////////////////////////////////////////////
 
-LogIndex::LogIndex(const std::string& base_dir)
-  : base_dir_(base_dir) {
-}
+LogIndex::LogIndex(std::string base_dir) : base_dir_(std::move(base_dir)) {}
 
 LogIndex::~LogIndex() {
 }

http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/61934118/src/kudu/consensus/log_index.h
----------------------------------------------------------------------
diff --git a/src/kudu/consensus/log_index.h b/src/kudu/consensus/log_index.h
index a749f08..7d12ecd 100644
--- a/src/kudu/consensus/log_index.h
+++ b/src/kudu/consensus/log_index.h
@@ -58,7 +58,7 @@ struct LogIndexEntry {
 // See .cc file for implementation notes.
 class LogIndex : public RefCountedThreadSafe<LogIndex> {
  public:
-  explicit LogIndex(const std::string& base_dir);
+  explicit LogIndex(std::string base_dir);
 
   // Record an index entry in the index.
   Status AddEntry(const LogIndexEntry& entry);

http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/61934118/src/kudu/consensus/log_reader.cc
----------------------------------------------------------------------
diff --git a/src/kudu/consensus/log_reader.cc b/src/kudu/consensus/log_reader.cc
index 8faeb29..72b9513 100644
--- a/src/kudu/consensus/log_reader.cc
+++ b/src/kudu/consensus/log_reader.cc
@@ -97,14 +97,14 @@ Status LogReader::OpenFromRecoveryDir(FsManager *fs_manager,
   return Status::OK();
 }
 
-LogReader::LogReader(FsManager *fs_manager,
+LogReader::LogReader(FsManager* fs_manager,
                      const scoped_refptr<LogIndex>& index,
-                     const string& tablet_id,
+                     string tablet_id,
                      const scoped_refptr<MetricEntity>& metric_entity)
-  : fs_manager_(fs_manager),
-    log_index_(index),
-    tablet_id_(tablet_id),
-    state_(kLogReaderInitialized) {
+    : fs_manager_(fs_manager),
+      log_index_(index),
+      tablet_id_(std::move(tablet_id)),
+      state_(kLogReaderInitialized) {
   if (metric_entity) {
     bytes_read_ = METRIC_log_reader_bytes_read.Instantiate(metric_entity);
     entries_read_ = METRIC_log_reader_entries_read.Instantiate(metric_entity);

http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/61934118/src/kudu/consensus/log_reader.h
----------------------------------------------------------------------
diff --git a/src/kudu/consensus/log_reader.h b/src/kudu/consensus/log_reader.h
index 3fcf3e3..3712af4 100644
--- a/src/kudu/consensus/log_reader.h
+++ b/src/kudu/consensus/log_reader.h
@@ -171,10 +171,8 @@ class LogReader {
                                   faststring* tmp_buf,
                                   gscoped_ptr<LogEntryBatchPB>* batch) const;
 
-
-  LogReader(FsManager *fs_manager,
-            const scoped_refptr<LogIndex>& index,
-            const std::string& tablet_name,
+  LogReader(FsManager* fs_manager, const scoped_refptr<LogIndex>& index,
+            std::string tablet_name,
             const scoped_refptr<MetricEntity>& metric_entity);
 
   // Reads the headers of all segments in 'path_'.

http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/61934118/src/kudu/consensus/log_util.cc
----------------------------------------------------------------------
diff --git a/src/kudu/consensus/log_util.cc b/src/kudu/consensus/log_util.cc
index 9e39629..5e79bfd 100644
--- a/src/kudu/consensus/log_util.cc
+++ b/src/kudu/consensus/log_util.cc
@@ -110,15 +110,14 @@ Status ReadableLogSegment::Open(Env* env,
   return Status::OK();
 }
 
-ReadableLogSegment::ReadableLogSegment(const std::string &path,
-                                       const shared_ptr<RandomAccessFile>& readable_file)
-  : path_(path),
-    file_size_(0),
-    readable_to_offset_(0),
-    readable_file_(readable_file),
-    is_initialized_(false),
-    footer_was_rebuilt_(false) {
-}
+ReadableLogSegment::ReadableLogSegment(
+    std::string path, shared_ptr<RandomAccessFile> readable_file)
+    : path_(std::move(path)),
+      file_size_(0),
+      readable_to_offset_(0),
+      readable_file_(std::move(readable_file)),
+      is_initialized_(false),
+      footer_was_rebuilt_(false) {}
 
 Status ReadableLogSegment::Init(const LogSegmentHeaderPB& header,
                                 const LogSegmentFooterPB& footer,
@@ -685,16 +684,13 @@ Status ReadableLogSegment::ReadEntryBatch(int64_t *offset,
   return Status::OK();
 }
 
-
-WritableLogSegment::WritableLogSegment(
-    const string &path,
-    const shared_ptr<WritableFile>& writable_file)
-: path_(path),
-  writable_file_(writable_file),
-  is_header_written_(false),
-  is_footer_written_(false),
-  written_offset_(0) {
-}
+WritableLogSegment::WritableLogSegment(string path,
+                                       shared_ptr<WritableFile> writable_file)
+    : path_(std::move(path)),
+      writable_file_(std::move(writable_file)),
+      is_header_written_(false),
+      is_footer_written_(false),
+      written_offset_(0) {}
 
 Status WritableLogSegment::WriteHeaderAndOpen(const LogSegmentHeaderPB& new_header) {
   DCHECK(!IsHeaderWritten()) << "Can only call WriteHeader() once";

http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/61934118/src/kudu/consensus/log_util.h
----------------------------------------------------------------------
diff --git a/src/kudu/consensus/log_util.h b/src/kudu/consensus/log_util.h
index 6bac7c2..387977a 100644
--- a/src/kudu/consensus/log_util.h
+++ b/src/kudu/consensus/log_util.h
@@ -94,8 +94,8 @@ class ReadableLogSegment : public RefCountedThreadSafe<ReadableLogSegment> {
                      scoped_refptr<ReadableLogSegment>* segment);
 
   // Build a readable segment to read entries from the provided path.
-  ReadableLogSegment(const std::string &path,
-                     const std::shared_ptr<RandomAccessFile>& readable_file);
+  ReadableLogSegment(std::string path,
+                     std::shared_ptr<RandomAccessFile> readable_file);
 
   // Initialize the ReadableLogSegment.
   // This initializer provides methods for avoiding disk IO when creating a
@@ -292,8 +292,8 @@ class ReadableLogSegment : public RefCountedThreadSafe<ReadableLogSegment> {
 // A writable log segment where state data is stored.
 class WritableLogSegment {
  public:
-  WritableLogSegment(const std::string &path,
-                     const std::shared_ptr<WritableFile>& writable_file);
+  WritableLogSegment(std::string path,
+                     std::shared_ptr<WritableFile> writable_file);
 
   // Opens the segment by writing the header.
   Status WriteHeaderAndOpen(const LogSegmentHeaderPB& new_header);

http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/61934118/src/kudu/consensus/raft_consensus.cc
----------------------------------------------------------------------
diff --git a/src/kudu/consensus/raft_consensus.cc b/src/kudu/consensus/raft_consensus.cc
index 213bf56..f03f09f 100644
--- a/src/kudu/consensus/raft_consensus.cc
+++ b/src/kudu/consensus/raft_consensus.cc
@@ -196,19 +196,16 @@ scoped_refptr<RaftConsensus> RaftConsensus::Create(
                               mark_dirty_clbk));
 }
 
-RaftConsensus::RaftConsensus(const ConsensusOptions& options,
-                             gscoped_ptr<ConsensusMetadata> cmeta,
-                             gscoped_ptr<PeerProxyFactory> proxy_factory,
-                             gscoped_ptr<PeerMessageQueue> queue,
-                             gscoped_ptr<PeerManager> peer_manager,
-                             gscoped_ptr<ThreadPool> thread_pool,
-                             const scoped_refptr<MetricEntity>& metric_entity,
-                             const std::string& peer_uuid,
-                             const scoped_refptr<server::Clock>& clock,
-                             ReplicaTransactionFactory* txn_factory,
-                             const scoped_refptr<log::Log>& log,
-                             const shared_ptr<MemTracker>& parent_mem_tracker,
-                             const Callback<void(const std::string& reason)>& mark_dirty_clbk)
+RaftConsensus::RaftConsensus(
+    const ConsensusOptions& options, gscoped_ptr<ConsensusMetadata> cmeta,
+    gscoped_ptr<PeerProxyFactory> proxy_factory,
+    gscoped_ptr<PeerMessageQueue> queue, gscoped_ptr<PeerManager> peer_manager,
+    gscoped_ptr<ThreadPool> thread_pool,
+    const scoped_refptr<MetricEntity>& metric_entity,
+    const std::string& peer_uuid, const scoped_refptr<server::Clock>& clock,
+    ReplicaTransactionFactory* txn_factory, const scoped_refptr<log::Log>& log,
+    shared_ptr<MemTracker> parent_mem_tracker,
+    Callback<void(const std::string& reason)> mark_dirty_clbk)
     : thread_pool_(thread_pool.Pass()),
       log_(log),
       clock_(clock),
@@ -216,21 +213,19 @@ RaftConsensus::RaftConsensus(const ConsensusOptions& options,
       peer_manager_(peer_manager.Pass()),
       queue_(queue.Pass()),
       rng_(GetRandomSeed32()),
-      failure_monitor_(GetRandomSeed32(),
-                       GetFailureMonitorCheckMeanMs(),
+      failure_monitor_(GetRandomSeed32(), GetFailureMonitorCheckMeanMs(),
                        GetFailureMonitorCheckStddevMs()),
-      failure_detector_(new TimedFailureDetector(
-          MonoDelta::FromMilliseconds(
-              FLAGS_raft_heartbeat_interval_ms *
-              FLAGS_leader_failure_max_missed_heartbeat_periods))),
+      failure_detector_(new TimedFailureDetector(MonoDelta::FromMilliseconds(
+          FLAGS_raft_heartbeat_interval_ms *
+          FLAGS_leader_failure_max_missed_heartbeat_periods))),
       withhold_votes_until_(MonoTime::Min()),
-      mark_dirty_clbk_(mark_dirty_clbk),
+      mark_dirty_clbk_(std::move(mark_dirty_clbk)),
       shutdown_(false),
       follower_memory_pressure_rejections_(metric_entity->FindOrCreateCounter(
           &METRIC_follower_memory_pressure_rejections)),
       term_metric_(metric_entity->FindOrCreateGauge(&METRIC_raft_term,
                                                     cmeta->current_term())),
-      parent_mem_tracker_(parent_mem_tracker) {
+      parent_mem_tracker_(std::move(parent_mem_tracker)) {
   DCHECK_NOTNULL(log_.get());
   state_.reset(new ReplicaState(options,
                                 peer_uuid,

http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/61934118/src/kudu/consensus/raft_consensus.h
----------------------------------------------------------------------
diff --git a/src/kudu/consensus/raft_consensus.h b/src/kudu/consensus/raft_consensus.h
index cb10223..2f84fde 100644
--- a/src/kudu/consensus/raft_consensus.h
+++ b/src/kudu/consensus/raft_consensus.h
@@ -85,8 +85,8 @@ class RaftConsensus : public Consensus,
                 const scoped_refptr<server::Clock>& clock,
                 ReplicaTransactionFactory* txn_factory,
                 const scoped_refptr<log::Log>& log,
-                const std::shared_ptr<MemTracker>& parent_mem_tracker,
-                const Callback<void(const std::string& reason)>& mark_dirty_clbk);
+                std::shared_ptr<MemTracker> parent_mem_tracker,
+                Callback<void(const std::string& reason)> mark_dirty_clbk);
 
   virtual ~RaftConsensus();
 

http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/61934118/src/kudu/consensus/raft_consensus_state.cc
----------------------------------------------------------------------
diff --git a/src/kudu/consensus/raft_consensus_state.cc b/src/kudu/consensus/raft_consensus_state.cc
index e962da1..44aed84 100644
--- a/src/kudu/consensus/raft_consensus_state.cc
+++ b/src/kudu/consensus/raft_consensus_state.cc
@@ -40,19 +40,18 @@ using strings::SubstituteAndAppend;
 // ReplicaState
 //////////////////////////////////////////////////
 
-ReplicaState::ReplicaState(const ConsensusOptions& options,
-                           const string& peer_uuid,
+ReplicaState::ReplicaState(ConsensusOptions options, string peer_uuid,
                            gscoped_ptr<ConsensusMetadata> cmeta,
                            ReplicaTransactionFactory* txn_factory)
-  : options_(options),
-    peer_uuid_(peer_uuid),
-    cmeta_(cmeta.Pass()),
-    next_index_(0),
-    txn_factory_(txn_factory),
-    last_received_op_id_(MinimumOpId()),
-    last_received_op_id_current_leader_(MinimumOpId()),
-    last_committed_index_(MinimumOpId()),
-    state_(kInitialized) {
+    : options_(std::move(options)),
+      peer_uuid_(std::move(peer_uuid)),
+      cmeta_(cmeta.Pass()),
+      next_index_(0),
+      txn_factory_(txn_factory),
+      last_received_op_id_(MinimumOpId()),
+      last_received_op_id_current_leader_(MinimumOpId()),
+      last_committed_index_(MinimumOpId()),
+      state_(kInitialized) {
   CHECK(cmeta_) << "ConsensusMeta passed as NULL";
 }
 

http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/61934118/src/kudu/consensus/raft_consensus_state.h
----------------------------------------------------------------------
diff --git a/src/kudu/consensus/raft_consensus_state.h b/src/kudu/consensus/raft_consensus_state.h
index 20a98c5..a849cfc 100644
--- a/src/kudu/consensus/raft_consensus_state.h
+++ b/src/kudu/consensus/raft_consensus_state.h
@@ -94,8 +94,7 @@ class ReplicaState {
 
   typedef IndexToRoundMap::value_type IndexToRoundEntry;
 
-  ReplicaState(const ConsensusOptions& options,
-               const std::string& peer_uuid,
+  ReplicaState(ConsensusOptions options, std::string peer_uuid,
                gscoped_ptr<ConsensusMetadata> cmeta,
                ReplicaTransactionFactory* txn_factory);
 

http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/61934118/src/kudu/fs/block_manager_util.cc
----------------------------------------------------------------------
diff --git a/src/kudu/fs/block_manager_util.cc b/src/kudu/fs/block_manager_util.cc
index 2865e04..79c13b5 100644
--- a/src/kudu/fs/block_manager_util.cc
+++ b/src/kudu/fs/block_manager_util.cc
@@ -42,12 +42,11 @@ using std::vector;
 using strings::Substitute;
 
 PathInstanceMetadataFile::PathInstanceMetadataFile(Env* env,
-                                                   const string& block_manager_type,
-                                                   const string& filename)
-  : env_(env),
-    block_manager_type_(block_manager_type),
-    filename_(filename) {
-}
+                                                   string block_manager_type,
+                                                   string filename)
+    : env_(env),
+      block_manager_type_(std::move(block_manager_type)),
+      filename_(std::move(filename)) {}
 
 PathInstanceMetadataFile::~PathInstanceMetadataFile() {
   if (lock_) {



Mime
View raw message