kudu-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From t...@apache.org
Subject incubator-kudu git commit: client_samples-test: wait for processes to exit after kill -9
Date Sat, 16 Jan 2016 02:19:45 GMT
Repository: incubator-kudu
Updated Branches:
  refs/heads/master 704496559 -> 79130fc0a


client_samples-test: wait for processes to exit after kill -9

kill -9 doesn't guarantee immediate delivery of the signal to the target
process. In particular, if the process is in an uninterruptible sleep
state inside the kernel, it may be some small amount of time before
it actually exits. During this time, it's possible it could proceed
and create new files on disk, etc. This might cause occasional failures
of the 'rm -rf' call following the kills in this test case -- a behavior
we're seeing occasionally on Jenkins.

Change-Id: I2ba711723b327168be942405b5354ca57c106043
Reviewed-on: http://gerrit.cloudera.org:8080/1795
Reviewed-by: Adar Dembo <adar@cloudera.com>
Tested-by: Internal Jenkins


Project: http://git-wip-us.apache.org/repos/asf/incubator-kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-kudu/commit/79130fc0
Tree: http://git-wip-us.apache.org/repos/asf/incubator-kudu/tree/79130fc0
Diff: http://git-wip-us.apache.org/repos/asf/incubator-kudu/diff/79130fc0

Branch: refs/heads/master
Commit: 79130fc0afff08d3476794d0bb0d8e76fde54340
Parents: 7044965
Author: Todd Lipcon <todd@apache.org>
Authored: Thu Jan 14 23:57:49 2016 -0800
Committer: Todd Lipcon <todd@apache.org>
Committed: Sat Jan 16 02:16:46 2016 +0000

----------------------------------------------------------------------
 src/kudu/client/client_samples-test.sh | 2 ++
 1 file changed, 2 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/79130fc0/src/kudu/client/client_samples-test.sh
----------------------------------------------------------------------
diff --git a/src/kudu/client/client_samples-test.sh b/src/kudu/client/client_samples-test.sh
index 7b43444..296bcb2 100755
--- a/src/kudu/client/client_samples-test.sh
+++ b/src/kudu/client/client_samples-test.sh
@@ -26,9 +26,11 @@ set -e
 cleanup() {
   if [ -n "$TS_PID" ]; then
       kill -9 "$TS_PID" || :
+      wait $TS_PID || :
   fi
   if [ -n "$MASTER_PID" ]; then
       kill -9 "$MASTER_PID" || :
+      wait $MASTER_PID || :
   fi
   if [ -n "$BASE_DIR" -a -d "$BASE_DIR" ]; then
       rm -rf "$BASE_DIR"


Mime
View raw message