kudu-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From t...@apache.org
Subject [4/8] incubator-kudu git commit: dist_test: upload only the required shared libraries from thirdparty
Date Mon, 11 Jan 2016 09:19:10 GMT
dist_test: upload only the required shared libraries from thirdparty

Uploading the entire thirdparty/lib/ directory is wasteful, since it includes a
lot of static libraries which aren't needed at runtime. This decreases the
amount of data that has to be uploaded for a dist-test run substantially.

Change-Id: I8e91ade7f76fdd2f6ef04738dd9c029bb3cb5198
Reviewed-on: http://gerrit.cloudera.org:8080/1745
Reviewed-by: Mike Percy <mpercy@cloudera.com>
Tested-by: Todd Lipcon <todd@cloudera.com>


Project: http://git-wip-us.apache.org/repos/asf/incubator-kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-kudu/commit/b9b265d9
Tree: http://git-wip-us.apache.org/repos/asf/incubator-kudu/tree/b9b265d9
Diff: http://git-wip-us.apache.org/repos/asf/incubator-kudu/diff/b9b265d9

Branch: refs/heads/master
Commit: b9b265d952bc93e1051df9c146d6b88369eea3ee
Parents: 794aaca
Author: Todd Lipcon <todd@cloudera.com>
Authored: Thu Jan 7 15:27:20 2016 -0800
Committer: Todd Lipcon <todd@cloudera.com>
Committed: Fri Jan 8 03:11:15 2016 +0000

----------------------------------------------------------------------
 build-support/dist_test.py | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/b9b265d9/build-support/dist_test.py
----------------------------------------------------------------------
diff --git a/build-support/dist_test.py b/build-support/dist_test.py
index 26297cf..2b74740 100755
--- a/build-support/dist_test.py
+++ b/build-support/dist_test.py
@@ -56,10 +56,6 @@ DEPS_FOR_ALL = \
      "build-support/tsan-suppressions.txt",
      "build-support/lsan-suppressions.txt",
 
-     # TODO: should pick these up from ldd so that we don't
-     # distribute more than necessary.
-     "thirdparty/installed/lib/",
-
      # Tests that use the external minicluster require these.
      # TODO: declare these dependencies per-test.
      "build/latest/kudu-tserver",
@@ -187,7 +183,14 @@ def ldd_deps(exe):
     lib = m.group(1)
     if is_lib_blacklisted(lib):
       continue
+    path = m.group(1)
     ret.append(m.group(1))
+
+    # ldd will often point to symlinks. We need to upload the symlink
+    # as well as whatever it's pointing to, recursively.
+    while os.path.islink(path):
+      path = os.path.join(os.path.dirname(path), os.readlink(path))
+      ret.append(path)
   return ret
 
 


Mime
View raw message