kudu-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ale...@apache.org
Subject kudu git commit: [build] disable tcmalloc for OS X builds
Date Tue, 09 May 2017 00:00:58 GMT
Repository: kudu
Updated Branches:
  refs/heads/master 04e8ea244 -> ddd898106


[build] disable tcmalloc for OS X builds

As a workaround for KUDU-1998, tcmalloc is disabled for OS X builds.

Change-Id: I005b34a6ead1a17a2fde6e5d873c99fc0d003308
Reviewed-on: http://gerrit.cloudera.org:8080/6821
Reviewed-by: Will Berkeley <wdberkeley@gmail.com>
Reviewed-by: Adar Dembo <adar@cloudera.com>
Tested-by: Alexey Serbin <aserbin@cloudera.com>


Project: http://git-wip-us.apache.org/repos/asf/kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/ddd89810
Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/ddd89810
Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/ddd89810

Branch: refs/heads/master
Commit: ddd898106b9582c17f48843710722e2f9547cfeb
Parents: 04e8ea2
Author: Alexey Serbin <aserbin@cloudera.com>
Authored: Mon May 8 15:54:35 2017 -0700
Committer: Alexey Serbin <aserbin@cloudera.com>
Committed: Tue May 9 00:00:14 2017 +0000

----------------------------------------------------------------------
 CMakeLists.txt | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kudu/blob/ddd89810/CMakeLists.txt
----------------------------------------------------------------------
diff --git a/CMakeLists.txt b/CMakeLists.txt
index c3b7169..6c2a7c5 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -889,8 +889,10 @@ ADD_THIRDPARTY_LIB(krb5
 ##
 ## Disabled with TSAN/ASAN as well as with gold+dynamic linking (see comment
 ## near definition of KUDU_USING_GOLD).
+## As a workaround for KUDU-1998, tcmalloc is disabled in OS X builds.
 find_package(GPerf REQUIRED)
-if (NOT "${KUDU_USE_ASAN}" AND
+if (NOT APPLE AND
+    NOT "${KUDU_USE_ASAN}" AND
     NOT "${KUDU_USE_TSAN}" AND
     NOT ("${KUDU_USING_GOLD}" AND "${KUDU_LINK}" STREQUAL "d"))
   ADD_THIRDPARTY_LIB(tcmalloc


Mime
View raw message