kudu-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From a...@apache.org
Subject [1/4] kudu git commit: Make exactly_once_writes-itest fail fast
Date Wed, 10 May 2017 18:45:13 GMT
Repository: kudu
Updated Branches:
  refs/heads/master a877566e9 -> b927e80a8


Make exactly_once_writes-itest fail fast

In this test sometimes a process will crash but the test will
keep running until the timeout spewing messages such as:

...
connection to 127.0.197.0:36258: connect: Connection refused (error 111). Retrying in the
next heartbeat period. Already tried 2075 times.
../../src/kudu/integration-tests/ts_itest-base.h:500: Failure
Value of: cluster_->tablet_server(i)->IsProcessAlive()
  Actual: false
Expected: true
Tablet server 0 crashed
...

This is because AssertNoTabletServersCrashed() doesn't actually
fail the test.

This patch adds a NO_FATALS to make sure we fail fast in this case,
making failures easier and faster to debug.

All other uses of AssertNoTabletServersCrashed() are wrapped in
NO_FATALS.

Change-Id: Ie77595d906863ea2d41f8df9b93cd6cc27514774
Reviewed-on: http://gerrit.cloudera.org:8080/6834
Reviewed-by: Todd Lipcon <todd@apache.org>
Tested-by: Kudu Jenkins


Project: http://git-wip-us.apache.org/repos/asf/kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/dfa13cd8
Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/dfa13cd8
Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/dfa13cd8

Branch: refs/heads/master
Commit: dfa13cd84da6474f926adb13b899da0d8cd271d7
Parents: a877566
Author: David Alves <dralves@apache.org>
Authored: Tue May 9 15:49:23 2017 -0700
Committer: David Ribeiro Alves <davidralves@gmail.com>
Committed: Wed May 10 01:08:58 2017 +0000

----------------------------------------------------------------------
 src/kudu/integration-tests/exactly_once_writes-itest.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kudu/blob/dfa13cd8/src/kudu/integration-tests/exactly_once_writes-itest.cc
----------------------------------------------------------------------
diff --git a/src/kudu/integration-tests/exactly_once_writes-itest.cc b/src/kudu/integration-tests/exactly_once_writes-itest.cc
index a89a129..b05c537 100644
--- a/src/kudu/integration-tests/exactly_once_writes-itest.cc
+++ b/src/kudu/integration-tests/exactly_once_writes-itest.cc
@@ -195,7 +195,7 @@ void ExactlyOnceSemanticsITest::DoTestWritesWithExactlyOnceSemantics(
     if (allow_crashes) {
       RestartAnyCrashedTabletServers();
     } else {
-      AssertNoTabletServersCrashed();
+      NO_FATALS(AssertNoTabletServersCrashed());
     }
 
     SleepFor(MonoDelta::FromMilliseconds(10));


Mime
View raw message